mbox series

[v2,0/2] Selftests: Fix compilation warnings due to missing _GNU_SOURCE definition

Message ID 20240509053113.43462-1-tao1.su@linux.intel.com
Headers show
Series Selftests: Fix compilation warnings due to missing _GNU_SOURCE definition | expand

Message

Tao Su May 9, 2024, 5:31 a.m. UTC 
Since kselftest_harness.h introduces asprintf()[1], many selftests have
compilation warnings or errors due to missing _GNU_SOURCE definitions.

The issue stems from a lack of a LINE_MAX definition in Android (see
commit 38c957f07038), which is the reason why asprintf() was introduced.
We tried adding _GNU_SOURCE definitions to more selftests to fix, but
asprintf() may continue to cause problems, and since it is quite late in
the 6.9 cycle, we would like to revert 809216233555 first to provide
testing for forks[2].

[1] https://lore.kernel.org/all/20240411231954.62156-1-edliaw@google.com
[2] https://lore.kernel.org/linux-kselftest/ZjuA3aY_iHkjP7bQ@google.com

v1 -> v2:
- Stop defining _GNU_SOURCE in related selftests
- Revert commit 809216233555
- Use 1024 in place of LINE_MAX to fix 38c957f07038

v1: https://lore.kernel.org/all/20240507063534.4191447-1-tao1.su@linux.intel.com/

Tao Su (2):
  Revert "selftests/harness: remove use of LINE_MAX"
  selftests/harness: Use 1024 in place of LINE_MAX

 tools/testing/selftests/kselftest_harness.h | 11 +++--------
 tools/testing/selftests/mm/mdwe_test.c      |  1 -
 2 files changed, 3 insertions(+), 9 deletions(-)


base-commit: 45db3ab70092637967967bfd8e6144017638563c