mbox series

[v2,0/3] rtc: s3c: S3C driver improvements

Message ID 20211021202256.28517-1-semen.protsenko@linaro.org
Headers show
Series rtc: s3c: S3C driver improvements | expand

Message

Sam Protsenko Oct. 21, 2021, 8:22 p.m. UTC
While working on Exynos850 support (where this driver works fine in its
current state), I've stumbled upon some minor issue. This is the effort
to fix those.

  * [PATCH 1/3]: moves S3C RTC driver to newer API usage
    (no functional changes)
  * [PATCH 2/3]: refactoring/cleanup (no functional changes)
  * [PATCH 3/3]: adds time range, as [PATCH 1/3] made it possible

Changes in v2:
  - Dropped "rtc: s3c: Fix RTC read on first boot" patch
  - Switched the order for [PATCH 2/3] and [PATCH 3/3], so that the
    refactoring patch can stay w/o functional changes w.r.t. previous
    state
  - See also changelist for each particular patch

Sam Protsenko (3):
  rtc: s3c: Remove usage of devm_rtc_device_register()
  rtc: s3c: Extract read/write IO into separate functions
  rtc: s3c: Add time range

 drivers/rtc/rtc-s3c.c | 106 ++++++++++++++++++++++++++----------------
 1 file changed, 65 insertions(+), 41 deletions(-)

Comments

Alexandre Belloni Oct. 23, 2021, 9:58 p.m. UTC | #1
On Thu, 21 Oct 2021 23:22:53 +0300, Sam Protsenko wrote:
> While working on Exynos850 support (where this driver works fine in its
> current state), I've stumbled upon some minor issue. This is the effort
> to fix those.
> 
>   * [PATCH 1/3]: moves S3C RTC driver to newer API usage
>     (no functional changes)
>   * [PATCH 2/3]: refactoring/cleanup (no functional changes)
>   * [PATCH 3/3]: adds time range, as [PATCH 1/3] made it possible
> 
> [...]

Applied, thanks!

[1/3] rtc: s3c: Remove usage of devm_rtc_device_register()
      commit: dba28c37f23a09fc32dbc37463ddb2feb3886f98
[2/3] rtc: s3c: Extract read/write IO into separate functions
      commit: e4a1444e10cbda2892a4ea7325ef5efa47c75cfb
[3/3] rtc: s3c: Add time range
      commit: a5feda3b361e11b291786d5c4ff86d4b9a55498f

Best regards,
Sam Protsenko Nov. 11, 2021, 5:05 p.m. UTC | #2
On Sun, 24 Oct 2021 at 00:58, Alexandre Belloni
<alexandre.belloni@bootlin.com> wrote:
>
> On Thu, 21 Oct 2021 23:22:53 +0300, Sam Protsenko wrote:
> > While working on Exynos850 support (where this driver works fine in its
> > current state), I've stumbled upon some minor issue. This is the effort
> > to fix those.
> >
> >   * [PATCH 1/3]: moves S3C RTC driver to newer API usage
> >     (no functional changes)
> >   * [PATCH 2/3]: refactoring/cleanup (no functional changes)
> >   * [PATCH 3/3]: adds time range, as [PATCH 1/3] made it possible
> >
> > [...]
>
> Applied, thanks!
>

Hi Alexandre,

Just want to check if this series is going to be merged during current
merge window, or is it scheduled for the next one?

Thanks!

> [1/3] rtc: s3c: Remove usage of devm_rtc_device_register()
>       commit: dba28c37f23a09fc32dbc37463ddb2feb3886f98
> [2/3] rtc: s3c: Extract read/write IO into separate functions
>       commit: e4a1444e10cbda2892a4ea7325ef5efa47c75cfb
> [3/3] rtc: s3c: Add time range
>       commit: a5feda3b361e11b291786d5c4ff86d4b9a55498f
>
> Best regards,
> --
> Alexandre Belloni <alexandre.belloni@bootlin.com>
Alexandre Belloni Nov. 12, 2021, 10:19 p.m. UTC | #3
On 11/11/2021 19:05:06+0200, Sam Protsenko wrote:
> On Sun, 24 Oct 2021 at 00:58, Alexandre Belloni
> <alexandre.belloni@bootlin.com> wrote:
> >
> > On Thu, 21 Oct 2021 23:22:53 +0300, Sam Protsenko wrote:
> > > While working on Exynos850 support (where this driver works fine in its
> > > current state), I've stumbled upon some minor issue. This is the effort
> > > to fix those.
> > >
> > >   * [PATCH 1/3]: moves S3C RTC driver to newer API usage
> > >     (no functional changes)
> > >   * [PATCH 2/3]: refactoring/cleanup (no functional changes)
> > >   * [PATCH 3/3]: adds time range, as [PATCH 1/3] made it possible
> > >
> > > [...]
> >
> > Applied, thanks!
> >
> 
> Hi Alexandre,
> 
> Just want to check if this series is going to be merged during current
> merge window, or is it scheduled for the next one?
> 

This is now pulled by Linus.

> Thanks!
> 
> > [1/3] rtc: s3c: Remove usage of devm_rtc_device_register()
> >       commit: dba28c37f23a09fc32dbc37463ddb2feb3886f98
> > [2/3] rtc: s3c: Extract read/write IO into separate functions
> >       commit: e4a1444e10cbda2892a4ea7325ef5efa47c75cfb
> > [3/3] rtc: s3c: Add time range
> >       commit: a5feda3b361e11b291786d5c4ff86d4b9a55498f
> >
> > Best regards,
> > --
> > Alexandre Belloni <alexandre.belloni@bootlin.com>