| Message ID | 20200924105256.18162-1-u.kleine-koenig@pengutronix.de |
|---|---|
| Headers | show |
| Series | rtc: pcf2127: only use watchdog when explicitly available | expand |
Any update for this patchset? Best Regards Qiang Zhao > -----Original Message----- > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > Sent: 2020年9月24日 18:53 > To: Alexandre Belloni <alexandre.belloni@bootlin.com>; Qiang Zhao > <qiang.zhao@nxp.com>; Bruno Thomsen <bruno.thomsen@gmail.com> > Cc: linux-rtc@vger.kernel.org; a.zummo@towertech.it; > linux-watchdog@vger.kernel.org; devicetree@vger.kernel.org; > linux-kernel@vger.kernel.org; robh+dt@kernel.org; kernel@pengutronix.de; > Wim Van Sebroeck <wim@linux-watchdog.org>; Guenter Roeck > <linux@roeck-us.net> > Subject: [PATCH 0/2] rtc: pcf2127: only use watchdog when explicitly available > > Hello, > > now that there are two people stumbling over the pcf2127 driver providing a > non-functional watchdog device, here comes an RFC patch to address this. > > Note this is only compile tested and dt-documentation is still missing. > Still send this series because the cleanup is nice independent of this discussion > and to have something to argue about. > > Does someone can offer a better name than "has-watchdog", is there a scheme > that could be used already that I'm not aware of? > > Best regards > Uwe > > Uwe Kleine-König (2): > rtc: pcf2127: move watchdog initialisation to a separate function > [RFC] rtc: pcf2127: only use watchdog when explicitly available > > drivers/rtc/rtc-pcf2127.c | 57 ++++++++++++++++++++++----------------- > 1 file changed, 32 insertions(+), 25 deletions(-) > > -- > 2.28.0
On 26/10/2020 07:23:26+0000, Qiang Zhao wrote: > Any update for this patchset? > The whole point would be to get the DT and the watchdog maintainers agree on the property name. Once done, the driver implementation is trivial and will get applied. > Best Regards > Qiang Zhao > > > -----Original Message----- > > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > Sent: 2020年9月24日 18:53 > > To: Alexandre Belloni <alexandre.belloni@bootlin.com>; Qiang Zhao > > <qiang.zhao@nxp.com>; Bruno Thomsen <bruno.thomsen@gmail.com> > > Cc: linux-rtc@vger.kernel.org; a.zummo@towertech.it; > > linux-watchdog@vger.kernel.org; devicetree@vger.kernel.org; > > linux-kernel@vger.kernel.org; robh+dt@kernel.org; kernel@pengutronix.de; > > Wim Van Sebroeck <wim@linux-watchdog.org>; Guenter Roeck > > <linux@roeck-us.net> > > Subject: [PATCH 0/2] rtc: pcf2127: only use watchdog when explicitly available > > > > Hello, > > > > now that there are two people stumbling over the pcf2127 driver providing a > > non-functional watchdog device, here comes an RFC patch to address this. > > > > Note this is only compile tested and dt-documentation is still missing. > > Still send this series because the cleanup is nice independent of this discussion > > and to have something to argue about. > > > > Does someone can offer a better name than "has-watchdog", is there a scheme > > that could be used already that I'm not aware of? > > > > Best regards > > Uwe > > > > Uwe Kleine-König (2): > > rtc: pcf2127: move watchdog initialisation to a separate function > > [RFC] rtc: pcf2127: only use watchdog when explicitly available > > > > drivers/rtc/rtc-pcf2127.c | 57 ++++++++++++++++++++++----------------- > > 1 file changed, 32 insertions(+), 25 deletions(-) > > > > -- > > 2.28.0 >
On Mon, Oct 26, 2020 at 09:48:11PM +0100, Alexandre Belloni wrote: > On 26/10/2020 07:23:26+0000, Qiang Zhao wrote: > > Any update for this patchset? > > > > The whole point would be to get the DT and the watchdog maintainers > agree on the property name. Once done, the driver implementation is > trivial and will get applied. > DT maintainers make that decision. Guenter > > Best Regards > > Qiang Zhao > > > > > -----Original Message----- > > > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > > Sent: 2020年9月24日 18:53 > > > To: Alexandre Belloni <alexandre.belloni@bootlin.com>; Qiang Zhao > > > <qiang.zhao@nxp.com>; Bruno Thomsen <bruno.thomsen@gmail.com> > > > Cc: linux-rtc@vger.kernel.org; a.zummo@towertech.it; > > > linux-watchdog@vger.kernel.org; devicetree@vger.kernel.org; > > > linux-kernel@vger.kernel.org; robh+dt@kernel.org; kernel@pengutronix.de; > > > Wim Van Sebroeck <wim@linux-watchdog.org>; Guenter Roeck > > > <linux@roeck-us.net> > > > Subject: [PATCH 0/2] rtc: pcf2127: only use watchdog when explicitly available > > > > > > Hello, > > > > > > now that there are two people stumbling over the pcf2127 driver providing a > > > non-functional watchdog device, here comes an RFC patch to address this. > > > > > > Note this is only compile tested and dt-documentation is still missing. > > > Still send this series because the cleanup is nice independent of this discussion > > > and to have something to argue about. > > > > > > Does someone can offer a better name than "has-watchdog", is there a scheme > > > that could be used already that I'm not aware of? > > > > > > Best regards > > > Uwe > > > > > > Uwe Kleine-König (2): > > > rtc: pcf2127: move watchdog initialisation to a separate function > > > [RFC] rtc: pcf2127: only use watchdog when explicitly available > > > > > > drivers/rtc/rtc-pcf2127.c | 57 ++++++++++++++++++++++----------------- > > > 1 file changed, 32 insertions(+), 25 deletions(-) > > > > > > -- > > > 2.28.0 > > > > -- > Alexandre Belloni, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
On 24/09/2020 12.52, Uwe Kleine-König wrote: > Hello, > > now that there are two people stumbling over the pcf2127 driver > providing a non-functional watchdog device, here comes an RFC patch to > address this. I just want to add a "me too" here, as I'm also now affected by the pcf2127 exposing a watchdog device (1) it didn't use to (affecting what /dev/watchdog0 means) and (2) is not actually hooked up in hardware. So can we please move forward with adding the has-watchdog opt-in DT property so existing boards will not be affected? Thanks, Rasmus
On 30/11/2020 10:51:41+0100, Rasmus Villemoes wrote: > On 24/09/2020 12.52, Uwe Kleine-König wrote: > > Hello, > > > > now that there are two people stumbling over the pcf2127 driver > > providing a non-functional watchdog device, here comes an RFC patch to > > address this. > > I just want to add a "me too" here, as I'm also now affected by the > pcf2127 exposing a watchdog device (1) it didn't use to (affecting what > /dev/watchdog0 means) and (2) is not actually hooked up in hardware. > > So can we please move forward with adding the has-watchdog opt-in DT > property so existing boards will not be affected? > Well, someone has to get that property reviewed by Rob. Maybe this could be reset-source as we have wakeup-source.