| Message ID | 20240520103329.381158-4-harshpb@linux.ibm.com |
|---|---|
| State | New |
| Headers | show |
| Series | target/ppc: misc ppc improvements/optimizations | expand |
On Mon, 20 May 2024, Harsh Prateek Bora wrote: > The second if-condition can be true only if the first one above is true. > Enclose the latter into the former to avoid un-necessary check if first > condition fails. > > Signed-off-by: Harsh Prateek Bora <harshpb@linux.ibm.com> Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu> > --- > target/ppc/helper_regs.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/target/ppc/helper_regs.c b/target/ppc/helper_regs.c > index 5de0df5795..89aacdf212 100644 > --- a/target/ppc/helper_regs.c > +++ b/target/ppc/helper_regs.c > @@ -66,9 +66,9 @@ static uint32_t hreg_compute_pmu_hflags_value(CPUPPCState *env) > #ifndef CONFIG_USER_ONLY > if (env->pmc_ins_cnt) { > hflags |= 1 << HFLAGS_INSN_CNT; > - } > - if (env->pmc_ins_cnt & 0x1e) { > - hflags |= 1 << HFLAGS_PMC_OTHER; > + if (env->pmc_ins_cnt & 0x1e) { > + hflags |= 1 << HFLAGS_PMC_OTHER; > + } > } > #endif > #endif >
diff --git a/target/ppc/helper_regs.c b/target/ppc/helper_regs.c index 5de0df5795..89aacdf212 100644 --- a/target/ppc/helper_regs.c +++ b/target/ppc/helper_regs.c @@ -66,9 +66,9 @@ static uint32_t hreg_compute_pmu_hflags_value(CPUPPCState *env) #ifndef CONFIG_USER_ONLY if (env->pmc_ins_cnt) { hflags |= 1 << HFLAGS_INSN_CNT; - } - if (env->pmc_ins_cnt & 0x1e) { - hflags |= 1 << HFLAGS_PMC_OTHER; + if (env->pmc_ins_cnt & 0x1e) { + hflags |= 1 << HFLAGS_PMC_OTHER; + } } #endif #endif
The second if-condition can be true only if the first one above is true. Enclose the latter into the former to avoid un-necessary check if first condition fails. Signed-off-by: Harsh Prateek Bora <harshpb@linux.ibm.com> --- target/ppc/helper_regs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)