| Message ID | 20231006053526.1031252-1-clg@kaod.org |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | target/ppc: Clean up local variable shadowing in kvm_arch_*_registers() | expand |
On 06/10/2023 07.35, Cédric Le Goater wrote: > Remove extra 'i' variable to fix this warning : > > ../target/ppc/kvm.c: In function ‘kvm_arch_put_registers’: > ../target/ppc/kvm.c:963:13: warning: declaration of ‘i’ shadows a previous local [-Wshadow=compatible-local] > 963 | int i; > | ^ > ../target/ppc/kvm.c:906:9: note: shadowed declaration is here > 906 | int i; > | ^ > ../target/ppc/kvm.c: In function ‘kvm_arch_get_registers’: > ../target/ppc/kvm.c:1265:13: warning: declaration of ‘i’ shadows a previous local [-Wshadow=compatible-local] > 1265 | int i; > | ^ > ../target/ppc/kvm.c:1212:9: note: shadowed declaration is here > 1212 | int i, ret; > | ^ > > Signed-off-by: Cédric Le Goater <clg@kaod.org> > --- > target/ppc/kvm.c | 4 ---- > 1 file changed, 4 deletions(-) Reviewed-by: Thomas Huth <thuth@redhat.com>
Cédric Le Goater <clg@kaod.org> writes: > Remove extra 'i' variable to fix this warning : > > ../target/ppc/kvm.c: In function ‘kvm_arch_put_registers’: > ../target/ppc/kvm.c:963:13: warning: declaration of ‘i’ shadows a previous local [-Wshadow=compatible-local] > 963 | int i; > | ^ > ../target/ppc/kvm.c:906:9: note: shadowed declaration is here > 906 | int i; > | ^ > ../target/ppc/kvm.c: In function ‘kvm_arch_get_registers’: > ../target/ppc/kvm.c:1265:13: warning: declaration of ‘i’ shadows a previous local [-Wshadow=compatible-local] > 1265 | int i; > | ^ > ../target/ppc/kvm.c:1212:9: note: shadowed declaration is here > 1212 | int i, ret; > | ^ > > Signed-off-by: Cédric Le Goater <clg@kaod.org> Queued, thanks!
diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index 51112bd3670d..d0e2dcdc7734 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -960,8 +960,6 @@ int kvm_arch_put_registers(CPUState *cs, int level) } if (cap_one_reg) { - int i; - /* * We deliberately ignore errors here, for kernels which have * the ONE_REG calls, but don't support the specific @@ -1262,8 +1260,6 @@ int kvm_arch_get_registers(CPUState *cs) } if (cap_one_reg) { - int i; - /* * We deliberately ignore errors here, for kernels which have * the ONE_REG calls, but don't support the specific
Remove extra 'i' variable to fix this warning : ../target/ppc/kvm.c: In function ‘kvm_arch_put_registers’: ../target/ppc/kvm.c:963:13: warning: declaration of ‘i’ shadows a previous local [-Wshadow=compatible-local] 963 | int i; | ^ ../target/ppc/kvm.c:906:9: note: shadowed declaration is here 906 | int i; | ^ ../target/ppc/kvm.c: In function ‘kvm_arch_get_registers’: ../target/ppc/kvm.c:1265:13: warning: declaration of ‘i’ shadows a previous local [-Wshadow=compatible-local] 1265 | int i; | ^ ../target/ppc/kvm.c:1212:9: note: shadowed declaration is here 1212 | int i, ret; | ^ Signed-off-by: Cédric Le Goater <clg@kaod.org> --- target/ppc/kvm.c | 4 ---- 1 file changed, 4 deletions(-)