From patchwork Sat Aug 29 14:10:27 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Blue Swirl X-Patchwork-Id: 32506 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by bilbo.ozlabs.org (Postfix) with ESMTPS id 3E3C6B70C4 for ; Sun, 30 Aug 2009 00:17:43 +1000 (EST) Received: from localhost ([127.0.0.1]:50606 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MhOkJ-0004zO-Vg for incoming@patchwork.ozlabs.org; Sat, 29 Aug 2009 10:17:36 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MhOdw-000346-0u for qemu-devel@nongnu.org; Sat, 29 Aug 2009 10:11:00 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MhOdr-00032P-2m for qemu-devel@nongnu.org; Sat, 29 Aug 2009 10:10:59 -0400 Received: from [199.232.76.173] (port=54728 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MhOdq-00032K-SM for qemu-devel@nongnu.org; Sat, 29 Aug 2009 10:10:54 -0400 Received: from mail-ew0-f223.google.com ([209.85.219.223]:38548) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MhOdn-0004BP-7K for qemu-devel@nongnu.org; Sat, 29 Aug 2009 10:10:54 -0400 Received: by ewy23 with SMTP id 23so3204445ewy.8 for ; Sat, 29 Aug 2009 07:10:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:from:date:message-id :subject:to:content-type; bh=GD7mrW1C8CglXbCt5NqBWeh/F6d8Yaj8FtsfCXWvObo=; b=Yf7eUTXGraqUbmjKLBQAylDiR4RSO6668l/UFFtXjAqcfJ2jp4oNVRtivvATK1Hi+F XSFsqfXuUc0+WVIYdZ78Lf5Sx8CBj02MjFcEIsBJRhffNjedvAp+G6ndz1JIerCzAJ1E sA9CJcoYyO04b1WhNPAGap9bfCwCopg9Gy55Y= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=uk+VISv02tY43qrQKbG+7gDpmVHWnbK6qBWlTX7Qq5n3UNVCZk0H33Q71a0QciSar3 qKUV3C9yTO0C4QiFcisecs2HLtvtGCzjI2L5Rzek+ssW4OUIpVjgKPUgIkINbsgn1rak 2So2VG4ayGe8f94+7m1HoQ2G0n8b8l6mk3+gU= MIME-Version: 1.0 Received: by 10.210.59.10 with SMTP id h10mr1754291eba.47.1251555047085; Sat, 29 Aug 2009 07:10:47 -0700 (PDT) From: Blue Swirl Date: Sat, 29 Aug 2009 17:10:27 +0300 Message-ID: To: qemu-devel X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: [Qemu-devel] [PATCH, RFC 5/5] PPC: use device info for CPU statistics X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Blue Swirl --- cpu-all.h | 3 --- monitor.c | 15 --------------- qemu-monitor.hx | 2 -- target-ppc/cpu.h | 2 ++ target-ppc/helper.c | 1 + target-ppc/translate.c | 40 ++++++++++++++++++++++++---------------- 6 files changed, 27 insertions(+), 36 deletions(-) diff --git a/cpu-all.h b/cpu-all.h index 1a6a812..de65fb8 100644 --- a/cpu-all.h +++ b/cpu-all.h @@ -752,9 +752,6 @@ CPUState *qemu_get_cpu(int cpu); void cpu_dump_state(CPUState *env, FILE *f, int (*cpu_fprintf)(FILE *f, const char *fmt, ...), int flags); -void cpu_dump_statistics (CPUState *env, FILE *f, - int (*cpu_fprintf)(FILE *f, const char *fmt, ...), - int flags); void QEMU_NORETURN cpu_abort(CPUState *env, const char *fmt, ...) __attribute__ ((__format__ (__printf__, 2, 3))); diff --git a/monitor.c b/monitor.c index 9a55e1c..57212da 100644 --- a/monitor.c +++ b/monitor.c @@ -408,17 +408,6 @@ static void do_info_history(Monitor *mon) } } -#if defined(TARGET_PPC) -/* XXX: not implemented in other targets */ -static void do_info_cpu_stats(Monitor *mon) -{ - CPUState *env; - - env = mon_get_cpu(); - cpu_dump_statistics(env, (FILE *)mon, &monitor_fprintf, 0); -} -#endif - static void do_quit(Monitor *mon) { exit(0); @@ -1827,10 +1816,6 @@ static const mon_cmd_t info_cmds[] = { "", "show the current VM name" }, { "uuid", "", do_info_uuid, "", "show the current VM UUID" }, -#if defined(TARGET_PPC) - { "cpustats", "", do_info_cpu_stats, - "", "show CPU statistics", }, -#endif #if defined(CONFIG_SLIRP) { "usernet", "", do_info_usernet, "", "show user network stack connection states", }, diff --git a/qemu-monitor.hx b/qemu-monitor.hx index 946ba34..c2ef603 100644 --- a/qemu-monitor.hx +++ b/qemu-monitor.hx @@ -73,8 +73,6 @@ show the vnc server status show the current VM name @item info uuid show the current VM UUID -@item info cpustats -show CPU statistics @item info usernet show user network stack connection states @item info migrate diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h index 27f523f..3cb0424 100644 --- a/target-ppc/cpu.h +++ b/target-ppc/cpu.h @@ -827,6 +827,8 @@ static inline void cpu_clone_regs(CPUState *env, target_ulong newsp) } #endif +void register_stats_handler(const char *name, CPUState *env1); + #include "cpu-all.h" #include "exec-all.h" diff --git a/target-ppc/helper.c b/target-ppc/helper.c index 5c85c61..192e137 100644 --- a/target-ppc/helper.c +++ b/target-ppc/helper.c @@ -2812,6 +2812,7 @@ CPUPPCState *cpu_ppc_init (const char *cpu_model) env->cpu_model_str = cpu_model; cpu_ppc_register_internal(env, def); cpu_ppc_reset(env); + register_stats_handler(cpu_model, env); qemu_init_vcpu(env); diff --git a/target-ppc/translate.c b/target-ppc/translate.c index 1c54fa7..547f370 100644 --- a/target-ppc/translate.c +++ b/target-ppc/translate.c @@ -28,6 +28,7 @@ #include "tcg-op.h" #include "qemu-common.h" #include "host-utils.h" +#include "monitor.h" #include "helper.h" #define GEN_HELPER 1 @@ -39,7 +40,7 @@ /* Include definitions for instructions classes and implementations flags */ //#define PPC_DEBUG_DISAS -//#define DO_PPC_STATISTICS +#define DO_PPC_STATISTICS #ifdef PPC_DEBUG_DISAS # define LOG_DISAS(...) qemu_log_mask(CPU_LOG_TB_IN_ASM, ## __VA_ARGS__) @@ -8898,11 +8899,10 @@ void cpu_dump_state (CPUState *env, FILE *f, #undef RFPL } -void cpu_dump_statistics (CPUState *env, FILE*f, - int (*cpu_fprintf)(FILE *f, const char *fmt, ...), - int flags) +static void cpu_dump_statistics(Monitor *mon, void *opaque) { #if defined(DO_PPC_STATISTICS) + CPUState *env = opaque; opc_handler_t **t1, **t2, **t3, *handler; int op1, op2, op3; @@ -8919,32 +8919,40 @@ void cpu_dump_statistics (CPUState *env, FILE*f, handler = t3[op3]; if (handler->count == 0) continue; - cpu_fprintf(f, "%02x %02x %02x (%02x %04d) %16s: " - "%016llx %lld\n", - op1, op2, op3, op1, (op3 << 5) | op2, - handler->oname, - handler->count, handler->count); + monitor_printf(mon, "%02x %02x %02x (%02x %04d) %16s: " + "%016" PRIx64 " %" PRId64 "\n", + op1, op2, op3, op1, (op3 << 5) | op2, + handler->oname, + handler->count, handler->count); } } else { if (handler->count == 0) continue; - cpu_fprintf(f, "%02x %02x (%02x %04d) %16s: " - "%016llx %lld\n", - op1, op2, op1, op2, handler->oname, - handler->count, handler->count); + monitor_printf(mon, "%02x %02x (%02x %04d) %16s: " + "%016" PRIx64 " %" PRId64 "\n", + op1, op2, op1, op2, handler->oname, + handler->count, handler->count); } } } else { if (handler->count == 0) continue; - cpu_fprintf(f, "%02x (%02x ) %16s: %016llx %lld\n", - op1, op1, handler->oname, - handler->count, handler->count); + monitor_printf(mon, "%02x (%02x ) %16s: %016" PRIx64 + " %" PRId64 "\n", + op1, op1, handler->oname, + handler->count, handler->count); } } +#else + monitor_printf(mon, "CPU statistics not compiled\n"); #endif } +void register_stats_handler(const char *name, CPUState *env1) +{ + monitor_register_device_info(name, cpu_dump_statistics, env1); +} + /*****************************************************************************/ static inline void gen_intermediate_code_internal(CPUState *env, TranslationBlock *tb,