From patchwork Tue Apr 3 21:00:45 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Mammedov X-Patchwork-Id: 150550 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 24B04B6FE4 for ; Wed, 4 Apr 2012 07:33:51 +1000 (EST) Received: from localhost ([::1]:38307 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SFAqX-0007NX-R4 for incoming@patchwork.ozlabs.org; Tue, 03 Apr 2012 17:00:57 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36159) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SFAqQ-0007MV-56 for qemu-devel@nongnu.org; Tue, 03 Apr 2012 17:00:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SFAqO-0000VC-DY for qemu-devel@nongnu.org; Tue, 03 Apr 2012 17:00:49 -0400 Received: from mx4-phx2.redhat.com ([209.132.183.25]:46439) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SFAqO-0000V0-1w for qemu-devel@nongnu.org; Tue, 03 Apr 2012 17:00:48 -0400 Received: from zmail16.collab.prod.int.phx2.redhat.com (zmail16.collab.prod.int.phx2.redhat.com [10.5.83.18]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q33L0jIB029403; Tue, 3 Apr 2012 17:00:45 -0400 Date: Tue, 03 Apr 2012 17:00:45 -0400 (EDT) From: Igor Mammedov To: qemu-devel@nongnu.org Message-ID: In-Reply-To: <1333453972-24695-1-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 X-Originating-IP: [10.3.224.252] X-Mailer: Zimbra 7.1.2_GA_3268 (ZimbraWebClient - FF3.0 (Linux)/7.1.2_GA_3268) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 209.132.183.25 Cc: Paolo Bonzini , alex.williamson@redhat.com, gleb@redhat.com, mst@redhat.com Subject: Re: [Qemu-devel] [PATCH] Fix race resulting in loosing event bit in GPE.1.sts X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Tried another approach, that involves only seabios change as specified in acpi50.spec: 5.6.4 General-Purpose Event Handling by switching from level to edge handler. It fixes problem (at least I wasn't able to hit window between GPE00.sts read and GPE00.sts reset, too small interval). It seems to work as expected with rhel6, 3.3+ kernel, winxp, ws2008r2. Will post patch to seabios list and hope we won't need this one in qemu. diff --git a/src/acpi-dsdt.dsl b/src/acpi-dsdt.dsl index 4e04c48..51906ad 100644 --- a/src/acpi-dsdt.dsl +++ b/src/acpi-dsdt.dsl @@ -723,7 +723,7 @@ DefinitionBlock ( Method(_L00) { Return(0x01) } - Method(_L01) { + Method(_E01) { // PCI hotplug event Return(\_SB.PCI0.PCNF()) }