Message ID | d92eb46865f162caff1ca2f98b4e618608051ff3.1423298325.git.jan.kiszka@web.de |
---|---|
State | New |
Headers | show |
On 7 February 2015 at 08:38, Jan Kiszka <jan.kiszka@web.de> wrote: > From: Jan Kiszka <jan.kiszka@siemens.com> > > qOffsets has no additional optional parameters. So match the complete > string to avoid stumbling over possible future commands with identical > prefix. > > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> > --- > gdbstub.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdbstub.c b/gdbstub.c > index e4a1a79..cd25d1a 100644 > --- a/gdbstub.c > +++ b/gdbstub.c > @@ -1107,7 +1107,7 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf) > break; > } > #ifdef CONFIG_USER_ONLY > - else if (strncmp(p, "Offsets", 7) == 0) { > + else if (strcmp(p, "Offsets") == 0) { > TaskState *ts = s->c_cpu->opaque; > > snprintf(buf, sizeof(buf), We could write this as if (is_query_packet(p, "Offsets", 0)) but straight strcmp() works fine too. -- PMM
diff --git a/gdbstub.c b/gdbstub.c index e4a1a79..cd25d1a 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1107,7 +1107,7 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf) break; } #ifdef CONFIG_USER_ONLY - else if (strncmp(p, "Offsets", 7) == 0) { + else if (strcmp(p, "Offsets") == 0) { TaskState *ts = s->c_cpu->opaque; snprintf(buf, sizeof(buf),