From patchwork Mon Jun 22 21:32:18 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alberto Garcia X-Patchwork-Id: 487394 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4D1C81401AF for ; Tue, 23 Jun 2015 07:34:22 +1000 (AEST) Received: from localhost ([::1]:42072 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z79MB-0005ts-2y for incoming@patchwork.ozlabs.org; Mon, 22 Jun 2015 17:34:19 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57059) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z79LT-0004hZ-6z for qemu-devel@nongnu.org; Mon, 22 Jun 2015 17:33:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z79LL-0007HL-WC for qemu-devel@nongnu.org; Mon, 22 Jun 2015 17:33:35 -0400 Received: from smtp3.mundo-r.com ([212.51.32.191]:45142 helo=smtp4.mundo-r.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z79LL-0007Av-PP; Mon, 22 Jun 2015 17:33:27 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AoEIACp+iFVbdWOb/2dsb2JhbABcgxCBM6tmBQGBBAGMcYwSAoFATAEBAQEBAYELhCMBAQQnUhA/EjwbGYgzActJASuGG4owBxaEFQWGf4V4hwaHLYQhjW+CV4drJmNmQhwVgUBsgkgBAQE X-IPAS-Result: AoEIACp+iFVbdWOb/2dsb2JhbABcgxCBM6tmBQGBBAGMcYwSAoFATAEBAQEBAYELhCMBAQQnUhA/EjwbGYgzActJASuGG4owBxaEFQWGf4V4hwaHLYQhjW+CV4drJmNmQhwVgUBsgkgBAQE X-IronPort-AV: E=Sophos;i="5.13,661,1427752800"; d="scan'208";a="369492777" Received: from fanzine.igalia.com ([91.117.99.155]) by smtp4.mundo-r.com with ESMTP; 22 Jun 2015 23:32:50 +0200 Received: from dsl-hkibrasgw4-50df50-128.dhcp.inet.fi ([80.223.80.128] helo=perseus.local) by fanzine.igalia.com with esmtpsa (Cipher TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim) id 1Z79Kj-0005U0-Qm; Mon, 22 Jun 2015 23:32:50 +0200 Received: from berto by perseus.local with local (Exim 4.85) (envelope-from ) id 1Z79KW-0007xy-LE; Tue, 23 Jun 2015 00:32:36 +0300 From: Alberto Garcia To: qemu-devel@nongnu.org Date: Tue, 23 Jun 2015 00:32:18 +0300 Message-Id: X-Mailer: git-send-email 2.1.4 In-Reply-To: References: In-Reply-To: References: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 212.51.32.191 Cc: Alberto Garcia , Stefan Hajnoczi , qemu-block@nongnu.org Subject: [Qemu-devel] [PATCH v8 03/11] block: never cancel a streaming job without running stream_complete() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org We need to call stream_complete() in order to do all the necessary clean-ups, even if there's an early failure. At the moment it's only useful to make sure that s->backing_file_str is not leaked, but it will become more important as we introduce support for streaming to any intermediate node. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz Reviewed-by: Stefan Hajnoczi --- block/stream.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/block/stream.c b/block/stream.c index a628901..37bfd8b 100644 --- a/block/stream.c +++ b/block/stream.c @@ -114,21 +114,21 @@ static void coroutine_fn stream_run(void *opaque) StreamCompleteData *data; BlockDriverState *bs = s->common.bs; BlockDriverState *base = s->base; - int64_t sector_num, end; + int64_t sector_num = 0; + int64_t end = -1; int error = 0; int ret = 0; int n = 0; void *buf; if (!bs->backing_hd) { - block_job_completed(&s->common, 0); - return; + goto out; } s->common.len = bdrv_getlength(bs); if (s->common.len < 0) { - block_job_completed(&s->common, s->common.len); - return; + ret = s->common.len; + goto out; } end = s->common.len >> BDRV_SECTOR_BITS; @@ -215,6 +215,7 @@ wait: qemu_vfree(buf); +out: /* Modify backing chain and close BDSes in main loop */ data = g_malloc(sizeof(*data)); data->ret = ret;