From patchwork Mon Dec 10 16:47:15 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefano Stabellini X-Patchwork-Id: 204970 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id D76982C032C for ; Tue, 11 Dec 2012 03:47:59 +1100 (EST) Received: from localhost ([::1]:57871 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ti6WM-0006PA-2c for incoming@patchwork.ozlabs.org; Mon, 10 Dec 2012 11:47:58 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40749) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ti6Vs-0005st-Gc for qemu-devel@nongnu.org; Mon, 10 Dec 2012 11:47:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ti6Vi-0008Lh-Sa for qemu-devel@nongnu.org; Mon, 10 Dec 2012 11:47:28 -0500 Received: from smtp02.citrix.com ([66.165.176.63]:4589) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ti6Vi-0008LY-M6 for qemu-devel@nongnu.org; Mon, 10 Dec 2012 11:47:18 -0500 X-IronPort-AV: E=Sophos;i="4.84,252,1355097600"; d="scan'208";a="119876" Received: from ftlpex01cl01.citrite.net ([10.13.107.78]) by FTLPIPO02.CITRIX.COM with ESMTP/TLS/AES128-SHA; 10 Dec 2012 16:47:17 +0000 Received: from ukmail1.uk.xensource.com (10.80.16.128) by smtprelay.citrix.com (10.13.107.78) with Microsoft SMTP Server id 14.2.318.1; Mon, 10 Dec 2012 11:47:17 -0500 Received: from kaball.uk.xensource.com ([10.80.2.59]) by ukmail1.uk.xensource.com with esmtp (Exim 4.69) (envelope-from ) id 1Ti6Vh-0004Nt-5d; Mon, 10 Dec 2012 16:47:17 +0000 Date: Mon, 10 Dec 2012 16:47:15 +0000 From: Stefano Stabellini X-X-Sender: sstabellini@kaball.uk.xensource.com To: Sander Eikelenboom In-Reply-To: <183697744.20121207215104@eikelenboom.it> Message-ID: References: <92707120.20121206223208@eikelenboom.it> <183697744.20121207215104@eikelenboom.it> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 66.165.176.63 Cc: Anthony.Perard@citrix.com, xen-devel , qemu-devel@nongnu.org, Stefano Stabellini Subject: [Qemu-devel] [PATCH] xen: fix trivial PCI passthrough MSI-X bug X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org We are currently passing entry->data as address parameter. Pass entry->addr instead. Signed-off-by: Stefano Stabellini Tested-by: Sander Eikelenboom Xen-devel: http://marc.info/?l=xen-devel&m=135515462613715 diff --git a/hw/xen_pt_msi.c b/hw/xen_pt_msi.c index 6807672..db757cd 100644 --- a/hw/xen_pt_msi.c +++ b/hw/xen_pt_msi.c @@ -321,7 +321,7 @@ static int xen_pt_msix_update_one(XenPCIPassthroughState *s, int entry_nr) pirq = entry->pirq; - rc = msi_msix_setup(s, entry->data, entry->data, &pirq, true, entry_nr, + rc = msi_msix_setup(s, entry->addr, entry->data, &pirq, true, entry_nr, entry->pirq == XEN_PT_UNASSIGNED_PIRQ); if (rc) { return rc;