From patchwork Mon May 9 10:16:50 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Vesely X-Patchwork-Id: 94754 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 6C70EB6EF0 for ; Mon, 9 May 2011 20:17:04 +1000 (EST) Received: from localhost ([::1]:46220 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QJNWO-0000sa-Ta for incoming@patchwork.ozlabs.org; Mon, 09 May 2011 06:17:00 -0400 Received: from eggs.gnu.org ([140.186.70.92]:49023) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QJNWG-0000sD-Cw for qemu-devel@nongnu.org; Mon, 09 May 2011 06:16:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QJNWF-0004RA-JZ for qemu-devel@nongnu.org; Mon, 09 May 2011 06:16:52 -0400 Received: from mail-vx0-f173.google.com ([209.85.220.173]:56184) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QJNWF-0004R3-HE; Mon, 09 May 2011 06:16:51 -0400 Received: by vxb37 with SMTP id 37so6592627vxb.4 for ; Mon, 09 May 2011 03:16:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=xxLe6T747+4vXNyvyMJ2Tjv3Nyr6+GqyYPgo/65rbeE=; b=lIoh1zfdWx6/W4TfiNfuSiObJ7NiCuCu/tVWSSbP/2v15i34qqj6N3TQPOj/ZgdEak z5hiBBvzTte5BgQmIbA1w3ZXEtuPou9tI3wihDO78paEmPz1DylxlJ3VhijvC+7QMYgW EgudLeaIBllR8TckmOpydRZ/ErEFz1CDqqlaM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=U6gg8qXZQp39JtiX+7U2sRL4GU2cb1eXbYNHKUBwq7qJvM3jH0Lyeo6GvCHhl0KCv9 9cXgrB+DQQrPyDj9C3KUcXuMxbHbPD1+8tjVN2zLWzpSX543Av1xpATFMxiWUEy27A9S WNfIyzVpJSozmLM3FSrbmbPjVaB1KQn7m9C+8= MIME-Version: 1.0 Received: by 10.52.179.69 with SMTP id de5mr1045580vdc.304.1304936210253; Mon, 09 May 2011 03:16:50 -0700 (PDT) Received: by 10.220.158.131 with HTTP; Mon, 9 May 2011 03:16:50 -0700 (PDT) In-Reply-To: <4DC79DEC.50401@redhat.com> References: <4DC29287.5030106@redhat.com> <4DC79DEC.50401@redhat.com> Date: Mon, 9 May 2011 12:16:50 +0200 Message-ID: From: Jan Vesely To: Gerd Hoffmann X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.220.173 Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org Subject: Re: [Qemu-devel] Bug #757654: UHCI fails to signal stall response patch X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org UHCI host controller status register indicates error and an interrupt is triggered on BABBLE and STALL errors. Signed-off-by: Jan Vesely --- hw/usb-uhci.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c index a65e0b3..1e9c1e7 100644 --- a/hw/usb-uhci.c +++ b/hw/usb-uhci.c @@ -702,11 +702,15 @@ out: case USB_RET_STALL: td->ctrl |= TD_CTRL_STALL; td->ctrl &= ~TD_CTRL_ACTIVE; + s->status |= UHCI_STS_USBERR; + uhci_update_irq(s); return 1; case USB_RET_BABBLE: td->ctrl |= TD_CTRL_BABBLE | TD_CTRL_STALL; td->ctrl &= ~TD_CTRL_ACTIVE; + s->status |= UHCI_STS_USBERR; + uhci_update_irq(s); /* frame interrupted */ return -1;