From patchwork Wed May 12 02:28:51 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: TeLeMan X-Patchwork-Id: 52344 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 3D517B7DB8 for ; Wed, 12 May 2010 12:29:40 +1000 (EST) Received: from localhost ([127.0.0.1]:60875 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OC1hZ-0001KB-IZ for incoming@patchwork.ozlabs.org; Tue, 11 May 2010 22:29:37 -0400 Received: from [140.186.70.92] (port=45462 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OC1gs-0001H7-8l for qemu-devel@nongnu.org; Tue, 11 May 2010 22:28:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OC1gq-0006tK-Vn for qemu-devel@nongnu.org; Tue, 11 May 2010 22:28:54 -0400 Received: from mail-pv0-f173.google.com ([74.125.83.173]:62418) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OC1gq-0006tD-R2 for qemu-devel@nongnu.org; Tue, 11 May 2010 22:28:52 -0400 Received: by pvg12 with SMTP id 12so228945pvg.4 for ; Tue, 11 May 2010 19:28:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:date:message-id :subject:from:to:content-type; bh=uKjLRzi6ctUw90i52j5y3uxPRAEd6jpfMgomMwOHkw4=; b=hKJaXLYXf39O8Hn7M6eKs6jDTQmxfLBXuUQeE0NkGN+JO6XgD+ucQIbhdo4AFAnWCQ Lk3/JWXb6VMSZ3QMMrvRF73/eW61UUEx2fkxQH8HgFBxqLiAHcCcdrAPS/gbimgfp3PJ sT97wiXG+dLAO3pdAcaOjohl23Nnc6Y8zYrsI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=JrdQa5GsrKaDxesdXn4L9e0dgGFwErzeXZnwTvjODJbJEdmXMiT4Ps8kbCFzqCPHKP dEaiyagVWXgSOs3dUOKHNIHENL3K6WOaQEDjpYUBmEqoBvoMWWtmGpfty/i/b2TNAX6f O0lYwQpY3GJ4fHxJiDTkq1o88TSUlz15jBSH4= MIME-Version: 1.0 Received: by 10.141.109.10 with SMTP id l10mr4499727rvm.30.1273631331192; Tue, 11 May 2010 19:28:51 -0700 (PDT) Received: by 10.141.48.13 with HTTP; Tue, 11 May 2010 19:28:51 -0700 (PDT) Date: Wed, 12 May 2010 10:28:51 +0800 Message-ID: From: TeLeMan To: qemu-devel X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: [Qemu-devel] [PATCH][RESEND] vmstate: fix breakage by 7e72abc382b700a72549e8147bdea413534eeedc X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org cirrus_post_load() will be executed twice when loading vm states and then the wrong physical memory will be registered. This issue may lead to crash qemu. Signed-off-by: TeLeMan Acked-by: Juan Quintela --- hw/cirrus_vga.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) VMSTATE_STRUCT(cirrus_vga, PCICirrusVGAState, 0, -- SUN OF A BEACH diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c index 9dfe76a..262ba9c 100644 --- a/hw/cirrus_vga.c +++ b/hw/cirrus_vga.c @@ -3017,7 +3017,6 @@ static const VMStateDescription vmstate_pci_cirrus_vga = { .version_id = 2, .minimum_version_id = 2, .minimum_version_id_old = 2, - .post_load = cirrus_post_load, .fields = (VMStateField []) { VMSTATE_PCI_DEVICE(dev, PCICirrusVGAState),