| Message ID | 87oaul1fg9.fsf@blackfin.pond.sub.org |
|---|---|
| State | New |
| Headers | show |
> From: Markus Armbruster [mailto:armbru@redhat.com] > Sent: Friday, September 12, 2014 3:11 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; Huangweidong (C); kraxel@redhat.com > Subject: Re: [Qemu-devel] [PATCH 0/2] usb: Don't use qerror_report > > <arei.gonglei@huawei.com> writes: > > > From: Gonglei <arei.gonglei@huawei.com> > > > > qerror_report() is a transitional interface to help with converting > > existing HMP commands to QMP. It should not be used elsewhere. > > > > Gonglei (2): > > redirect.c: Don't use qerror_report() > > dev-network: Don't use qerror_report_err() > > > > hw/usb/dev-network.c | 2 +- > > hw/usb/redirect.c | 6 +++--- > > 2 files changed, 4 insertions(+), 4 deletions(-) > > Thanks for helping with getting rid of qerror.h. > > Squash in the appended two hunks and you can add my R-by. > Got it. Thanks! Best regards, -Gonglei > diff --git a/hw/usb/dev-network.c b/hw/usb/dev-network.c > index 0bf78d8..429ff58 100644 > --- a/hw/usb/dev-network.c > +++ b/hw/usb/dev-network.c > @@ -27,7 +27,7 @@ > #include "hw/usb.h" > #include "hw/usb/desc.h" > #include "net/net.h" > -#include "qapi/qmp/qerror.h" > +#include "qemu/error-report.h" > #include "qemu/queue.h" > #include "qemu/config-file.h" > #include "sysemu/sysemu.h" > diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c > index e852741..959a43c 100644 > --- a/hw/usb/redirect.c > +++ b/hw/usb/redirect.c > @@ -27,7 +27,7 @@ > > #include "qemu-common.h" > #include "qemu/timer.h" > -#include "monitor/monitor.h" > +#include "qemu/error-report.h" > #include "sysemu/sysemu.h" > #include "qemu/iov.h" > #include "sysemu/char.h"
diff --git a/hw/usb/dev-network.c b/hw/usb/dev-network.c index 0bf78d8..429ff58 100644 --- a/hw/usb/dev-network.c +++ b/hw/usb/dev-network.c @@ -27,7 +27,7 @@ #include "hw/usb.h" #include "hw/usb/desc.h" #include "net/net.h" -#include "qapi/qmp/qerror.h" +#include "qemu/error-report.h" #include "qemu/queue.h" #include "qemu/config-file.h" #include "sysemu/sysemu.h" diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index e852741..959a43c 100644 --- a/hw/usb/redirect.c +++ b/hw/usb/redirect.c @@ -27,7 +27,7 @@ #include "qemu-common.h" #include "qemu/timer.h" -#include "monitor/monitor.h" +#include "qemu/error-report.h" #include "sysemu/sysemu.h" #include "qemu/iov.h" #include "sysemu/char.h"