Message ID | 7a27998637b347c287b6a1c1394669e2769fa8e4.1710312598.git.mst@redhat.com |
---|---|
State | New |
Headers | show |
Series | qapi: document PCIe Gen5/Gen6 speeds since 9.0 | expand |
On 13/3/24 07:50, Michael S. Tsirkin wrote: > Document that PCIe Gen5/Gen6 speeds are only in QAPI > since 9.0 - the rest is since 4.0. > > Cc: Lukas Stockner <lstockner@genesiscloud.com> > Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com> > Fixes: c08da86dc4 ("pcie: Support PCIe Gen5/Gen6 link speeds") > Suggested-by: Markus Armbruster <armbru@redhat.com> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > --- > qapi/common.json | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
On 13/3/24 11:14, Philippe Mathieu-Daudé wrote: > On 13/3/24 07:50, Michael S. Tsirkin wrote: >> Document that PCIe Gen5/Gen6 speeds are only in QAPI >> since 9.0 - the rest is since 4.0. >> >> Cc: Lukas Stockner <lstockner@genesiscloud.com> >> Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com> >> Fixes: c08da86dc4 ("pcie: Support PCIe Gen5/Gen6 link speeds") (BTW if you have to repost your pullreq as v2, you could squash this change). >> Suggested-by: Markus Armbruster <armbru@redhat.com> >> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> >> --- >> qapi/common.json | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) > > Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> > >
On Wed, Mar 13, 2024 at 11:22:43AM +0100, Philippe Mathieu-Daudé wrote: > On 13/3/24 11:14, Philippe Mathieu-Daudé wrote: > > On 13/3/24 07:50, Michael S. Tsirkin wrote: > > > Document that PCIe Gen5/Gen6 speeds are only in QAPI > > > since 9.0 - the rest is since 4.0. > > > > > > Cc: Lukas Stockner <lstockner@genesiscloud.com> > > > Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com> > > > Fixes: c08da86dc4 ("pcie: Support PCIe Gen5/Gen6 link speeds") > > (BTW if you have to repost your pullreq as v2, you could > squash this change). Does not break bisect in any way, it's a comment so I do not see a reason to squash. > > > Suggested-by: Markus Armbruster <armbru@redhat.com> > > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > > > --- > > > qapi/common.json | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> > > > >
diff --git a/qapi/common.json b/qapi/common.json index 867a9ad9b0..7558ce5430 100644 --- a/qapi/common.json +++ b/qapi/common.json @@ -107,9 +107,9 @@ # # @16: 16.0GT/s # -# @32: 32.0GT/s +# @32: 32.0GT/s (since 9.0) # -# @64: 64.0GT/s +# @64: 64.0GT/s (since 9.0) # # Since: 4.0 ##
Document that PCIe Gen5/Gen6 speeds are only in QAPI since 9.0 - the rest is since 4.0. Cc: Lukas Stockner <lstockner@genesiscloud.com> Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com> Fixes: c08da86dc4 ("pcie: Support PCIe Gen5/Gen6 link speeds") Suggested-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- qapi/common.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)