| Message ID | 6d56c70c7895d6c66db250bd03744b9bd7a092eb.1425951373.git.chen.fan.fnst@cn.fujitsu.com |
|---|---|
| State | New |
| Headers | show |
10.03.2015 04:49, Chen Fan пишет: > Refer to "PCI Express Base Spec3.0", this comments can't > fit the description in spec, so we should fix them. > > Signed-off-by: Chen Fan <chen.fan.fnst@cn.fujitsu.com> > --- > hw/pci/pcie_aer.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/pci/pcie_aer.c b/hw/pci/pcie_aer.c > index 1f4be16..7ca077a 100644 > --- a/hw/pci/pcie_aer.c > +++ b/hw/pci/pcie_aer.c > @@ -618,11 +618,11 @@ static bool pcie_aer_inject_uncor_error(PCIEAERInject *inj, bool is_fatal) > * non-Function specific error must be recorded in all functions. > * It is the responsibility of the caller of this function. > * It is also caller's responsibility to determine which function should > - * report the rerror. > + * report the error. > * > * 6.2.4 Error Logging > - * 6.2.5 Sqeunce of Device Error Signaling and Logging Operations > - * table 6-2: Flowchard Showing Sequence of Device Error Signaling and Logging > + * 6.2.5 Sequence of Device Error Signaling and Logging Operations > + * table 6-2: Flowchart Showing Sequence of Device Error Signaling and Logging > * Operations this 6-2 is not a table, it is "Figure 6-2" on page 479, unless, ofcourse, you mean "Table 6-2: General PCI Express Error List" on page 481. I can fix this when applying. Thanks, /mjt > */ > int pcie_aer_inject_error(PCIDevice *dev, const PCIEAERErr *err) >
On Tue, Mar 10, 2015 at 09:34:58AM +0300, Michael Tokarev wrote: > 10.03.2015 04:49, Chen Fan пишет: > > Refer to "PCI Express Base Spec3.0", this comments can't > > fit the description in spec, so we should fix them. > > > > Signed-off-by: Chen Fan <chen.fan.fnst@cn.fujitsu.com> > > --- > > hw/pci/pcie_aer.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/hw/pci/pcie_aer.c b/hw/pci/pcie_aer.c > > index 1f4be16..7ca077a 100644 > > --- a/hw/pci/pcie_aer.c > > +++ b/hw/pci/pcie_aer.c > > @@ -618,11 +618,11 @@ static bool pcie_aer_inject_uncor_error(PCIEAERInject *inj, bool is_fatal) > > * non-Function specific error must be recorded in all functions. > > * It is the responsibility of the caller of this function. > > * It is also caller's responsibility to determine which function should > > - * report the rerror. > > + * report the error. > > * > > * 6.2.4 Error Logging > > - * 6.2.5 Sqeunce of Device Error Signaling and Logging Operations > > - * table 6-2: Flowchard Showing Sequence of Device Error Signaling and Logging > > + * 6.2.5 Sequence of Device Error Signaling and Logging Operations > > + * table 6-2: Flowchart Showing Sequence of Device Error Signaling and Logging > > * Operations > > this 6-2 is not a table, it is "Figure 6-2" on page 479, unless, ofcourse, you mean > "Table 6-2: General PCI Express Error List" on page 481. > > I can fix this when applying. > > Thanks, > > /mjt OK so you want to take all 3 patches? > > */ > > int pcie_aer_inject_error(PCIDevice *dev, const PCIEAERErr *err) > >
On Tue, Mar 10, 2015 at 09:49:48AM +0800, Chen Fan wrote: > Refer to "PCI Express Base Spec3.0", this comments can't > fit the description in spec, so we should fix them. > > Signed-off-by: Chen Fan <chen.fan.fnst@cn.fujitsu.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> > --- > hw/pci/pcie_aer.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/pci/pcie_aer.c b/hw/pci/pcie_aer.c > index 1f4be16..7ca077a 100644 > --- a/hw/pci/pcie_aer.c > +++ b/hw/pci/pcie_aer.c > @@ -618,11 +618,11 @@ static bool pcie_aer_inject_uncor_error(PCIEAERInject *inj, bool is_fatal) > * non-Function specific error must be recorded in all functions. > * It is the responsibility of the caller of this function. > * It is also caller's responsibility to determine which function should > - * report the rerror. > + * report the error. > * > * 6.2.4 Error Logging > - * 6.2.5 Sqeunce of Device Error Signaling and Logging Operations > - * table 6-2: Flowchard Showing Sequence of Device Error Signaling and Logging > + * 6.2.5 Sequence of Device Error Signaling and Logging Operations > + * table 6-2: Flowchart Showing Sequence of Device Error Signaling and Logging > * Operations > */ > int pcie_aer_inject_error(PCIDevice *dev, const PCIEAERErr *err) > -- > 1.9.3
On 03/10/2015 10:57 PM, Michael S. Tsirkin wrote: > On Tue, Mar 10, 2015 at 09:34:58AM +0300, Michael Tokarev wrote: >> 10.03.2015 04:49, Chen Fan пишет: >>> Refer to "PCI Express Base Spec3.0", this comments can't >>> fit the description in spec, so we should fix them. >>> >>> Signed-off-by: Chen Fan <chen.fan.fnst@cn.fujitsu.com> >>> --- >>> hw/pci/pcie_aer.c | 6 +++--- >>> 1 file changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/hw/pci/pcie_aer.c b/hw/pci/pcie_aer.c >>> index 1f4be16..7ca077a 100644 >>> --- a/hw/pci/pcie_aer.c >>> +++ b/hw/pci/pcie_aer.c >>> @@ -618,11 +618,11 @@ static bool pcie_aer_inject_uncor_error(PCIEAERInject *inj, bool is_fatal) >>> * non-Function specific error must be recorded in all functions. >>> * It is the responsibility of the caller of this function. >>> * It is also caller's responsibility to determine which function should >>> - * report the rerror. >>> + * report the error. >>> * >>> * 6.2.4 Error Logging >>> - * 6.2.5 Sqeunce of Device Error Signaling and Logging Operations >>> - * table 6-2: Flowchard Showing Sequence of Device Error Signaling and Logging >>> + * 6.2.5 Sequence of Device Error Signaling and Logging Operations >>> + * table 6-2: Flowchart Showing Sequence of Device Error Signaling and Logging >>> * Operations >> this 6-2 is not a table, it is "Figure 6-2" on page 479, unless, ofcourse, you mean >> "Table 6-2: General PCI Express Error List" on page 481. >> >> I can fix this when applying. >> >> Thanks, >> >> /mjt > OK so you want to take all 3 patches? Hi mjt, can you check in these patch? Thanks, Chen > > >>> */ >>> int pcie_aer_inject_error(PCIDevice *dev, const PCIEAERErr *err) >>> > . >
diff --git a/hw/pci/pcie_aer.c b/hw/pci/pcie_aer.c index 1f4be16..7ca077a 100644 --- a/hw/pci/pcie_aer.c +++ b/hw/pci/pcie_aer.c @@ -618,11 +618,11 @@ static bool pcie_aer_inject_uncor_error(PCIEAERInject *inj, bool is_fatal) * non-Function specific error must be recorded in all functions. * It is the responsibility of the caller of this function. * It is also caller's responsibility to determine which function should - * report the rerror. + * report the error. * * 6.2.4 Error Logging - * 6.2.5 Sqeunce of Device Error Signaling and Logging Operations - * table 6-2: Flowchard Showing Sequence of Device Error Signaling and Logging + * 6.2.5 Sequence of Device Error Signaling and Logging Operations + * table 6-2: Flowchart Showing Sequence of Device Error Signaling and Logging * Operations */ int pcie_aer_inject_error(PCIDevice *dev, const PCIEAERErr *err)
Refer to "PCI Express Base Spec3.0", this comments can't fit the description in spec, so we should fix them. Signed-off-by: Chen Fan <chen.fan.fnst@cn.fujitsu.com> --- hw/pci/pcie_aer.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)