| Message ID | 5761e5b785437713ac9bf237fcc5f63e9749e9e0.1433052532.git.crosthwaite.peter@gmail.com |
|---|---|
| State | New |
| Headers | show |
On 31/05/2015 08:11, Peter Crosthwaite wrote: > Not dealing with this issue as of this RFC. Comments welcome on how to > handle it. It is probably a case that any form of CPU selection is ill > defined in multi-arch. So just a case of #ifndef TARGET_MULTI or > something like that? That, or handle it like tcg_exec_init? Paolo > Signed-off-by: Peter Crosthwaite <crosthwaite.peter@gmail.com> > --- > cpus.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/cpus.c b/cpus.c > index 2dc4a9a..441a026 100644 > --- a/cpus.c > +++ b/cpus.c > @@ -1446,9 +1446,11 @@ void cpu_loop_exit(CPUState *cpu) > void list_cpus(FILE *f, fprintf_function cpu_fprintf, const char *optarg) > { > /* XXX: implement xxx_cpu_list for targets that still miss it */ > +#if 0 > #if defined(cpu_list) > cpu_list(f, cpu_fprintf); > #endif > +#endif > } > > CpuInfoList *qmp_query_cpus(Error **errp) >
diff --git a/cpus.c b/cpus.c index 2dc4a9a..441a026 100644 --- a/cpus.c +++ b/cpus.c @@ -1446,9 +1446,11 @@ void cpu_loop_exit(CPUState *cpu) void list_cpus(FILE *f, fprintf_function cpu_fprintf, const char *optarg) { /* XXX: implement xxx_cpu_list for targets that still miss it */ +#if 0 #if defined(cpu_list) cpu_list(f, cpu_fprintf); #endif +#endif } CpuInfoList *qmp_query_cpus(Error **errp)
Not dealing with this issue as of this RFC. Comments welcome on how to handle it. It is probably a case that any form of CPU selection is ill defined in multi-arch. So just a case of #ifndef TARGET_MULTI or something like that? Signed-off-by: Peter Crosthwaite <crosthwaite.peter@gmail.com> --- cpus.c | 2 ++ 1 file changed, 2 insertions(+)