From patchwork Mon Oct 20 20:10:27 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Don Slutz X-Patchwork-Id: 401245 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 00F22140080 for ; Tue, 21 Oct 2014 07:11:06 +1100 (AEDT) Received: from localhost ([::1]:46647 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XgJIE-000852-Ba for incoming@patchwork.ozlabs.org; Mon, 20 Oct 2014 16:11:02 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35257) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XgJHp-0007la-Jv for qemu-devel@nongnu.org; Mon, 20 Oct 2014 16:10:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XgJHk-0000Fr-TG for qemu-devel@nongnu.org; Mon, 20 Oct 2014 16:10:37 -0400 Received: from fldsmtpe04.verizon.com ([140.108.26.143]:22182) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XgJHk-0000Ey-CQ for qemu-devel@nongnu.org; Mon, 20 Oct 2014 16:10:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=verizon.com; i=dslutz@verizon.com; q=dns/txt; s=corp; t=1413835832; x=1445371832; h=from:message-id:date:mime-version:to:cc:subject: references:in-reply-to; bh=n/wmDc0ybj+DvcyVvtfikzYfqiVUbW4CHClPdBPR9Pc=; b=Q6On2tqanJqqwKnwvQviQvhXxwMWc3GAxcOm9Aqx4oNzcyYZxQsuprAz cp81Pbdr3XAOJaDPP+EgoEKLqUXvqoUTPMiiNYBtPVPBkVWTlR5Md0JcO sbizT2nArerxIGWYncoeg4KOy6LzshiPq0Cf6dfC6Bdb7yk/999MXM7mb I=; X-IronPort-Anti-Spam-Filtered: false Received: from unknown (HELO fldsmtpi01.verizon.com) ([166.68.71.143]) by fldsmtpe04.verizon.com with ESMTP; 20 Oct 2014 20:10:31 +0000 From: Don Slutz X-VzAPP: 1 X-IronPort-AV: E=Sophos;i="5.04,757,1406592000"; d="scan'208,223";a="883719054" Received: from unknown (HELO don-760.CloudSwitch.com) ([162.47.3.32]) by fldsmtpi01.verizon.com with ESMTP; 20 Oct 2014 20:10:27 +0000 Message-ID: <54456C33.3000604@terremark.com> Date: Mon, 20 Oct 2014 16:10:27 -0400 User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: "Michael S. Tsirkin" , Peter Maydell References: <1413796790-30579-1-git-send-email-armbru@redhat.com> <20141020141548.GA11062@redhat.com> <20141020190358.GA12441@redhat.com> In-Reply-To: <20141020190358.GA12441@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 140.108.26.143 Cc: Markus Armbruster , QEMU Developers Subject: Re: [Qemu-devel] [PATCH] get_maintainer.pl: Default to --no-git-fallback X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On 10/20/14 15:03, Michael S. Tsirkin wrote: > On Mon, Oct 20, 2014 at 03:19:52PM +0100, Peter Maydell wrote: >> On 20 October 2014 15:15, Michael S. Tsirkin wrote: >>> On Mon, Oct 20, 2014 at 03:04:44PM +0100, Peter Maydell wrote: >>>> On 20 October 2014 10:19, Markus Armbruster wrote: >>>>> Contributors rely on this script to find maintainers to copy. The >>>>> script falls back to git when no exact MAINTAINERS pattern matches. >>>>> When that happens, recent contributors get copied, which tends not be >>>>> particularly useful. Some contributors find it even annoying. >>>>> >>>>> Flip the default to "don't fall back to git". Use --git-fallback to >>>>> ask it to fall back to git. >>>> Good idea. >>> What do you want to happen in this case? >> It should mail the people who are actually maintainers, >> not anybody who happened to touch the code in the last >> year. > Right but as often as not there's no data about that > in MAINTAINERS. > > >>> I'm yet to see contributors who are annoyed but we >>> can always blacklist specific people. >> At the moment I just don't use get_maintainers.pl at >> all because I tried it a few times and it just cc'd >> a bunch of irrelevant people... >> >> I suspect anybody using it at the moment is either >> using the --no-git-fallback flag or trimming the >> cc list a lot. >> >> thanks >> -- PMM > I'm using it: sometimes with --no-git-fallback, sometimes without. > > IIUC the default is to have up to 5 people on the Cc list > (--git-max-maintainers). > It's not like it adds 200 random people, is it? > > Anyway experienced contributors can figure it out IMHO. > > > Question in my mind is what do we want a casual contributor > to do if there's no one listed in MAINTAINERS. > "Look in MAINTAINERS, if not there, look in git log" > sounds very reasonable to me, better than "CC no one". > Here is a possible patch (based on a xen change). It adds the special supporter:THE REST Which is listed at the end of MAINTAINERS. I included a quick guess... -Don Slutz From 82bd0d1dcfc5d17d1b72e12b2da3c9bb51e09a48 Mon Sep 17 00:00:00 2001 From: Don Slutz Date: Mon, 20 Oct 2014 16:06:35 -0400 Subject: [PATCH] get_maintainer.pl: Add 'THE REST' Signed-off-by: Don Slutz --- MAINTAINERS | 8 ++++++++ scripts/get_maintainer.pl | 15 +++++++++++++++ 2 files changed, 23 insertions(+) 'l!' => \$email_list, @@ -647,6 +649,19 @@ sub get_maintainers { } } + if ($email_drop_the_rest_supporter_if_supporter_found && $#email_to > 0) { + my @email_new; + my $do_replace = 0; + foreach my $email (@email_to) { + if ($email->[1] ne 'supporter:THE REST') { + $do_replace = 1; + push @email_new, $email; + } + } + @email_to = @email_new + if $do_replace; + } + foreach my $email (@email_to, @list_to) { $email->[0] = deduplicate_email($email->[0]); } From 82bd0d1dcfc5d17d1b72e12b2da3c9bb51e09a48 Mon Sep 17 00:00:00 2001 From: Don Slutz Date: Mon, 20 Oct 2014 16:06:35 -0400 Subject: [PATCH] get_maintainer.pl: Add 'THE REST' Signed-off-by: Don Slutz --- MAINTAINERS | 8 ++++++++ scripts/get_maintainer.pl | 15 +++++++++++++++ 2 files changed, 23 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 206bf7e..527227a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1018,3 +1018,11 @@ M: Chrysostomos Nanakos M: Chrysostomos Nanakos S: Maintained F: block/archipelago.c + +THE REST +M: Michael S. Tsirkin +M: Peter Maydell +L: qemu-devel@nongnu.org +S: Supported +F: * +F: */ diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index 38334de..eef16ee 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -37,6 +37,7 @@ my $email_hg_since = "-365"; my $interactive = 0; my $email_remove_duplicates = 1; my $email_use_mailmap = 1; +my $email_drop_the_rest_supporter_if_supporter_found = 1; my $output_multiline = 1; my $output_separator = ", "; my $output_roles = 0; @@ -196,6 +197,7 @@ if (!GetOptions( 'i|interactive!' => \$interactive, 'remove-duplicates!' => \$email_remove_duplicates, 'mailmap!' => \$email_use_mailmap, + 'drop_the_rest_supporter!' => \$email_drop_the_rest_supporter_if_supporter_found, 'm!' => \$email_maintainer, 'n!' => \$email_usename, 'l!' => \$email_list, @@ -647,6 +649,19 @@ sub get_maintainers { } } + if ($email_drop_the_rest_supporter_if_supporter_found && $#email_to > 0) { + my @email_new; + my $do_replace = 0; + foreach my $email (@email_to) { + if ($email->[1] ne 'supporter:THE REST') { + $do_replace = 1; + push @email_new, $email; + } + } + @email_to = @email_new + if $do_replace; + } + foreach my $email (@email_to, @list_to) { $email->[0] = deduplicate_email($email->[0]); } -- 1.8.4