diff mbox

apic: Fix reported DFR content

Message ID 53E62ABF.2000104@web.de
State New
Headers show

Commit Message

Jan Kiszka Aug. 9, 2014, 2:05 p.m. UTC 
From: Jan Kiszka <jan.kiszka@siemens.com>

IA-32 SDM, Figure 10-14: Bits 27:0 are reserved as 1.

Fixes Jailhouse hypervisor start with in-kernel irqchips off.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 hw/intc/apic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michael Tokarev Aug. 13, 2014, 6:14 a.m. UTC | #1 
09.08.2014 18:05, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> IA-32 SDM, Figure 10-14: Bits 27:0 are reserved as 1.
> 
> Fixes Jailhouse hypervisor start with in-kernel irqchips off.

Applied to -trivial, thank you!

Are the other similar cases in there okay?
Say, 0x0d or 0x02 which also uses shifts like this one?

/mjt
Jan Kiszka Aug. 13, 2014, 7:09 a.m. UTC | #2 
On 2014-08-13 08:14, Michael Tokarev wrote:
> 09.08.2014 18:05, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> IA-32 SDM, Figure 10-14: Bits 27:0 are reserved as 1.
>>
>> Fixes Jailhouse hypervisor start with in-kernel irqchips off.
> 
> Applied to -trivial, thank you!
> 
> Are the other similar cases in there okay?
> Say, 0x0d or 0x02 which also uses shifts like this one?

Nope, didn't find any.

Jan
diff mbox

Patch

diff --git a/hw/intc/apic.c b/hw/intc/apic.c
index ef19e55..03ff9e9 100644
--- a/hw/intc/apic.c
+++ b/hw/intc/apic.c
@@ -698,7 +698,7 @@  static uint32_t apic_mem_readl(void *opaque, hwaddr addr)
         val = s->log_dest << 24;
         break;
     case 0x0e:
-        val = s->dest_mode << 28;
+        val = (s->dest_mode << 28) | 0xfffffff;
         break;
     case 0x0f:
         val = s->spurious_vec;