From patchwork Fri Feb 14 04:03:15 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alexey Kardashevskiy X-Patchwork-Id: 320283 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id BAF572C00B3 for ; Fri, 14 Feb 2014 15:04:00 +1100 (EST) Received: from localhost ([::1]:49714 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WEA0L-0003RH-13 for incoming@patchwork.ozlabs.org; Thu, 13 Feb 2014 23:03:57 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60728) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WE9zz-0003OQ-1V for qemu-devel@nongnu.org; Thu, 13 Feb 2014 23:03:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WE9zq-0008U7-Rh for qemu-devel@nongnu.org; Thu, 13 Feb 2014 23:03:34 -0500 Received: from mail-pd0-f180.google.com ([209.85.192.180]:54428) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WE9zq-0008Tl-Ld for qemu-devel@nongnu.org; Thu, 13 Feb 2014 23:03:26 -0500 Received: by mail-pd0-f180.google.com with SMTP id x10so11435535pdj.39 for ; Thu, 13 Feb 2014 20:03:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=LrRhrnDCQpcb/I58anY9FQRYBBK5mQfwLDUpDrTySSU=; b=GyKIsJft879n/PKghOTFqXI84kxophtfSCoBFnAn8N24Nhq3c/xvm+yEpVlb2/rSR7 R5jbRQRWxa5IlRDm5/6ELYiv7s4dYH7aUaLb8aHyIRyEYp2PCD96marjCibZIBwUYKlD ASkqtw4UC8Agdx296jQJqhyNOUdm4apSNIyr3rR/892b1simZbkpGgI+0OXMB6KzCDyP Vj7L+mFyxBUWq+sAJzSPI9nFKeIUwojJPRcx8QznUmSPNjvk3UBORryLLZtYiKyKVbP2 RSh02zCzMiwn3VMK8l6skaM98Do5tyRdHzWxkEnEo/g8fBFM9Kp4D+AY33Qq8oP/3gw3 dD+A== X-Gm-Message-State: ALoCoQnfXHMqjSsZjW70Ve6RibaA5g/Qi0zvWvOhlfJ5fj6AlFeNSqlPIbzNXNkLR8TtEQ1GSWwj X-Received: by 10.66.139.196 with SMTP id ra4mr6206737pab.103.1392350605225; Thu, 13 Feb 2014 20:03:25 -0800 (PST) Received: from aik.ozlabs.ibm.com (ibmaus65.lnk.telstra.net. [165.228.126.9]) by mx.google.com with ESMTPSA id nz11sm30041241pab.6.2014.02.13.20.03.19 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 13 Feb 2014 20:03:24 -0800 (PST) Message-ID: <52FD9583.6080005@ozlabs.ru> Date: Fri, 14 Feb 2014 15:03:15 +1100 From: Alexey Kardashevskiy User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , qemu-devel@nongnu.org, Peter Maydell References: <1391947053-26753-1-git-send-email-afaerber@suse.de> <1392004376-17016-1-git-send-email-aik@ozlabs.ru> <1392004376-17016-2-git-send-email-aik@ozlabs.ru> <52F93745.8090703@suse.de> In-Reply-To: <52F93745.8090703@suse.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.192.180 Cc: qemu-ppc@nongnu.org, Alexander Graf Subject: Re: [Qemu-devel] [PATCH 1/2] tests-ppc64: add to cleanup rule X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On 02/11/2014 07:32 AM, Andreas Färber wrote: > Am 10.02.2014 04:52, schrieb Alexey Kardashevskiy: >> This adds $(check-qtest-ppc64-y) to the check-clean rule. >> >> Signed-off-by: Alexey Kardashevskiy > > Nice catch! > >> --- >> tests/Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tests/Makefile b/tests/Makefile >> index 0aaf657..3a00ea7 100644 >> --- a/tests/Makefile >> +++ b/tests/Makefile >> @@ -319,7 +319,7 @@ check-block: $(patsubst %,check-%, $(check-block-y)) >> check: check-qapi-schema check-unit check-qtest >> check-clean: >> $(MAKE) -C tests/tcg clean >> - rm -rf $(check-unit-y) $(check-qtest-i386-y) $(check-qtest-x86_64-y) $(check-qtest-sparc64-y) $(check-qtest-sparc-y) tests/*.o $(QEMU_IOTESTS_HELPERS-y) >> + rm -rf $(check-unit-y) $(check-qtest-i386-y) $(check-qtest-x86_64-y) $(check-qtest-sparc64-y) $(check-qtest-sparc-y) $(check-qtest-ppc64-y) tests/*.o $(QEMU_IOTESTS_HELPERS-y) >> >> clean: check-clean >> > > Can we use a $(foreach ...) for $(check-qtest-*-y) like Peter did for > adding qom-test? > > http://patchwork.ozlabs.org/patch/313650/ Like this? Against what should I rebase my patches and repost them? clean: check-clean diff --git a/tests/Makefile b/tests/Makefile index 94b32b7..2577843 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -323,7 +323,9 @@ check-block: $(patsubst %,check-%, $(check-block-y)) check: check-qapi-schema check-unit check-qtest check-clean: $(MAKE) -C tests/tcg clean - rm -rf $(check-unit-y) $(check-qtest-i386-y) $(check-qtest-x86_64-y) $(check-qtest-sparc64-y) $(check-qtest-sparc-y) t + $(eval rmlist = $(check-unit-y) tests/*.o $(QEMU_IOTESTS_HELPERS-y)) + $(foreach target,$(SYSEMU_TARGET_LIST), $(eval rmlist += $(check-qtest-$(target)-y))) + rm -rf $(rmlist)