Message ID | 50c1c6a3ace8b40f7b9d5395a2c3457cf1852721.1564080680.git.alistair.francis@wdc.com |
---|---|
State | New |
Headers | show |
Series | RISC-V: Hypervisor prep work part 2 | expand |
Reviewed-by: Jonathan Behrens <fintelia@gmail.com> On Thu, Jul 25, 2019 at 2:56 PM Alistair Francis <alistair.francis@wdc.com> wrote: > Signed-off-by: Alistair Francis <alistair.francis@wdc.com> > --- > hw/riscv/sifive_plic.c | 12 ------------ > include/hw/riscv/sifive_plic.h | 3 --- > 2 files changed, 15 deletions(-) > > diff --git a/hw/riscv/sifive_plic.c b/hw/riscv/sifive_plic.c > index 0950e89e15..864a1bed42 100644 > --- a/hw/riscv/sifive_plic.c > +++ b/hw/riscv/sifive_plic.c > @@ -161,18 +161,6 @@ static void sifive_plic_update(SiFivePLICState *plic) > } > } > > -void sifive_plic_raise_irq(SiFivePLICState *plic, uint32_t irq) > -{ > - sifive_plic_set_pending(plic, irq, true); > - sifive_plic_update(plic); > -} > - > -void sifive_plic_lower_irq(SiFivePLICState *plic, uint32_t irq) > -{ > - sifive_plic_set_pending(plic, irq, false); > - sifive_plic_update(plic); > -} > - > static uint32_t sifive_plic_claim(SiFivePLICState *plic, uint32_t addrid) > { > int i, j; > diff --git a/include/hw/riscv/sifive_plic.h > b/include/hw/riscv/sifive_plic.h > index ce8907f6aa..3b8a623919 100644 > --- a/include/hw/riscv/sifive_plic.h > +++ b/include/hw/riscv/sifive_plic.h > @@ -69,9 +69,6 @@ typedef struct SiFivePLICState { > uint32_t aperture_size; > } SiFivePLICState; > > -void sifive_plic_raise_irq(SiFivePLICState *plic, uint32_t irq); > -void sifive_plic_lower_irq(SiFivePLICState *plic, uint32_t irq); > - > DeviceState *sifive_plic_create(hwaddr addr, char *hart_config, > uint32_t num_sources, uint32_t num_priorities, > uint32_t priority_base, uint32_t pending_base, > -- > 2.22.0 > > >
On 7/25/19 8:52 PM, Alistair Francis wrote: > Signed-off-by: Alistair Francis <alistair.francis@wdc.com> > --- > hw/riscv/sifive_plic.c | 12 ------------ > include/hw/riscv/sifive_plic.h | 3 --- > 2 files changed, 15 deletions(-) > > diff --git a/hw/riscv/sifive_plic.c b/hw/riscv/sifive_plic.c > index 0950e89e15..864a1bed42 100644 > --- a/hw/riscv/sifive_plic.c > +++ b/hw/riscv/sifive_plic.c > @@ -161,18 +161,6 @@ static void sifive_plic_update(SiFivePLICState *plic) > } > } > > -void sifive_plic_raise_irq(SiFivePLICState *plic, uint32_t irq) > -{ > - sifive_plic_set_pending(plic, irq, true); > - sifive_plic_update(plic); > -} > - > -void sifive_plic_lower_irq(SiFivePLICState *plic, uint32_t irq) > -{ > - sifive_plic_set_pending(plic, irq, false); > - sifive_plic_update(plic); > -} > - > static uint32_t sifive_plic_claim(SiFivePLICState *plic, uint32_t addrid) > { > int i, j; > diff --git a/include/hw/riscv/sifive_plic.h b/include/hw/riscv/sifive_plic.h > index ce8907f6aa..3b8a623919 100644 > --- a/include/hw/riscv/sifive_plic.h > +++ b/include/hw/riscv/sifive_plic.h > @@ -69,9 +69,6 @@ typedef struct SiFivePLICState { > uint32_t aperture_size; > } SiFivePLICState; > > -void sifive_plic_raise_irq(SiFivePLICState *plic, uint32_t irq); > -void sifive_plic_lower_irq(SiFivePLICState *plic, uint32_t irq); > - > DeviceState *sifive_plic_create(hwaddr addr, char *hart_config, > uint32_t num_sources, uint32_t num_priorities, > uint32_t priority_base, uint32_t pending_base, > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
On Fri, Jul 26, 2019 at 2:55 AM Alistair Francis <alistair.francis@wdc.com> wrote: > Signed-off-by: Alistair Francis <alistair.francis@wdc.com> > --- > hw/riscv/sifive_plic.c | 12 ------------ > include/hw/riscv/sifive_plic.h | 3 --- > 2 files changed, 15 deletions(-) > > diff --git a/hw/riscv/sifive_plic.c b/hw/riscv/sifive_plic.c > index 0950e89e15..864a1bed42 100644 > --- a/hw/riscv/sifive_plic.c > +++ b/hw/riscv/sifive_plic.c > @@ -161,18 +161,6 @@ static void sifive_plic_update(SiFivePLICState *plic) > } > } > > -void sifive_plic_raise_irq(SiFivePLICState *plic, uint32_t irq) > -{ > - sifive_plic_set_pending(plic, irq, true); > - sifive_plic_update(plic); > -} > - > -void sifive_plic_lower_irq(SiFivePLICState *plic, uint32_t irq) > -{ > - sifive_plic_set_pending(plic, irq, false); > - sifive_plic_update(plic); > -} > - > static uint32_t sifive_plic_claim(SiFivePLICState *plic, uint32_t addrid) > { > int i, j; > diff --git a/include/hw/riscv/sifive_plic.h > b/include/hw/riscv/sifive_plic.h > index ce8907f6aa..3b8a623919 100644 > --- a/include/hw/riscv/sifive_plic.h > +++ b/include/hw/riscv/sifive_plic.h > @@ -69,9 +69,6 @@ typedef struct SiFivePLICState { > uint32_t aperture_size; > } SiFivePLICState; > > -void sifive_plic_raise_irq(SiFivePLICState *plic, uint32_t irq); > -void sifive_plic_lower_irq(SiFivePLICState *plic, uint32_t irq); > - > DeviceState *sifive_plic_create(hwaddr addr, char *hart_config, > uint32_t num_sources, uint32_t num_priorities, > uint32_t priority_base, uint32_t pending_base, > -- > 2.22.0 > > Reviewed-by: Chih-Min Chao <chihmin.chao@sifive.com>
diff --git a/hw/riscv/sifive_plic.c b/hw/riscv/sifive_plic.c index 0950e89e15..864a1bed42 100644 --- a/hw/riscv/sifive_plic.c +++ b/hw/riscv/sifive_plic.c @@ -161,18 +161,6 @@ static void sifive_plic_update(SiFivePLICState *plic) } } -void sifive_plic_raise_irq(SiFivePLICState *plic, uint32_t irq) -{ - sifive_plic_set_pending(plic, irq, true); - sifive_plic_update(plic); -} - -void sifive_plic_lower_irq(SiFivePLICState *plic, uint32_t irq) -{ - sifive_plic_set_pending(plic, irq, false); - sifive_plic_update(plic); -} - static uint32_t sifive_plic_claim(SiFivePLICState *plic, uint32_t addrid) { int i, j; diff --git a/include/hw/riscv/sifive_plic.h b/include/hw/riscv/sifive_plic.h index ce8907f6aa..3b8a623919 100644 --- a/include/hw/riscv/sifive_plic.h +++ b/include/hw/riscv/sifive_plic.h @@ -69,9 +69,6 @@ typedef struct SiFivePLICState { uint32_t aperture_size; } SiFivePLICState; -void sifive_plic_raise_irq(SiFivePLICState *plic, uint32_t irq); -void sifive_plic_lower_irq(SiFivePLICState *plic, uint32_t irq); - DeviceState *sifive_plic_create(hwaddr addr, char *hart_config, uint32_t num_sources, uint32_t num_priorities, uint32_t priority_base, uint32_t pending_base,
Signed-off-by: Alistair Francis <alistair.francis@wdc.com> --- hw/riscv/sifive_plic.c | 12 ------------ include/hw/riscv/sifive_plic.h | 3 --- 2 files changed, 15 deletions(-)