From patchwork Wed Aug 22 12:01:33 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 179309 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 9B27D2C0096 for ; Wed, 22 Aug 2012 22:01:49 +1000 (EST) Received: from localhost ([::1]:34633 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T49d5-00072k-M9 for incoming@patchwork.ozlabs.org; Wed, 22 Aug 2012 08:01:47 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46321) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T49cv-00072Z-Ti for qemu-devel@nongnu.org; Wed, 22 Aug 2012 08:01:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T49cu-0006Ac-Qo for qemu-devel@nongnu.org; Wed, 22 Aug 2012 08:01:37 -0400 Received: from mail-ee0-f45.google.com ([74.125.83.45]:47150) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T49cu-0006AR-KL for qemu-devel@nongnu.org; Wed, 22 Aug 2012 08:01:36 -0400 Received: by eeke53 with SMTP id e53so291885eek.4 for ; Wed, 22 Aug 2012 05:01:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=sudHyy2RBROcu+Y1TgNC7l0kSekY61TUyD9mGtdd+i4=; b=twRDJEi7nZNoC6Uo4JzyzWJyCJyWOwIuE3Xy9Z48D/FgYcgPVI2chzlvMfWnId3nQY xajIyUa8WzyYrHzBoR4co4RgOGaXer5POaSFjZWm+ioKd70cwdA+GgBHhLicftHV+E8/ amoF1KSH6XC4DFdz2E2xqpvLfCF3BI80SH0VTqiAMHzLMEWlV3cKYHQb46S4hkYibFG1 lwrqX4oQNyIWbmV7X0iMPl2uwbD4AGL9UGuOk3JGAq8kGwhyLrkprleaZHbpAuydwGIX C3CGrWOjkBtnGb4dgNOR/k+CztLRQ4ByfqNMgtrRu6SCPeWw5rgBGHVzkh62Fpcgst+w wYSA== Received: by 10.14.225.200 with SMTP id z48mr17862010eep.39.1345636895652; Wed, 22 Aug 2012 05:01:35 -0700 (PDT) Received: from yakj.usersys.redhat.com (nat-pool-mxp-t.redhat.com. [209.132.186.18]) by mx.google.com with ESMTPS id 9sm12335352eei.12.2012.08.22.05.01.33 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 22 Aug 2012 05:01:34 -0700 (PDT) Message-ID: <5034CA1D.80101@redhat.com> Date: Wed, 22 Aug 2012 14:01:33 +0200 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 MIME-Version: 1.0 To: Cam Macdonell References: In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 74.125.83.45 Cc: Avi Kivity , "qemu-devel@nongnu.org Developers" Subject: Re: [Qemu-devel] ivshmem assertion failure with EventNotifier X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Il 22/08/2012 06:29, Cam Macdonell ha scritto: > Hi Paolo, > > I've noticed an assertion error when sending interrupts via ivshmem. > I bisected to this patch. Does this help? memory_region_transaction_begin(); Paolo diff --git a/hw/ivshmem.c b/hw/ivshmem.c index b4d65a6..47f2a16 100644 --- a/hw/ivshmem.c +++ b/hw/ivshmem.c @@ -366,6 +366,10 @@ static void close_guest_eventfds(IVShmemState *s, int posn) { int i, guest_curr_max; + if (!ivshmem_has_feature(s, IVSHMEM_IOEVENTFD)) { + return; + } + guest_curr_max = s->peers[posn].nb_eventfds;