From patchwork Thu Aug 15 22:18:09 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: BALATON Zoltan X-Patchwork-Id: 1147874 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=eik.bme.hu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 468h5l0Kq5z9sN6 for ; Fri, 16 Aug 2019 08:32:09 +1000 (AEST) Received: from localhost ([::1]:47670 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyOHt-00036J-HY for incoming@patchwork.ozlabs.org; Thu, 15 Aug 2019 18:32:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38086) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyOH9-00034b-Ij for qemu-devel@nongnu.org; Thu, 15 Aug 2019 18:31:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hyOH7-0006LQ-Uw for qemu-devel@nongnu.org; Thu, 15 Aug 2019 18:31:18 -0400 Received: from zero.eik.bme.hu ([152.66.115.2]:47230) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hyOH7-0006KS-Ou for qemu-devel@nongnu.org; Thu, 15 Aug 2019 18:31:17 -0400 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id 9A6F874B821; Fri, 16 Aug 2019 00:31:14 +0200 (CEST) Received: by zero.eik.bme.hu (Postfix, from userid 432) id 117D974AAAC; Fri, 16 Aug 2019 00:31:14 +0200 (CEST) Message-Id: <489ce252f9d5f902f7d240ff9895e77bb335f1a9.1565907489.git.balaton@eik.bme.hu> In-Reply-To: References: From: BALATON Zoltan Date: Fri, 16 Aug 2019 00:18:09 +0200 MIME-Version: 1.0 To: qemu-devel@nongnu.org X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 152.66.115.2 Subject: [Qemu-devel] [PATCH 3/3] ati-vga: Silence some noisy traces X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Hoffmann Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Some registers are accessed very frequently so exclude these from traces to avoid flooding output with a lot of trace logs when traces are enabled thus helping debugging. Signed-off-by: BALATON Zoltan --- hw/display/ati.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/hw/display/ati.c b/hw/display/ati.c index 5e2c4ba4aa..36d2a75f71 100644 --- a/hw/display/ati.c +++ b/hw/display/ati.c @@ -489,7 +489,14 @@ static uint64_t ati_mm_read(void *opaque, hwaddr addr, unsigned int size) default: break; } - if (addr < CUR_OFFSET || addr > CUR_CLR1 || ATI_DEBUG_HW_CURSOR) { + if ((addr < CUR_OFFSET || addr > CUR_CLR1 + 3 || (ATI_DEBUG_HW_CURSOR && + (addr >= CUR_OFFSET && addr <= CUR_CLR1 + 3))) && + (addr < GEN_INT_CNTL || addr > GEN_INT_STATUS + 3) && + (addr < GPIO_MONID || addr > GPIO_MONID + 3) && + (addr < AMCGPIO_MASK_MIR || addr > AMCGPIO_EN_MIR + 3) && + (addr < 0x908 || addr > 0x90f) && (addr < 0xc4c || addr > 0xc53) && + addr != RBBM_STATUS && addr != 0x1714 && + addr != 0x7b8 && addr > MM_DATA + 3) { trace_ati_mm_read(size, addr, ati_reg_name(addr & ~3ULL), val); } return val; @@ -511,7 +518,14 @@ static void ati_mm_write(void *opaque, hwaddr addr, { ATIVGAState *s = opaque; - if (addr < CUR_OFFSET || addr > CUR_CLR1 || ATI_DEBUG_HW_CURSOR) { + if ((((addr < CUR_OFFSET || addr > CUR_CLR1 + 3) && + addr != CRTC_GEN_CNTL + 2) || (ATI_DEBUG_HW_CURSOR && + addr >= CUR_OFFSET && addr <= CUR_CLR1 + 3)) && + (addr < GEN_INT_CNTL || addr > GEN_INT_STATUS + 3) && + (addr < GPIO_MONID || addr > GPIO_MONID + 3) && + (addr < AMCGPIO_MASK_MIR || addr > AMCGPIO_EN_MIR + 3) && + (addr < 0x908 || addr > 0x90f) && (addr < 0xc4c || addr > 0xc53) && + addr != 0x1714 && addr > MM_DATA + 3) { trace_ati_mm_write(size, addr, ati_reg_name(addr & ~3ULL), data); } switch (addr) {