From patchwork Mon Jun 25 07:00:58 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 166980 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 0E1B0B6FAA for ; Mon, 25 Jun 2012 17:38:00 +1000 (EST) Received: from localhost ([::1]:43089 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sj3Iy-0001Yt-VD for incoming@patchwork.ozlabs.org; Mon, 25 Jun 2012 03:01:48 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59140) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sj3IY-0001A4-1h for qemu-devel@nongnu.org; Mon, 25 Jun 2012 03:01:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sj3IQ-0000cN-QP for qemu-devel@nongnu.org; Mon, 25 Jun 2012 03:01:21 -0400 Received: from david.siemens.de ([192.35.17.14]:27003) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sj3IQ-0000bk-Gd for qemu-devel@nongnu.org; Mon, 25 Jun 2012 03:01:14 -0400 Received: from mail1.siemens.de (localhost [127.0.0.1]) by david.siemens.de (8.13.6/8.13.6) with ESMTP id q5P716YK002638; Mon, 25 Jun 2012 09:01:06 +0200 Received: from mchn199C.mchp.siemens.de ([139.22.34.212]) by mail1.siemens.de (8.13.6/8.13.6) with SMTP id q5P7135r001108; Mon, 25 Jun 2012 09:01:05 +0200 From: Jan Kiszka To: Anthony Liguori , qemu-devel Date: Mon, 25 Jun 2012 09:00:58 +0200 Message-Id: <465acfdb7cbf31f5358bd053ef4360c521ea698f.1340607659.git.jan.kiszka@siemens.com> X-Mailer: git-send-email 1.7.3.4 In-Reply-To: References: In-Reply-To: References: MIME-Version: 1.0 X-MIME-Autoconverted: from 8bit to quoted-printable by david.siemens.de id q5P716YK002638 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Received-From: 192.35.17.14 Cc: Liu Ping Fan , kvm , Marcelo Tosatti , =?UTF-8?q?Andreas=20F=C3=A4rber?= , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Avi Kivity Subject: [Qemu-devel] [PATCH 1/5] i82378: Remove bogus MMIO coalescing X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This MMIO area is an entry gate to legacy PC ISA devices, addressed via PIO over there. Quite a few of the PIO ports have side effects on access like starting/stopping timers that must be executed properly ordered /wrt the CPU. So we have to remove the coalescing mark. CC: Andreas Färber CC: Hervé Poussineau Signed-off-by: Jan Kiszka --- hw/i82378.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/i82378.c b/hw/i82378.c index 9b11d90..2123c14 100644 --- a/hw/i82378.c +++ b/hw/i82378.c @@ -225,7 +225,6 @@ static int pci_i82378_init(PCIDevice *dev) pci_register_bar(dev, 0, PCI_BASE_ADDRESS_SPACE_MEMORY, &s->io); memory_region_init_io(&s->mem, &i82378_mem_ops, s, "i82378-mem", 0x01000000); - memory_region_set_coalescing(&s->mem); pci_register_bar(dev, 1, PCI_BASE_ADDRESS_SPACE_MEMORY, &s->mem); /* Make I/O address read only */