diff mbox

target-i386/fpu_helper.c: fbld instruction doesn't set minus sign

Message ID 3089981406285317@web29g.yandex.ru
State New
Headers show

Commit Message

Dmitry Poletaev July 25, 2014, 10:48 a.m. UTC 
Obviously, there is a misprint in function implementation.

From: Dmitry Poletaev <poletaev-qemu@yandex.ru>
Signed-off-by: Dmitry Poletaev <poletaev-qemu@yandex.ru>

---
 target-i386/fpu_helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Dmitry Poletaev Nov. 11, 2014, 12:33 p.m. UTC | #1 
ping

25.07.2014, 15:48, "Dmitry Poletaev" <poletaev-qemu@yandex.ru>:
> Obviously, there is a misprint in function implementation.
>
> From: Dmitry Poletaev <poletaev-qemu@yandex.ru>
> Signed-off-by: Dmitry Poletaev <poletaev-qemu@yandex.ru>
>
> ---
>  target-i386/fpu_helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-i386/fpu_helper.c b/target-i386/fpu_helper.c
> index 1b2900d..be1e545 100644
> --- a/target-i386/fpu_helper.c
> +++ b/target-i386/fpu_helper.c
> @@ -622,7 +622,7 @@ void helper_fbld_ST0(CPUX86State *env, target_ulong ptr)
>      }
>      tmp = int64_to_floatx80(val, &env->fp_status);
>      if (cpu_ldub_data(env, ptr + 9) & 0x80) {
> -        floatx80_chs(tmp);
> +        tmp = floatx80_chs(tmp);
>      }
>      fpush(env);
>      ST0 = tmp;
> --
> 1.8.4.msysgit.0
Richard Henderson Nov. 12, 2014, 7:43 a.m. UTC | #2 
On 11/11/2014 01:33 PM, Dmitry Poletaev wrote:
> ping
> 
> 25.07.2014, 15:48, "Dmitry Poletaev" <poletaev-qemu@yandex.ru>:
>> Obviously, there is a misprint in function implementation.
>>
>> From: Dmitry Poletaev <poletaev-qemu@yandex.ru>
>> Signed-off-by: Dmitry Poletaev <poletaev-qemu@yandex.ru>
>>
>> ---
>>  target-i386/fpu_helper.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/target-i386/fpu_helper.c b/target-i386/fpu_helper.c
>> index 1b2900d..be1e545 100644
>> --- a/target-i386/fpu_helper.c
>> +++ b/target-i386/fpu_helper.c
>> @@ -622,7 +622,7 @@ void helper_fbld_ST0(CPUX86State *env, target_ulong ptr)
>>      }
>>      tmp = int64_to_floatx80(val, &env->fp_status);
>>      if (cpu_ldub_data(env, ptr + 9) & 0x80) {
>> -        floatx80_chs(tmp);
>> +        tmp = floatx80_chs(tmp);
>>      }
>>      fpush(env);
>>      ST0 = tmp;

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~
diff mbox

Patch

diff --git a/target-i386/fpu_helper.c b/target-i386/fpu_helper.c
index 1b2900d..be1e545 100644
--- a/target-i386/fpu_helper.c
+++ b/target-i386/fpu_helper.c
@@ -622,7 +622,7 @@  void helper_fbld_ST0(CPUX86State *env, target_ulong ptr)
     }
     tmp = int64_to_floatx80(val, &env->fp_status);
     if (cpu_ldub_data(env, ptr + 9) & 0x80) {
-        floatx80_chs(tmp);
+        tmp = floatx80_chs(tmp);
     }
     fpush(env);
     ST0 = tmp;