Message ID | 2f195665d6707ea875d385abce84c845f116a275.1376049708.git.jan.kiszka@siemens.com |
---|---|
State | New |
Headers | show |
Am 09.08.2013 14:01, schrieb Jan Kiszka: > This reverts commit 9b8c69243585a32d14b9bb9fcd52c37b0b5a1b71. > > The commit was wrong: We only return -1 on invalid accesses, not on > valid but unbacked ones. This broke various corner cases. > > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> Tested-by: Andreas Färber <andreas.faerber@web.de> Restores previous PReP behavior. Thanks, Andreas
diff --git a/memory.c b/memory.c index 886f838..5a10fd0 100644 --- a/memory.c +++ b/memory.c @@ -872,7 +872,7 @@ static uint64_t unassigned_mem_read(void *opaque, hwaddr addr, if (current_cpu != NULL) { cpu_unassigned_access(current_cpu, addr, false, false, 0, size); } - return -1ULL; + return 0; } static void unassigned_mem_write(void *opaque, hwaddr addr,
This reverts commit 9b8c69243585a32d14b9bb9fcd52c37b0b5a1b71. The commit was wrong: We only return -1 on invalid accesses, not on valid but unbacked ones. This broke various corner cases. Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> --- memory.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)