Message ID | 2b92ae960dfc47149945c9e47f90b4433d8eee35.1532701430.git.damien.hedde@greensocs.com |
---|---|
State | New |
Headers | show |
Series | Clock and power gating support | expand |
Hi Damien, On 07/27/2018 11:37 AM, Damien Hedde wrote: > Add functions [qdev|qbus]_set_[power|clock]_all(_fn). > Theses allow to control power and clock gating along a bus hierarchy. > > Signed-off-by: Damien Hedde <damien.hedde@greensocs.com> > --- > include/hw/qdev-core.h | 20 +++++++++++++++++ > hw/core/qdev.c | 51 ++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 71 insertions(+) > > diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h > index 659287e185..607c367738 100644 > --- a/include/hw/qdev-core.h > +++ b/include/hw/qdev-core.h > @@ -464,4 +464,24 @@ void device_set_power(DeviceState *dev, bool en); > */ > void device_set_clock(DeviceState *dev, bool en); > > +/** > + * qdev/qbus_set_power_all(_fn) > + * Enable/Disable the power of a tree starting > + * at given device or bus > + */ > +void qdev_set_power_all(DeviceState *dev, bool en); > +void qdev_set_power_all_fn(void *opaque, bool en); > +void qbus_set_power_all(BusState *bus, bool en); > +void qbus_set_power_all_fn(void *opaque, bool en); I think we don't need the _fn() functions, most of the current codebase directly use DEVICE(x) or BUS(x) to casts. > + > +/** > + * qdev/qbus_set_clock_all(_fn) > + * Enable/Disable the clock of a tree starting > + * at given device or bus > + */ > +void qdev_set_clock_all(DeviceState *dev, bool en); > +void qdev_set_clock_all_fn(void *opaque, bool en); > +void qbus_set_clock_all(BusState *bus, bool en); > +void qbus_set_clock_all_fn(void *opaque, bool en); > + > #endif > diff --git a/hw/core/qdev.c b/hw/core/qdev.c > index bb6d36eab9..24b90bd45f 100644 > --- a/hw/core/qdev.c > +++ b/hw/core/qdev.c > @@ -1138,6 +1138,57 @@ void device_set_clock(DeviceState *dev, bool en) > } > } > > +static int qdev_set_power_one(DeviceState *dev, void *opaque) > +{ > + device_set_power(dev, *((bool *)opaque)); > + return 0; > +} > + > +void qdev_set_power_all(DeviceState *dev, bool en) > +{ > + qdev_walk_children(dev, NULL, NULL, qdev_set_power_one, NULL, &en); > +} > + > +void qdev_set_power_all_fn(void *opaque, bool en) > +{ > + qdev_set_power_all(DEVICE(opaque), en); > +} > + > +void qbus_set_power_all(BusState *bus, bool en) > +{ > + qbus_walk_children(bus, NULL, NULL, qdev_set_power_one, NULL, &en); > +} > + > +void qbus_set_power_all_fn(void *opaque, bool en) > +{ > + qbus_set_power_all(BUS(opaque), en); > +} > + > +static int qdev_set_clock_one(DeviceState *dev, void *opaque) > +{ > + device_set_clock(dev, *((bool *)opaque)); > + return 0; > +} > + > +void qdev_set_clock_all(DeviceState *dev, bool en) > +{ > + qdev_walk_children(dev, NULL, NULL, qdev_set_clock_one, NULL, &en); > +} > + > +void qdev_set_clock_all_fn(void *opaque, bool en) > +{ > + qdev_set_clock_all(DEVICE(opaque), en); > +} > + > +void qbus_set_clock_all(BusState *bus, bool en) > +{ > + qbus_walk_children(bus, NULL, NULL, qdev_set_clock_one, NULL, &en); > +} > + > +void qbus_set_clock_all_fn(void *opaque, bool en) > +{ > + qbus_set_clock_all(BUS(opaque), en); > +} > > Object *qdev_get_machine(void) > { >
Hi, On 07/27/2018 06:39 PM, Philippe Mathieu-Daudé wrote: > Hi Damien, > > On 07/27/2018 11:37 AM, Damien Hedde wrote: >> Add functions [qdev|qbus]_set_[power|clock]_all(_fn). >> Theses allow to control power and clock gating along a bus hierarchy. >> >> Signed-off-by: Damien Hedde <damien.hedde@greensocs.com> >> --- >> include/hw/qdev-core.h | 20 +++++++++++++++++ >> hw/core/qdev.c | 51 ++++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 71 insertions(+) >> >> diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h >> index 659287e185..607c367738 100644 >> --- a/include/hw/qdev-core.h >> +++ b/include/hw/qdev-core.h >> @@ -464,4 +464,24 @@ void device_set_power(DeviceState *dev, bool en); >> */ >> void device_set_clock(DeviceState *dev, bool en); >> >> +/** >> + * qdev/qbus_set_power_all(_fn) >> + * Enable/Disable the power of a tree starting >> + * at given device or bus >> + */ >> +void qdev_set_power_all(DeviceState *dev, bool en); >> +void qdev_set_power_all_fn(void *opaque, bool en); >> +void qbus_set_power_all(BusState *bus, bool en); >> +void qbus_set_power_all_fn(void *opaque, bool en); > > I think we don't need the _fn() functions, most of the current codebase > directly use DEVICE(x) or BUS(x) to casts. Ok, I will remove them. > >> + >> +/** >> + * qdev/qbus_set_clock_all(_fn) >> + * Enable/Disable the clock of a tree starting >> + * at given device or bus >> + */ >> +void qdev_set_clock_all(DeviceState *dev, bool en); >> +void qdev_set_clock_all_fn(void *opaque, bool en); >> +void qbus_set_clock_all(BusState *bus, bool en); >> +void qbus_set_clock_all_fn(void *opaque, bool en); >> + >> #endif >> diff --git a/hw/core/qdev.c b/hw/core/qdev.c >> index bb6d36eab9..24b90bd45f 100644 >> --- a/hw/core/qdev.c >> +++ b/hw/core/qdev.c >> @@ -1138,6 +1138,57 @@ void device_set_clock(DeviceState *dev, bool en) >> } >> } >> >> +static int qdev_set_power_one(DeviceState *dev, void *opaque) >> +{ >> + device_set_power(dev, *((bool *)opaque)); >> + return 0; >> +} >> + >> +void qdev_set_power_all(DeviceState *dev, bool en) >> +{ >> + qdev_walk_children(dev, NULL, NULL, qdev_set_power_one, NULL, &en); >> +} >> + >> +void qdev_set_power_all_fn(void *opaque, bool en) >> +{ >> + qdev_set_power_all(DEVICE(opaque), en); >> +} >> + >> +void qbus_set_power_all(BusState *bus, bool en) >> +{ >> + qbus_walk_children(bus, NULL, NULL, qdev_set_power_one, NULL, &en); >> +} >> + >> +void qbus_set_power_all_fn(void *opaque, bool en) >> +{ >> + qbus_set_power_all(BUS(opaque), en); >> +} >> + >> +static int qdev_set_clock_one(DeviceState *dev, void *opaque) >> +{ >> + device_set_clock(dev, *((bool *)opaque)); >> + return 0; >> +} >> + >> +void qdev_set_clock_all(DeviceState *dev, bool en) >> +{ >> + qdev_walk_children(dev, NULL, NULL, qdev_set_clock_one, NULL, &en); >> +} >> + >> +void qdev_set_clock_all_fn(void *opaque, bool en) >> +{ >> + qdev_set_clock_all(DEVICE(opaque), en); >> +} >> + >> +void qbus_set_clock_all(BusState *bus, bool en) >> +{ >> + qbus_walk_children(bus, NULL, NULL, qdev_set_clock_one, NULL, &en); >> +} >> + >> +void qbus_set_clock_all_fn(void *opaque, bool en) >> +{ >> + qbus_set_clock_all(BUS(opaque), en); >> +} >> >> Object *qdev_get_machine(void) >> { >> >
diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h index 659287e185..607c367738 100644 --- a/include/hw/qdev-core.h +++ b/include/hw/qdev-core.h @@ -464,4 +464,24 @@ void device_set_power(DeviceState *dev, bool en); */ void device_set_clock(DeviceState *dev, bool en); +/** + * qdev/qbus_set_power_all(_fn) + * Enable/Disable the power of a tree starting + * at given device or bus + */ +void qdev_set_power_all(DeviceState *dev, bool en); +void qdev_set_power_all_fn(void *opaque, bool en); +void qbus_set_power_all(BusState *bus, bool en); +void qbus_set_power_all_fn(void *opaque, bool en); + +/** + * qdev/qbus_set_clock_all(_fn) + * Enable/Disable the clock of a tree starting + * at given device or bus + */ +void qdev_set_clock_all(DeviceState *dev, bool en); +void qdev_set_clock_all_fn(void *opaque, bool en); +void qbus_set_clock_all(BusState *bus, bool en); +void qbus_set_clock_all_fn(void *opaque, bool en); + #endif diff --git a/hw/core/qdev.c b/hw/core/qdev.c index bb6d36eab9..24b90bd45f 100644 --- a/hw/core/qdev.c +++ b/hw/core/qdev.c @@ -1138,6 +1138,57 @@ void device_set_clock(DeviceState *dev, bool en) } } +static int qdev_set_power_one(DeviceState *dev, void *opaque) +{ + device_set_power(dev, *((bool *)opaque)); + return 0; +} + +void qdev_set_power_all(DeviceState *dev, bool en) +{ + qdev_walk_children(dev, NULL, NULL, qdev_set_power_one, NULL, &en); +} + +void qdev_set_power_all_fn(void *opaque, bool en) +{ + qdev_set_power_all(DEVICE(opaque), en); +} + +void qbus_set_power_all(BusState *bus, bool en) +{ + qbus_walk_children(bus, NULL, NULL, qdev_set_power_one, NULL, &en); +} + +void qbus_set_power_all_fn(void *opaque, bool en) +{ + qbus_set_power_all(BUS(opaque), en); +} + +static int qdev_set_clock_one(DeviceState *dev, void *opaque) +{ + device_set_clock(dev, *((bool *)opaque)); + return 0; +} + +void qdev_set_clock_all(DeviceState *dev, bool en) +{ + qdev_walk_children(dev, NULL, NULL, qdev_set_clock_one, NULL, &en); +} + +void qdev_set_clock_all_fn(void *opaque, bool en) +{ + qdev_set_clock_all(DEVICE(opaque), en); +} + +void qbus_set_clock_all(BusState *bus, bool en) +{ + qbus_walk_children(bus, NULL, NULL, qdev_set_clock_one, NULL, &en); +} + +void qbus_set_clock_all_fn(void *opaque, bool en) +{ + qbus_set_clock_all(BUS(opaque), en); +} Object *qdev_get_machine(void) {
Add functions [qdev|qbus]_set_[power|clock]_all(_fn). Theses allow to control power and clock gating along a bus hierarchy. Signed-off-by: Damien Hedde <damien.hedde@greensocs.com> --- include/hw/qdev-core.h | 20 +++++++++++++++++ hw/core/qdev.c | 51 ++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 71 insertions(+)