diff mbox series

[63/66] bsd-user: Don't write back length on kenv error

Message ID 20260515-misc-2026q2-v1-63-5438ca41b27a@bsdimp.com
State New
Headers show
Series bsd-user: Upstream most of the remaining system calls | expand

Commit Message

Warner Losh May 15, 2026, 9:20 p.m. UTC 
When kenv with KENV_GET and KENV_DUMP* return an error, don't write
anything back to len.

Signed-off-by: Warner Losh <imp@bsdimp.com>
---
 bsd-user/freebsd/os-misc.h | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/bsd-user/freebsd/os-misc.h b/bsd-user/freebsd/os-misc.h
index 204d8ebd3d..92c0a5b4ca 100644
--- a/bsd-user/freebsd/os-misc.h
+++ b/bsd-user/freebsd/os-misc.h
@@ -480,7 +480,9 @@  static inline abi_long do_freebsd_kenv(abi_long action, abi_ulong name,
         }
         ret = kenv(action, gname, gvalue, len);
         if (ret > 0) {
-                len = ret;
+            len = ret;
+        } else {
+            len = 0;
         }
         break;
     case KENV_SET:
@@ -522,7 +524,9 @@  static inline abi_long do_freebsd_kenv(abi_long action, abi_ulong name,
         /* name is ignored, per kenv(2) */
         ret = kenv(action, NULL, gvalue, len);
         if (ret > 0) {
-                len = ret;
+            len = ret;
+        } else {
+            len = 0;
         }
         break;
     default: