| Message ID | 20240718094159.902024-2-berrange@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | ci: fix running of vnc-display-test | expand |
On 18/07/2024 11.41, Daniel P. Berrangé wrote: > The gtk-vnc package is used by the vnc-display-test qtest > program. Technically only gvnc is needed, but since we > already pull in the gtk3 dep, it is harmless to depend > on gtk-vnc. > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> > --- > tests/lcitool/projects/qemu.yml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/lcitool/projects/qemu.yml b/tests/lcitool/projects/qemu.yml > index 0c85784259..252e871f80 100644 > --- a/tests/lcitool/projects/qemu.yml > +++ b/tests/lcitool/projects/qemu.yml > @@ -32,6 +32,7 @@ packages: > - glusterfs > - gnutls > - gtk3 > + - gtk-vnc > - hostname > - json-c > - libaio Reviewed-by: Thomas Huth <thuth@redhat.com> IIRC Alex has a patch in his queue already to refresh the docker images, maybe he could include this change there, too...?
On Thu, Jul 18, 2024 at 12:34:13PM +0200, Thomas Huth wrote: > On 18/07/2024 11.41, Daniel P. Berrangé wrote: > > The gtk-vnc package is used by the vnc-display-test qtest > > program. Technically only gvnc is needed, but since we > > already pull in the gtk3 dep, it is harmless to depend > > on gtk-vnc. > > > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> > > --- > > tests/lcitool/projects/qemu.yml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tests/lcitool/projects/qemu.yml b/tests/lcitool/projects/qemu.yml > > index 0c85784259..252e871f80 100644 > > --- a/tests/lcitool/projects/qemu.yml > > +++ b/tests/lcitool/projects/qemu.yml > > @@ -32,6 +32,7 @@ packages: > > - glusterfs > > - gnutls > > - gtk3 > > + - gtk-vnc > > - hostname > > - json-c > > - libaio > > Reviewed-by: Thomas Huth <thuth@redhat.com> > > IIRC Alex has a patch in his queue already to refresh the docker images, > maybe he could include this change there, too...? Yep, I included patch 2 just for completeness, assuming Alex would just pick patch 1, and then re-generate. With regards, Daniel
diff --git a/tests/lcitool/projects/qemu.yml b/tests/lcitool/projects/qemu.yml index 0c85784259..252e871f80 100644 --- a/tests/lcitool/projects/qemu.yml +++ b/tests/lcitool/projects/qemu.yml @@ -32,6 +32,7 @@ packages: - glusterfs - gnutls - gtk3 + - gtk-vnc - hostname - json-c - libaio
The gtk-vnc package is used by the vnc-display-test qtest program. Technically only gvnc is needed, but since we already pull in the gtk3 dep, it is harmless to depend on gtk-vnc. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- tests/lcitool/projects/qemu.yml | 1 + 1 file changed, 1 insertion(+)