| Message ID | 20240528070515.117160-3-adityag@linux.ibm.com |
|---|---|
| State | New |
| Headers | show |
| Series | Power11 support for QEMU | expand |
On 5/28/24 12:35, Aditya Gupta wrote: > Add sPAPR CPU Core definition for Power11 > > Cc: David Gibson <david@gibson.dropbear.id.au> (reviewer:sPAPR (pseries)) > Cc: Harsh Prateek Bora <harshpb@linux.ibm.com> (reviewer:sPAPR (pseries)) > Cc: Cédric Le Goater <clg@kaod.org> > Cc: Daniel Henrique Barboza <danielhb413@gmail.com> > Cc: Frédéric Barrat <fbarrat@linux.ibm.com> > Cc: Mahesh J Salgaonkar <mahesh@linux.ibm.com> > Cc: Madhavan Srinivasan <maddy@linux.ibm.com> > Cc: Nicholas Piggin <npiggin@gmail.com> > Signed-off-by: Aditya Gupta <adityag@linux.ibm.com> > --- > docs/system/ppc/pseries.rst | 6 +++--- > hw/ppc/spapr_cpu_core.c | 1 + > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/docs/system/ppc/pseries.rst b/docs/system/ppc/pseries.rst > index a876d897b6e4..3277564b34c2 100644 > --- a/docs/system/ppc/pseries.rst > +++ b/docs/system/ppc/pseries.rst > @@ -15,9 +15,9 @@ Supported devices > ================= > > * Multi processor support for many Power processors generations: POWER7, > - POWER7+, POWER8, POWER8NVL, POWER9, and Power10. Support for POWER5+ exists, > - but its state is unknown. > - * Interrupt Controller, XICS (POWER8) and XIVE (POWER9 and Power10) > + POWER7+, POWER8, POWER8NVL, POWER9, Power10 and Power11. Support for POWER5+ > + exists, but its state is unknown. > + * Interrupt Controller, XICS (POWER8) and XIVE (POWER9, Power10, Power11) I think it would look more cleaner to rephrase as below: * Multi processor support for many Power processors generations: - POWER7, POWER7+ - POWER8, POWER8NVL - POWER9 - Power10 - Power11. - Support for POWER5+ exists, but its state is unknown. * Interrupt Controller - XICS (POWER8) - XIVE (Supported by below:) - POWER9 - Power10 - Power11 So, that every next platform just need to add one line for itself. With that, Reviewed-by: Harsh Prateek Bora <harshpb@linux.ibm.com> Thanks Harsh > * vPHB PCIe Host bridge. > * vscsi and vnet devices, compatible with the same devices available on a > PowerVM hypervisor with VIOS managing LPARs. > diff --git a/hw/ppc/spapr_cpu_core.c b/hw/ppc/spapr_cpu_core.c > index e7c9edd033c8..62416b7e0a7e 100644 > --- a/hw/ppc/spapr_cpu_core.c > +++ b/hw/ppc/spapr_cpu_core.c > @@ -401,6 +401,7 @@ static const TypeInfo spapr_cpu_core_type_infos[] = { > DEFINE_SPAPR_CPU_CORE_TYPE("power9_v2.0"), > DEFINE_SPAPR_CPU_CORE_TYPE("power9_v2.2"), > DEFINE_SPAPR_CPU_CORE_TYPE("power10_v2.0"), > + DEFINE_SPAPR_CPU_CORE_TYPE("power11_v2.0"), > #ifdef CONFIG_KVM > DEFINE_SPAPR_CPU_CORE_TYPE("host"), > #endif
On 5/30/24 09:06, Harsh Prateek Bora wrote: > > > On 5/28/24 12:35, Aditya Gupta wrote: >> Add sPAPR CPU Core definition for Power11 >> >> Cc: David Gibson <david@gibson.dropbear.id.au> (reviewer:sPAPR (pseries)) >> Cc: Harsh Prateek Bora <harshpb@linux.ibm.com> (reviewer:sPAPR (pseries)) >> Cc: Cédric Le Goater <clg@kaod.org> >> Cc: Daniel Henrique Barboza <danielhb413@gmail.com> >> Cc: Frédéric Barrat <fbarrat@linux.ibm.com> >> Cc: Mahesh J Salgaonkar <mahesh@linux.ibm.com> >> Cc: Madhavan Srinivasan <maddy@linux.ibm.com> >> Cc: Nicholas Piggin <npiggin@gmail.com> >> Signed-off-by: Aditya Gupta <adityag@linux.ibm.com> >> --- >> docs/system/ppc/pseries.rst | 6 +++--- >> hw/ppc/spapr_cpu_core.c | 1 + >> 2 files changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/docs/system/ppc/pseries.rst b/docs/system/ppc/pseries.rst >> index a876d897b6e4..3277564b34c2 100644 >> --- a/docs/system/ppc/pseries.rst >> +++ b/docs/system/ppc/pseries.rst >> @@ -15,9 +15,9 @@ Supported devices >> ================= >> * Multi processor support for many Power processors generations: POWER7, >> - POWER7+, POWER8, POWER8NVL, POWER9, and Power10. Support for POWER5+ exists, >> - but its state is unknown. >> - * Interrupt Controller, XICS (POWER8) and XIVE (POWER9 and Power10) >> + POWER7+, POWER8, POWER8NVL, POWER9, Power10 and Power11. Support for POWER5+ >> + exists, but its state is unknown. >> + * Interrupt Controller, XICS (POWER8) and XIVE (POWER9, Power10, Power11) > > I think it would look more cleaner to rephrase as below: > > * Multi processor support for many Power processors generations: > - POWER7, POWER7+ > - POWER8, POWER8NVL > - POWER9 > - Power10 > - Power11. > - Support for POWER5+ exists, but its state is unknown. $ /usr/bin/qemu-system-ppc64 -version QEMU emulator version 8.1.3 (qemu-8.1.3-5.fc39) Copyright (c) 2003-2023 Fabrice Bellard and the QEMU Project developers With the correct kernel/userspace, it runs : # uname -a Linux buildroot 6.6.3 #1 SMP Fri Jan 5 00:00:45 CET 2024 ppc64 GNU/Linux # cat /proc/cpuinfo processor : 0 cpu : POWER5+ (gs) clock : 1000.000000MHz revision : 2.1 (pvr 003b 0201) timebase : 512000000 platform : pSeries model : IBM pSeries (emulated by qemu) machine : CHRP IBM pSeries (emulated by qemu) MMU : Hash Thanks, C. > * Interrupt Controller > - XICS (POWER8) > - XIVE (Supported by below:) > - POWER9 > - Power10 > - Power11 > > So, that every next platform just need to add one line for itself. > > With that, > Reviewed-by: Harsh Prateek Bora <harshpb@linux.ibm.com> > > Thanks > Harsh >> * vPHB PCIe Host bridge. >> * vscsi and vnet devices, compatible with the same devices available on a >> PowerVM hypervisor with VIOS managing LPARs. >> diff --git a/hw/ppc/spapr_cpu_core.c b/hw/ppc/spapr_cpu_core.c >> index e7c9edd033c8..62416b7e0a7e 100644 >> --- a/hw/ppc/spapr_cpu_core.c >> +++ b/hw/ppc/spapr_cpu_core.c >> @@ -401,6 +401,7 @@ static const TypeInfo spapr_cpu_core_type_infos[] = { >> DEFINE_SPAPR_CPU_CORE_TYPE("power9_v2.0"), >> DEFINE_SPAPR_CPU_CORE_TYPE("power9_v2.2"), >> DEFINE_SPAPR_CPU_CORE_TYPE("power10_v2.0"), >> + DEFINE_SPAPR_CPU_CORE_TYPE("power11_v2.0"), >> #ifdef CONFIG_KVM >> DEFINE_SPAPR_CPU_CORE_TYPE("host"), >> #endif
diff --git a/docs/system/ppc/pseries.rst b/docs/system/ppc/pseries.rst index a876d897b6e4..3277564b34c2 100644 --- a/docs/system/ppc/pseries.rst +++ b/docs/system/ppc/pseries.rst @@ -15,9 +15,9 @@ Supported devices ================= * Multi processor support for many Power processors generations: POWER7, - POWER7+, POWER8, POWER8NVL, POWER9, and Power10. Support for POWER5+ exists, - but its state is unknown. - * Interrupt Controller, XICS (POWER8) and XIVE (POWER9 and Power10) + POWER7+, POWER8, POWER8NVL, POWER9, Power10 and Power11. Support for POWER5+ + exists, but its state is unknown. + * Interrupt Controller, XICS (POWER8) and XIVE (POWER9, Power10, Power11) * vPHB PCIe Host bridge. * vscsi and vnet devices, compatible with the same devices available on a PowerVM hypervisor with VIOS managing LPARs. diff --git a/hw/ppc/spapr_cpu_core.c b/hw/ppc/spapr_cpu_core.c index e7c9edd033c8..62416b7e0a7e 100644 --- a/hw/ppc/spapr_cpu_core.c +++ b/hw/ppc/spapr_cpu_core.c @@ -401,6 +401,7 @@ static const TypeInfo spapr_cpu_core_type_infos[] = { DEFINE_SPAPR_CPU_CORE_TYPE("power9_v2.0"), DEFINE_SPAPR_CPU_CORE_TYPE("power9_v2.2"), DEFINE_SPAPR_CPU_CORE_TYPE("power10_v2.0"), + DEFINE_SPAPR_CPU_CORE_TYPE("power11_v2.0"), #ifdef CONFIG_KVM DEFINE_SPAPR_CPU_CORE_TYPE("host"), #endif
Add sPAPR CPU Core definition for Power11 Cc: David Gibson <david@gibson.dropbear.id.au> (reviewer:sPAPR (pseries)) Cc: Harsh Prateek Bora <harshpb@linux.ibm.com> (reviewer:sPAPR (pseries)) Cc: Cédric Le Goater <clg@kaod.org> Cc: Daniel Henrique Barboza <danielhb413@gmail.com> Cc: Frédéric Barrat <fbarrat@linux.ibm.com> Cc: Mahesh J Salgaonkar <mahesh@linux.ibm.com> Cc: Madhavan Srinivasan <maddy@linux.ibm.com> Cc: Nicholas Piggin <npiggin@gmail.com> Signed-off-by: Aditya Gupta <adityag@linux.ibm.com> --- docs/system/ppc/pseries.rst | 6 +++--- hw/ppc/spapr_cpu_core.c | 1 + 2 files changed, 4 insertions(+), 3 deletions(-)