| Message ID | 20240505171444.333302-7-dave@treblig.org |
|---|---|
| State | New |
| Headers | show |
| Series | Remove some unused structures | expand |
On Sun, 5 May 2024, Dr. David Alan Gilbert wrote: > I think it's use was removed by > Commit 5883d8b296 ("mmu-hash*: Don't use full ppc_hash{32, > 64}_translate() path for get_phys_page_debug()") > > Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org> Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu> > --- > target/ppc/mmu-hash32.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/target/ppc/mmu-hash32.c b/target/ppc/mmu-hash32.c > index 3976416840..746321329c 100644 > --- a/target/ppc/mmu-hash32.c > +++ b/target/ppc/mmu-hash32.c > @@ -36,12 +36,6 @@ > # define LOG_BATS(...) do { } while (0) > #endif > > -struct mmu_ctx_hash32 { > - hwaddr raddr; /* Real address */ > - int prot; /* Protection bits */ > - int key; /* Access key */ > -}; > - > static int ppc_hash32_pp_prot(int key, int pp, int nx) > { > int prot; >
On Sun, 5 May 2024, BALATON Zoltan wrote: > On Sun, 5 May 2024, Dr. David Alan Gilbert wrote: >> I think it's use was removed by >> Commit 5883d8b296 ("mmu-hash*: Don't use full ppc_hash{32, >> 64}_translate() path for get_phys_page_debug()") >> >> Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org> > > Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu> I've picked this patch up and will send with my series that changes the same place to avoid needing to rebase. Regards, BALATON Zoltan >> --- >> target/ppc/mmu-hash32.c | 6 ------ >> 1 file changed, 6 deletions(-) >> >> diff --git a/target/ppc/mmu-hash32.c b/target/ppc/mmu-hash32.c >> index 3976416840..746321329c 100644 >> --- a/target/ppc/mmu-hash32.c >> +++ b/target/ppc/mmu-hash32.c >> @@ -36,12 +36,6 @@ >> # define LOG_BATS(...) do { } while (0) >> #endif >> >> -struct mmu_ctx_hash32 { >> - hwaddr raddr; /* Real address */ >> - int prot; /* Protection bits */ >> - int key; /* Access key */ >> -}; >> - >> static int ppc_hash32_pp_prot(int key, int pp, int nx) >> { >> int prot; >> > >
* BALATON Zoltan (balaton@eik.bme.hu) wrote: > On Sun, 5 May 2024, BALATON Zoltan wrote: > > On Sun, 5 May 2024, Dr. David Alan Gilbert wrote: > > > I think it's use was removed by > > > Commit 5883d8b296 ("mmu-hash*: Don't use full ppc_hash{32, > > > 64}_translate() path for get_phys_page_debug()") > > > > > > Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org> > > > > Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu> > > I've picked this patch up and will send with my series that changes the same > place to avoid needing to rebase. Thanks! Dave > Regards, > BALATON Zoltan > > > > --- > > > target/ppc/mmu-hash32.c | 6 ------ > > > 1 file changed, 6 deletions(-) > > > > > > diff --git a/target/ppc/mmu-hash32.c b/target/ppc/mmu-hash32.c > > > index 3976416840..746321329c 100644 > > > --- a/target/ppc/mmu-hash32.c > > > +++ b/target/ppc/mmu-hash32.c > > > @@ -36,12 +36,6 @@ > > > # define LOG_BATS(...) do { } while (0) > > > #endif > > > > > > -struct mmu_ctx_hash32 { > > > - hwaddr raddr; /* Real address */ > > > - int prot; /* Protection bits */ > > > - int key; /* Access key */ > > > -}; > > > - > > > static int ppc_hash32_pp_prot(int key, int pp, int nx) > > > { > > > int prot; > > > > > > >
diff --git a/target/ppc/mmu-hash32.c b/target/ppc/mmu-hash32.c index 3976416840..746321329c 100644 --- a/target/ppc/mmu-hash32.c +++ b/target/ppc/mmu-hash32.c @@ -36,12 +36,6 @@ # define LOG_BATS(...) do { } while (0) #endif -struct mmu_ctx_hash32 { - hwaddr raddr; /* Real address */ - int prot; /* Protection bits */ - int key; /* Access key */ -}; - static int ppc_hash32_pp_prot(int key, int pp, int nx) { int prot;
I think it's use was removed by Commit 5883d8b296 ("mmu-hash*: Don't use full ppc_hash{32, 64}_translate() path for get_phys_page_debug()") Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org> --- target/ppc/mmu-hash32.c | 6 ------ 1 file changed, 6 deletions(-)