From patchwork Thu May 2 15:29:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: CLEMENT MATHIEU--DRIF X-Patchwork-Id: 1930647 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=eviden.com header.i=@eviden.com header.a=rsa-sha256 header.s=mail header.b=HXy/3U4y; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VVdDC1fvrz1ydT for ; Fri, 3 May 2024 01:30:19 +1000 (AEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s2YNK-0003gZ-UN; Thu, 02 May 2024 11:29:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2YNJ-0003fv-7T for qemu-devel@nongnu.org; Thu, 02 May 2024 11:29:33 -0400 Received: from smarthost3.eviden.com ([80.78.11.84]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2YNH-0005zE-HC for qemu-devel@nongnu.org; Thu, 02 May 2024 11:29:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eviden.com; i=@eviden.com; q=dns/txt; s=mail; t=1714663771; x=1746199771; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=jqH22yC3gZ1HF0ZE1kcRC60g7aPGVpRl1CeIoCk/E/I=; b=HXy/3U4yqF1rI4c+pVpIbEdKQscOymKvQmPPYTxyBJdqY5XX2SX7yR5N 0QU4NMePTFvQXdfYKdJ2uFs6MReno3LzUEk/9z5eMjAx9XDjMSM61uYMT stanjsVhbuWL6q/e7IxdgGvRpFxTq564U1vpSY8SXmICmmJr6PTmc6Rve gCUiBh9f8AlGuuCrjzzVi72EqTFe/wX+EV/HMxz8gD59tvBJ/uCKI6V4V mdd2Tu1c0GNO2WasZVBrm5DsfM0g+HW0D62K/dqcHi9YwemlQpRYq4/h7 AyG5i6FwgobPe54IhU3Zw+/0S3Vh0/G/ypj27oBZn3zakyW9Ro149DmZ3 g==; X-IronPort-AV: E=Sophos;i="6.07,247,1708383600"; d="scan'208";a="11730623" X-MGA-submission: MDGyCjIKEHE3ompCo/zyD0zy8d6BiKd1agTole4wPqvjJHjF9N+y4lPZp1Y67N6n/RDeudaUgRo0EaTAIQj/7l6yf0UQe7+kfxqAw1ZCd89RpktxcSMw7QUG1l81AQXKDGFgIjqCUm7CAP2EH3H1TFCcF7c6grIkIr8D8je8N3/zcw== Received: from mail-am6eur05lp2105.outbound.protection.outlook.com (HELO EUR05-AM6-obe.outbound.protection.outlook.com) ([104.47.18.105]) by smarthost3.eviden.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 May 2024 17:29:23 +0200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SuqdJRYm2S/QUG3yy6ZVoqtbotcKWqJjnLuN8JWI3LbkBpKKHpoh0wGW5saoXzuHe5voxNbMDN/oy4QBe0Q8dC1JWoKZHT79cfvYONB4gIy7Gl+O5Sh/0x9KmAmycTIgr4lEWHlYANXqHcWvUb+nEbf6GH5YAdnlLJiWQL3fkqlzhlFXOIb+/eoDguK9eKq6lvIFpswVSFa5EYI4jTj8An85gTR8idvTxmV2V5CwBxeUGP5hinJjRjXk+HPntzLdWxbepHlVoZRLpieVtg9BtNZ/YyaQeUObzEIt4GvoK56/u1R8gK2KrQVF8jCa5C/YpV9KEPgoHzEqjRqb7AdO9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jqH22yC3gZ1HF0ZE1kcRC60g7aPGVpRl1CeIoCk/E/I=; b=CCU35lR+KZqxNd7Roo7V0Jgzmt55bI/PIbyKp5YcTPrOarmieYIDaGbqaVi/kHJ+TtNvTTn8cYAJ98MoDWYtJrtpUGGS6umEbZuGCKJmLZAFf+8hB0JFYGwq2z3pKHYKSrN5zEllcq+MCbwM2wTsxrmiAl1eGR3G5FprCKuxi0oKQe1frLcww9PTiIi417o6oXAfT3EuozM4BecfLv336ptxXZNKLtDIbQP1zbOkiAjVge0dwbTmGuKyLvi8VSnWweLJshCjPm4m/1VD7DZys16NaAs7s8EjnGGA6GhKkJ6qmgRcqTYNxV9xc4ZLrP5DA4ik+RgmMHRHWqKJ2lAOog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=eviden.com; dmarc=pass action=none header.from=eviden.com; dkim=pass header.d=eviden.com; arc=none Received: from AM8PR07MB7602.eurprd07.prod.outlook.com (2603:10a6:20b:24b::7) by AS8PR07MB7768.eurprd07.prod.outlook.com (2603:10a6:20b:351::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.29; Thu, 2 May 2024 15:29:22 +0000 Received: from AM8PR07MB7602.eurprd07.prod.outlook.com ([fe80::fbd7:ca71:b636:6f9d]) by AM8PR07MB7602.eurprd07.prod.outlook.com ([fe80::fbd7:ca71:b636:6f9d%4]) with mapi id 15.20.7519.035; Thu, 2 May 2024 15:29:22 +0000 From: CLEMENT MATHIEU--DRIF To: "qemu-devel@nongnu.org" CC: "jasowang@redhat.com" , "zhenzhong.duan@intel.com" , "kevin.tian@intel.com" , "yi.l.liu@intel.com" , "joao.m.martins@oracle.com" , "peterx@redhat.com" , CLEMENT MATHIEU--DRIF Subject: [PATCH ats_vtd v1 23/24] intel_iommu: set the address mask even when a translation fails Thread-Topic: [PATCH ats_vtd v1 23/24] intel_iommu: set the address mask even when a translation fails Thread-Index: AQHanKWBYNOsIYIeYk+58ghVT37p0Q== Date: Thu, 2 May 2024 15:29:22 +0000 Message-ID: <20240502152810.187492-24-clement.mathieu--drif@eviden.com> References: <20240502152810.187492-1-clement.mathieu--drif@eviden.com> In-Reply-To: <20240502152810.187492-1-clement.mathieu--drif@eviden.com> Accept-Language: en-GB, fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=eviden.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM8PR07MB7602:EE_|AS8PR07MB7768:EE_ x-ms-office365-filtering-correlation-id: 45ab644c-da77-4a2a-7023-08dc6abca459 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|1800799015|366007|376005|38070700009; x-microsoft-antispam-message-info: =?utf-8?q?uWj7XSBXcPB33fln6PGkaavTeTf+QUJ?= =?utf-8?q?xy9lRwS2q6YyzWWOkK5CpL8c09J9Q/Uv5R/sYJzkPSEjmOJog2f2tg2nqxcg1AwqW?= =?utf-8?q?+nxgPiCJy60OcJ/nFHImKi+XpIPuu1sYXlWXRg1ihm85LMQ7Vb1TWnBU5eIAoZyIF?= =?utf-8?q?eeHrRyA16L4Ufvd2X3w0UTnnPOOV5hx63pJ/amFuRnCw3GwN/WGvpHk4tLex9JN+d?= =?utf-8?q?LE0F1mi9JeupxeLnLx02Gt/vIT6JIEH793k/Jk6QAYdy0x8b9iNr1SX0jLoyAgnNO?= =?utf-8?q?CQPQbYntSkAYyUU3Y53Uz3BacdTqw3rQ8miSb5TQRU8ykmo8dVCKbChwMdclNPC9N?= =?utf-8?q?5URzLO3dtr/yaQl8Z0f+E+ZXRCmQJChU/9UDr38kZibL2p1D1dDy9rxfp8iO3Nscv?= =?utf-8?q?XxZTR+i5qDfonD9JL89aqr+YZbf3rzFWCWkF1qBBmijdhWIMH/CxJJch1L/JBD03S?= =?utf-8?q?iInDFr0vKazCSaVJdVB5/xtDen5+eCc3e+ygIPn/i3OCr3da2zfRBTArLszTZarw3?= =?utf-8?q?NUNZGXLAVY6MrAk1+e9SMwfSMYH8uZAmsC1ulvDi+mnkW4caQKHR3Rjf2aXPe3kPn?= =?utf-8?q?1Y+dNVrP1pA+hyRm+H1iNCSpRIXXO1okElpQjykZy4dz3nIx8jDL/3k6/nRx74frR?= =?utf-8?q?xABcfqc/2hOjQs6naPuBd+q4Fi0SR1FTix1oTRLoYetO76SNYB6sZUSO2IsiGVsNF?= =?utf-8?q?Fh2KgAPyiNvVs2jMa8f6Nm5LfTPYnybDEkpfOQPNhtfuRZLaNrkq7QonvJmutffgN?= =?utf-8?q?RqVizSUdSdOiOShsBubExiPUXoqk8klVePEURswpb9CE/OWlnIAwzAjVARN/KEpwm?= =?utf-8?q?pCYAGFH/3eIq+Tc3xm5T9StIlGO5vP5fUbUekiaUaHqarPRcbRQ9UOM6lgYkgtE5w?= =?utf-8?q?s2GHcAQvCgf9FQb5w/rmnjXt3cIY7Evx4E3g1zn6MtGymC7NU54p0Dt4C9CnRYuap?= =?utf-8?q?JaVib1Ih2KR1cI73j4ihhbh/ZHNBXts8RyvBEJUAYigwifVcBebzfsskDKMQ7/712?= =?utf-8?q?V7koZppwia0w67pYaerZzrHQc47IZhYraD1kHNjSAnXFtHfJ8QoNAFrs80BfRVYHE?= =?utf-8?q?p68c2dij0N6C6DN7BAaDRN6TnlCR5ASj9xGLNja6VxKtb/UZbLof9NSOhDdjOX5QE?= =?utf-8?q?HRJ4Y01PVJAdWLVW6cqDCbuRWIxYsarjZvWgvO7SWFHkezeJxP89TmaSIlHyT7Po8?= =?utf-8?q?IHDwscriWghSp9PPH75e3a/LkE4BJInu4PiG2NoWuFkadmGvGC2Sj8s8y5731hcY2?= =?utf-8?q?NTdOcDjoS8dhBAM06uvyJNPrMpSoz+dh2eg=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM8PR07MB7602.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(366007)(376005)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?q?5Z4LwCYxVW+1QEWiY0z2Lnnqcs8n?= =?utf-8?q?3BiFJxqrrCfJhKVYOkDamoUG6e48VHhDSvEK9xszWmGAaqcCB1jQphXzW1Ef2G8BW?= =?utf-8?q?CzZ2HGlefW99/9jvXjh4G4ozZnuIs8N36VyBPYo2tNGenxIeM3dcLUfskMHDUPVAp?= =?utf-8?q?Xnrk9CDyedjZXF44rPBaSoxXYwvWWgsEQadaPp1avDktIl+rolHGLrvaHEmZxuDpv?= =?utf-8?q?miJNfWrZBNSlRsxUeAeZ55pwOwdhKLxHHIs0I6zN5gHPeEY+ALlE3Hwqe1R8lw8gh?= =?utf-8?q?a+c13Nhdpr+PauraoTooq+kDKHDcPXAuyE0otnwh7v6GcqkPAIk8K/TjX8pwutgR2?= =?utf-8?q?taAYO0bAICIEUM1o77ATZszWqN/LuC1yaKsxj07EnqUoMuhMeQf2zPyeORgaJ6ZKC?= =?utf-8?q?Ib2KGu7Nfe1DBrUWeChlTh1YoTiCmByMYw3S4J/8OVj7sXji5yVfFleg5IomjXdB+?= =?utf-8?q?++eUpRGsX7WQWofdnVpF59AVSG4im07tX2V2SPoprvJLqzJ9USrxWqvxHDr9B+Qbm?= =?utf-8?q?PMYQa/azNVwBEfgC92Bn4597rKP+Q/iNjeoczhs2R+SYGu2JlcfGfi2mzkTCVmJ9e?= =?utf-8?q?eg/vb8itG93nRDMGaglHAn0R87fRgS8TJoI6yKXgVK7W3PmQEeUVwllA0IAXEa0MC?= =?utf-8?q?upPKlVH6bCBF6mgJYv3rdIWgbQKxHAidw4bDeRbuYR0jORr9c+mwuqJRdm7ePdU5p?= =?utf-8?q?iHHVgTQxLQJylpoRE7leOj+1JvB+WJJvQ9vTXbzURM1SOddqX1R8+mqy7p/UfAAaJ?= =?utf-8?q?Dmi21yIOaDg2Blufge1I29r5ftX+RgqO31w0fJpcFGVhseo0yOCaeZoiF8+sGG8ye?= =?utf-8?q?+YXGjHvkyVfrRmbAJs8lRT5/ZDNDdmXjeWEFPcimureh9tfUkL/Inj+sngvjjexE5?= =?utf-8?q?7XVYwkxhzUdLgO8/SIcmih/J94t6x3axvUB9BZMJs+vZd20jh1zRf2tRPvk9zDZyT?= =?utf-8?q?3Obw9P1YgR4wJPM361accTxnG5qVHCK+RjkqvxSfJr8BDmXp/Y/cs/T4mq9QsBFi0?= =?utf-8?q?YeQYKW2Cs7tWNnS9ARleGE7LFmk53XfcK79k5epDPEkzCe0SwhOYHasFsBtJkem4E?= =?utf-8?q?lhYZtOb5oFoHH12TQbmA8b0Il9h4Y3f/IGO7WNYlWRi+WhfrQaWkMHs3MdtzNnOel?= =?utf-8?q?8GJ0jTPmDe9YW/XiblZl6ENNQFT48WKeJ11dzYo4r6EvqKj68S67AEYtavkjFW3k9?= =?utf-8?q?AOKHQWNeat3Igofjsjd5a02L0wTnjnbBt9NX6MssC1fxavvupV7GMcAQ8O67zCUgY?= =?utf-8?q?UlOjOFCEZFlrUF/vKNjloBfhiNBoSOZIo64bOxXeLhPzcErgP9lt4/hRzuGbv4oco?= =?utf-8?q?ntzmJGmc+QjQavQUgJ4OpPdX4PKXS84Vj1ev2lLWshEXva+G4iJ40atpHKaAOGdkR?= =?utf-8?q?O4uijwRMEuDcJYwWRBD7LLf7h17dSKZfK3marqXnUSvV2TZ5C3O/3wSc7/Z58Tf1g?= =?utf-8?q?A/1xw6jPlX/c47b6YVKCCmPhFxdo0Cx+2odE54tguDQ7FABsngfqhRV+RqHMbBBYC?= =?utf-8?q?jTbH+RPxlrPfWG9rvSushvii7Y4P4RS8AmyYCfmG2i7hKsI7tvtu3NE=3D?= Content-ID: MIME-Version: 1.0 X-OriginatorOrg: eviden.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM8PR07MB7602.eurprd07.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 45ab644c-da77-4a2a-7023-08dc6abca459 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 May 2024 15:29:22.0893 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7d1c7785-2d8a-437d-b842-1ed5d8fbe00a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QP2EpWIcSTk490Ep0IvC7kLbQlP+5Klu6ELg9clKiUV5tfbCQV3Qj2Hf30WGnJ8oNGHoyA/ZZ76DYcuuPhF8im7goPJqbHaUsLp5XxNqebj2xuBym8UDNvYVV/wyie4s X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR07MB7768 Received-SPF: pass client-ip=80.78.11.84; envelope-from=clement.mathieu--drif@eviden.com; helo=smarthost3.eviden.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Implements the behavior defined in section 10.2.3.5 of PCIe spec rev 5. This is needed by devices that support ATS. Signed-off-by: Clément Mathieu--Drif --- hw/i386/intel_iommu.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 02c5f0fa4f..aac7677063 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -2167,7 +2167,8 @@ static bool vtd_do_iommu_translate(VTDAddressSpace *vtd_as, PCIBus *bus, uint8_t bus_num = pci_bus_num(bus); VTDContextCacheEntry *cc_entry; uint64_t pte, page_mask; - uint32_t level, pasid = vtd_as->pasid; + uint32_t level = UINT32_MAX; + uint32_t pasid = vtd_as->pasid; uint16_t source_id = PCI_BUILD_BDF(bus_num, devfn); int ret_fr; bool is_fpd_set = false; @@ -2309,7 +2310,12 @@ error: vtd_iommu_unlock(s); entry->iova = 0; entry->translated_addr = 0; - entry->addr_mask = 0; + /* + * Set the mask for ATS (the range must be present even when the + * translation fails : PCIe rev 5 10.2.3.5) + */ + entry->addr_mask = (level != UINT32_MAX) ? + (~vtd_slpt_level_page_mask(level)) : (~VTD_PAGE_MASK_4K); entry->perm = IOMMU_NONE; entry->pasid = PCI_NO_PASID; return false;