From patchwork Thu May 2 15:29:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: CLEMENT MATHIEU--DRIF X-Patchwork-Id: 1930651 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=eviden.com header.i=@eviden.com header.a=rsa-sha256 header.s=mail header.b=Ddb6FRHY; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VVdGG3mKYz1ydT for ; Fri, 3 May 2024 01:32:06 +1000 (AEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s2YNR-0003jQ-II; Thu, 02 May 2024 11:29:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2YNO-0003is-UJ for qemu-devel@nongnu.org; Thu, 02 May 2024 11:29:38 -0400 Received: from smarthost4.eviden.com ([80.78.11.85]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2YN7-0005yW-IU for qemu-devel@nongnu.org; Thu, 02 May 2024 11:29:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eviden.com; i=@eviden.com; q=dns/txt; s=mail; t=1714663761; x=1746199761; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=oYY4iC6hjphMuWFvN9OX+COHJCqK87uXfmgSAcUtRSw=; b=Ddb6FRHYZuYx5VUDYe6KkooBN4fbur6fWp6XXmLFMB3lp8j6rE5N9Ai+ 6A5CSHDOPbb4qXCII/58D4lAFFZ7zPPosuL2+vvuQiOgXH2JqILREr7tM FDUt/TYrseouLLX8NhpvhfQYQt0RuXzcmadvydlVXLkTJCDbrrLEQwAga E5iGEa9AyEHqAAI4xP3gCRE8b1tcEXcyNQcMJNd/3Ute/pKnCK9NgomMA jluQHLcYzb47U4s99rxRjdQtOeQbazkn6VacRe8X/NdMEvLMY3c7jeamN X019ejIA1KqvS/pKa/bqQ9pXkUOTkPKfTk49myWqma4CWEP0M/2xIq7Cp Q==; X-IronPort-AV: E=Sophos;i="6.07,247,1708383600"; d="scan'208";a="11785873" X-MGA-submission: MDF8Q9DlUIYTKsz+pBjeCGQyjvrr6JjMUajRvq7Y/DbALCLgYUmj9qkm5+DniX0PZrxU6BpJ6AsGzqVuPGwnDyPdIp6POLS7J/3qdvoeL6Q71EX4RcoivuYEuGtffC0i9u6YLBsEY35rlJ6s18nhoFBUcH/WND7rOh/pi9oMe0HaQA== Received: from mail-db8eur05lp2104.outbound.protection.outlook.com (HELO EUR05-DB8-obe.outbound.protection.outlook.com) ([104.47.17.104]) by smarthost4.eviden.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 May 2024 17:29:18 +0200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mHmDtf0seW53LOY+6dsTfcU7/DD7mAxBozNvm6kgbYPlLsB4Gy//TyDmMa/ADZLYZWOwS6cGYnA8ny7bfU3D1QLvVfoHA1whGv8gKBkk0ayTh/hLXktu2nTizVBGUBPECIea+WE+P05KOnzyaRnbty3hGqOYwKLSMVHjQegJyWMYsfqBZTcOxMY39LrjLQeqIlS3UkalR9bmTOS1AeYAjAxKgs3blIB5eJOwDoedvlBfpkEbD8yAkTT1+eJgcqIjS2SL48XlCQf3oIIOTWPusUm8AFaAlKtR7OUh8SaYHx566VlU1y8rdIDObN9cFetBKja4+ngGFaMeZz/kcAZa0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oYY4iC6hjphMuWFvN9OX+COHJCqK87uXfmgSAcUtRSw=; b=dNkrrwQTPp3AJmHBacvNA0+dl/dqc3O5/fqiqitlQbLz9jASXn8zm2NmqfdFwIwqESO1M71t0dp/17CdU3hTeJX6zBFt+Dwv09mZVWluYk0m8Q3V4QcUjEgWXvpcxJTaRUo8aonaPwkc9whoYbCNGpRnHS1G1VSIYyOPywWs+PfQQJj3WvSeBQs/3SGQd975/V6EFw/b0HsblLU3Y1r2hckqcvhbPW+L1VRh+HOmgtGdSUr/0aiVtHbzMhrUkfv0wbtCasKywQNQjJMD88jDpyNxOixxwXPD62UguRLsdRFxQdXJL+6Xnyl7rGWSWQtTIAqrLp7QHk9CoQxwop8lKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=eviden.com; dmarc=pass action=none header.from=eviden.com; dkim=pass header.d=eviden.com; arc=none Received: from AM8PR07MB7602.eurprd07.prod.outlook.com (2603:10a6:20b:24b::7) by PAWPR07MB9661.eurprd07.prod.outlook.com (2603:10a6:102:389::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.29; Thu, 2 May 2024 15:29:16 +0000 Received: from AM8PR07MB7602.eurprd07.prod.outlook.com ([fe80::fbd7:ca71:b636:6f9d]) by AM8PR07MB7602.eurprd07.prod.outlook.com ([fe80::fbd7:ca71:b636:6f9d%4]) with mapi id 15.20.7519.035; Thu, 2 May 2024 15:29:16 +0000 From: CLEMENT MATHIEU--DRIF To: "qemu-devel@nongnu.org" CC: "jasowang@redhat.com" , "zhenzhong.duan@intel.com" , "kevin.tian@intel.com" , "yi.l.liu@intel.com" , "joao.m.martins@oracle.com" , "peterx@redhat.com" , CLEMENT MATHIEU--DRIF Subject: [PATCH ats_vtd v1 01/24] intel_iommu: fix FRCD construction macro. Thread-Topic: [PATCH ats_vtd v1 01/24] intel_iommu: fix FRCD construction macro. Thread-Index: AQHanKV+0oFxZ/mIHESjydUfkcyb3w== Date: Thu, 2 May 2024 15:29:16 +0000 Message-ID: <20240502152810.187492-2-clement.mathieu--drif@eviden.com> References: <20240502152810.187492-1-clement.mathieu--drif@eviden.com> In-Reply-To: <20240502152810.187492-1-clement.mathieu--drif@eviden.com> Accept-Language: en-GB, fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=eviden.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM8PR07MB7602:EE_|PAWPR07MB9661:EE_ x-ms-office365-filtering-correlation-id: 85d91a4d-d423-475c-3ff5-08dc6abca121 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|366007|1800799015|376005|38070700009; x-microsoft-antispam-message-info: =?utf-8?q?3YmFv62QyXJXLjiYDghbJ4O72nM+p4S?= =?utf-8?q?eaek/OYlZJFM16m/HTkLQqfrvX6zi9Eb+hw8WQx91jQ6dkQmud1jvG5AAUykh6DNI?= =?utf-8?q?ioTkNqWRKcwdTblbvy4KbIjU0wFjsdihM2Oyvg61zz6vYAtJNy9IlPoCewjqtYBW5?= =?utf-8?q?9KfzjXCiyV+LP0NJ4vnep/9yXY94bWtUXewJ5ZPVhBDJPCrO7FSu7qxddHQl8UQ0y?= =?utf-8?q?rGxPAzf61p+F7FOVXUvY1DMhvC3781bGeo+kJ7tKTucD3W/v0V7GU6JKBsxe3RfHf?= =?utf-8?q?iOag1cPOYZRTM28V3tl097XO3hsmtlDPmdMAOUX6I/7y5K923sMoZ0pwtG+O94A3D?= =?utf-8?q?0VmuF4RdimWgR6/SouRKrFFvN7p2QEUqkV/63KXHNhJss+H8LXKaLa5efYwqlVOEU?= =?utf-8?q?g/a5fkqvEBCFo2zYudgdM9jbHaI8YA60/5vniWvmRXX2S4kZxwqb+/xqCtmUSLPdG?= =?utf-8?q?cFPwavG7Sq4Jg4492ePtTwfO4fygEWGl4SuM9Q+PBckZpDNpXC+FmI0ilBCSxaCKu?= =?utf-8?q?Jk24RZjOE2ISmMHxevHtNCi95EnbxGdnCpWDW/tb8Lj+suyJ3mtRW1ezO3RcYWRxl?= =?utf-8?q?ahz1G6r0ZW5eEFt7g7MP60A5y5347VwiNYef83TNlmz+tBg6sMgqY78H8ANtnLxO+?= =?utf-8?q?Irb3J0Hluvg1BmjRZV5tdaYxHP0u030K+Qx3WrQBnzSFv2iLSw6RYTyoySURMUodh?= =?utf-8?q?LeN/NLvQi792bL1JIvBEpt0zY9Yy3b8Mlym/nqYkzdtKJ+3pYSre1AI1YnkuVhzU+?= =?utf-8?q?UuB5lMXBbwjbT5nBXggV5lpfRz0yHLfAB+4Ac8PP/YGEnacRBtkF1/CtI0sMVeTIe?= =?utf-8?q?1ZvoYL0JIxOZvJh5hmb0YgOt0g4PDvashpe0Z7Qt3Bz9qnULm+6vgUBJ1WCfn7ACm?= =?utf-8?q?qSQrWjhSeLvwUo+x/2czIbFjA2vojohTuIwLLJZBCxlf63YDxpNTLxLLQnOZqwZtG?= =?utf-8?q?v/cS0cIldQi2/MYeXpDyrxA4yfKdnPm3os6goUwrA33BiH4D4vD7H3w83cgbhKOgW?= =?utf-8?q?oyw74FlTU3wq5hg1McwYOCIcc9rYnGMbHJW17iVnellwia6EFq5mNZ0Xu8UeqwshU?= =?utf-8?q?3tdy4PWQKJ1Z+6883w80pxq1O3qCqzrN8+KRZhBFEiQ9rlv4UokdJ5xcQDeugDfta?= =?utf-8?q?8uqI2lRNueYPTKZMIYoXHZnhvejPDNTLwtlKwCSAaVqMg8+nMu0qQkEOnw7t3JU+t?= =?utf-8?q?e/wxT9qNz3wtKYuf3Q6z0LIulUDVz6+C7KicyQ2Wv9cylVUV4R+zIoShi0fRh1qLs?= =?utf-8?q?lVQPmWss5mEI+lryT1SN7JCj0s+XMPMM8Ww=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM8PR07MB7602.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(1800799015)(376005)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?q?dkpJ5rG8ifA210IPzkyBrtjSEDko?= =?utf-8?q?ujKXOSjmVl3bv8mYbOK1N9+JED4OkK45tE+N9FMdTuXfI+aKarOCxsSkH1ZNHbTnK?= =?utf-8?q?fYb0WAAXCm13RbNt//TQMWwmDC08ypQNBIBU2MgWKhS4jaGDkgWBHjRGvymzjaOSb?= =?utf-8?q?vzWzlxW+bwxtk6LfUPWTu5fIVFpMLjvIgxKz7BjBmVHNKv4JrWQ1ybILDI4SJ846Y?= =?utf-8?q?D2s0zXYXTWH6mncLi28du0tdeH2chPcekglEzZZe4BZ2tr5wWywmqXWjLxHcY2jD1?= =?utf-8?q?q7T3EATPYyT7serOWHcdRzU25voPHjOKAsax8o8hJ+4kbV770dMTReVQwBCK9/yGW?= =?utf-8?q?3QxoSzagVQeL/vS9VoyWnuieRS91GEqrbdAtMytEmVSzf9vQqpCsg1t6bfgsOybOx?= =?utf-8?q?7nuvmMMfRg0pe8EvvNSx5Z8fPC9PLl6NveOU3Z18p4TNna1mIL4Fm9pU1m8DdS8O2?= =?utf-8?q?nuGq4hgvNN2gN6buiTO7j9XjNNDET7ftEFgH8weCHfN5PSUkraDNIgHJX3IgY15Ry?= =?utf-8?q?OqNpD5MSRm5ZPpzQq2DIM8Q51lMhrtDmZ9HdMFRF8KpnoWWLjWqJoctffnZWKVBCG?= =?utf-8?q?GKRGQzFnaCzhHxsXGva0hEKH6AJ8MdHzi7IYZWW2f5o3VPwHxaXQuOEFa9KEbIr1I?= =?utf-8?q?NPOU+hbqy6riajpg/CedRwkv9TmRfXdYLZOdXoIoahNOc5Yc7YN3T/zwZFxNus4qi?= =?utf-8?q?jQmimRXLXKpfCC34SQCiXKBp19dvXo5ZwHoSy6xHZ2boE7M7jl++QvHVrgISWxjT/?= =?utf-8?q?Y+l42i2r1I8ttv/ydmTSC+Nxcj+ILg3GYq5mDBiDLiOVCUqI6ixsN94iU4i6ta5kB?= =?utf-8?q?9vR+sBsYECSAGM3rnvOfId4KZg8EV2UwoDnamEeEEjynuj99KKa2luT+5vhs91sD8?= =?utf-8?q?ydOVxszI24b75Q79eG/aVBDFQ2t0YaXGEPUh04hCI6+7/sRFEiemy/t9pnRGA1MrL?= =?utf-8?q?T/Gw/VhHexavVW7J7DftuQO8IO5ih56oFYFPs3rP+bcRAruGcGfI040W9kv5t6CmW?= =?utf-8?q?i2XO26KXomubyENEvFaeZg9uIKDUE1uiRP5UNrltLBsswiVJ78+Rt02RHYNL/HZtd?= =?utf-8?q?nDgYMHRGHsnVsFS5RZ5vegrIrwbMR7xOZ+ueHR93wwtKYux236K4zDlbIOiLEITFY?= =?utf-8?q?pDsgUH44gLhh+3xNyxF5VSIoiiplm+G2rmUYN1dppRmzn0PqyHgE5qaja5MjaQpEq?= =?utf-8?q?d1zw2sMbqep2lJRAFUzcaQMALYtN3zMpWPqD9e4BiL/zw5AzeRF9uK4QxZb/8+2a3?= =?utf-8?q?sSivt19ewdP9+K1W0W9KmO1Vt52yXiD1zKcMF7K77AsNRhDnl+jbRZfh5EjSvIMSL?= =?utf-8?q?6I7Kc7XoIjzj3ZQacEwsMTB7RV9XjGOmApxBAUeSPmw2U6VeKRhT1YN5IUUP5PznK?= =?utf-8?q?UPrwCUopBiGJQD76qp29D4WFEuSEnZFm0EDUUkbpPKSAWHJ2kiz6Cl6x3Xy8zBFbW?= =?utf-8?q?tEe5M3cHi1401hb1FHnN/7yAIP0ft8V18tvaOGXRAHarrq9edqLLZusDWyazj1EkI?= =?utf-8?q?U31yzbDE1F6rc075NORykhZMDyr5p4dm0XofeQzjiBZI+ll+8lTAUTI=3D?= Content-ID: <2B98B1588D36FF47BED2BD79AD3B541A@eurprd07.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: eviden.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM8PR07MB7602.eurprd07.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 85d91a4d-d423-475c-3ff5-08dc6abca121 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 May 2024 15:29:16.8837 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7d1c7785-2d8a-437d-b842-1ed5d8fbe00a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Z8DOwWigbMDGLj4xN4StLBfzSumIWQ5LPimZH13ofL3g45AJwzo0TTmlZn3hJfHnL+CwFY/GX+tpIASbi5l/tSaOPj7XPrDh19SHjIqalBHXG5R9y5OCotT5XhLlNmQq X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR07MB9661 Received-SPF: pass client-ip=80.78.11.85; envelope-from=clement.mathieu--drif@eviden.com; helo=smarthost4.eviden.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The constant must be unsigned, otherwise the two's complement overrides the other fields when a PASID is present Signed-off-by: Clément Mathieu--Drif --- hw/i386/intel_iommu_internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/intel_iommu_internal.h b/hw/i386/intel_iommu_internal.h index c5efcff9fd..4f6b0154b5 100644 --- a/hw/i386/intel_iommu_internal.h +++ b/hw/i386/intel_iommu_internal.h @@ -271,7 +271,7 @@ /* For the low 64-bit of 128-bit */ #define VTD_FRCD_FI(val) ((val) & ~0xfffULL) #define VTD_FRCD_PV(val) (((val) & 0xffffULL) << 40) -#define VTD_FRCD_PP(val) (((val) & 0x1) << 31) +#define VTD_FRCD_PP(val) (((val) & 0x1ULL) << 31) #define VTD_FRCD_IR_IDX(val) (((val) & 0xffffULL) << 48) /* DMA Remapping Fault Conditions */