From patchwork Thu May 2 15:29:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: CLEMENT MATHIEU--DRIF X-Patchwork-Id: 1930653 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=eviden.com header.i=@eviden.com header.a=rsa-sha256 header.s=mail header.b=rEL1F/dA; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VVdGQ0GvLz23hd for ; Fri, 3 May 2024 01:32:14 +1000 (AEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s2YNt-000445-NN; Thu, 02 May 2024 11:30:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2YNl-0003xw-SY for qemu-devel@nongnu.org; Thu, 02 May 2024 11:30:01 -0400 Received: from smarthost4.eviden.com ([80.78.11.85]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2YNj-0005z0-TW for qemu-devel@nongnu.org; Thu, 02 May 2024 11:30:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eviden.com; i=@eviden.com; q=dns/txt; s=mail; t=1714663799; x=1746199799; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=utCfpqA582zPDO3rI6/KuwFYiXteNmSye6BL+9lf4fs=; b=rEL1F/dASthvxkmAFIsXLtejVF1w8V6Ylk7zAU55C4U44vNdIxfrgpMI CLEqbc18NdeNyktnd4UKqYO8GUVSQE4YMaQGG9/AWVZq9fS3IIuyztE4z 9Jw3/GVL+yGxFSsryNXrL+T1vQfDIkWvlWYz6tF5UeAaOSIMfhn3oV1NJ zZagEmWw5i8e0VuZOJ2pM/PjtyYKaifppdsKVC+L79RXx0klepJyI5wBB M0dc8rhscagdXA1j6/uMVUd1UenWBg1fO6WX/gJ/Wn7U42R13IvddRkSN FlbBjaeLEZaXSoqx6BD6juvt9P8cmqWULlRpBgBVr5gRoaonCud2wK6Ix w==; X-IronPort-AV: E=Sophos;i="6.07,247,1708383600"; d="scan'208";a="11785886" X-MGA-submission: MDHgAXYiiHTKaGc0ZQWAV4XE3sg4DQSnWvuU33SWiJM3P2QVUcJYNlD+7BWdz7dP24pjanX0AjmjF0jcwAsfyuxFKPx3iL7QOGqIAA/NXCTjfYdVxsXuGcPGyiiyn66cWXwNqgkP9sVXja7aZC7X0qZUzE2oiDF6h8DfxKyndWeuyQ== Received: from mail-db8eur05lp2104.outbound.protection.outlook.com (HELO EUR05-DB8-obe.outbound.protection.outlook.com) ([104.47.17.104]) by smarthost4.eviden.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 May 2024 17:29:22 +0200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XhH+uahRahSYoO8FehLbyrRTiohKjKg4eRpNVZ8Qeh5bAcvxrT9GH+va8YVaxTKIohS4MJG7UCr3s7qmhqF8TPKa8uLVrPfqWWB/JQWLb/VRXWbvxdCPtjjAe+Uz/gyJFyjDVfNWzfVwNzJbPPdbQFAe7VmtTdjCekv8VG/uPbvqCwKo0GF6VgdeJDIad4BCpnC0ims1RssrA3uXYfsBOBLyDLM/Eg/F847UupPMGYHsIUZ1QWeZAmwUHHRKJaz5looKxMgKSunINplVosIGROqnr2H2ZRzeDjwy8hSv9lLSkJvcElH/VXJFZqqpvdr+pxUnWzlDiv3gLUOLLPCzaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=utCfpqA582zPDO3rI6/KuwFYiXteNmSye6BL+9lf4fs=; b=mS2qGpdM7LMqSu2H4ob2PaLV66/HNeX0ajBvGH4idzTcN+QCkM0WGgr/HM67pKXtBXiEkm6+sXybdIX2D6S/lWmvf2/ihJn3SY1wVxjKow4ia6569DJ1joRSGS+hLaxhPzzMYHKc5Gzk+pyo9tznNM80YcJiigJpE0dhobsQS7BigrhvRaPQyMalDp8npmxsq58RBD3uTAySuVcmpc/hLOhQdRm++TL3ogFi1eJT2svRAKSqB4I7pKgKic/MUYLT/WZWWahflf98zp/i+VI5UpGkY13qPrvuKuZZjjOW98KEgeVDSKESyhD81pgOMY780d774kMr5BJihANfzS8Hsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=eviden.com; dmarc=pass action=none header.from=eviden.com; dkim=pass header.d=eviden.com; arc=none Received: from AM8PR07MB7602.eurprd07.prod.outlook.com (2603:10a6:20b:24b::7) by PAWPR07MB9661.eurprd07.prod.outlook.com (2603:10a6:102:389::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.29; Thu, 2 May 2024 15:29:19 +0000 Received: from AM8PR07MB7602.eurprd07.prod.outlook.com ([fe80::fbd7:ca71:b636:6f9d]) by AM8PR07MB7602.eurprd07.prod.outlook.com ([fe80::fbd7:ca71:b636:6f9d%4]) with mapi id 15.20.7519.035; Thu, 2 May 2024 15:29:19 +0000 From: CLEMENT MATHIEU--DRIF To: "qemu-devel@nongnu.org" CC: "jasowang@redhat.com" , "zhenzhong.duan@intel.com" , "kevin.tian@intel.com" , "yi.l.liu@intel.com" , "joao.m.martins@oracle.com" , "peterx@redhat.com" , CLEMENT MATHIEU--DRIF Subject: [PATCH ats_vtd v1 12/24] intel_iommu: add support for PASID-based device IOTLB invalidation Thread-Topic: [PATCH ats_vtd v1 12/24] intel_iommu: add support for PASID-based device IOTLB invalidation Thread-Index: AQHanKWAR9D3bMixykiyWgUWFlxu2A== Date: Thu, 2 May 2024 15:29:19 +0000 Message-ID: <20240502152810.187492-13-clement.mathieu--drif@eviden.com> References: <20240502152810.187492-1-clement.mathieu--drif@eviden.com> In-Reply-To: <20240502152810.187492-1-clement.mathieu--drif@eviden.com> Accept-Language: en-GB, fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=eviden.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM8PR07MB7602:EE_|PAWPR07MB9661:EE_ x-ms-office365-filtering-correlation-id: 7ca59488-8d39-4054-2f81-08dc6abca2aa x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|366007|1800799015|376005|38070700009; x-microsoft-antispam-message-info: =?utf-8?q?E++G3TCNiwZUy5zhXcwlBCy8nPdksFH?= =?utf-8?q?EoGvfu7P/R65s42SMm4mwSFIcD3EuC8N3apVNKSMz/XB6c+3dqtsJ1VS+n03IH65m?= =?utf-8?q?lDgX6YEf9n9uTXwh8Gdjy+tWAop9tvF5x2AuDIhrJyS4r2RT3m+pi1ZH1ihdOzZq1?= =?utf-8?q?Scu6cjx7DbdRjcUHFUyoEeLAIPiAENAxKoYMO7BOmsNntId1HjjjsUyRAJXNjva5v?= =?utf-8?q?9W3w3psiSRd6/vmSAO8dX1CZsHtpEi3XMTKTKpyoKay/bhPo3eZBRy4Shk4gboQZu?= =?utf-8?q?6byg2VXzpQH9v1zrfKfVrO4sQzIaAexUu0H8kZV05ymCyibrzEFWRcTDvsWxneWQQ?= =?utf-8?q?Vv4J/j4lcfhDW192mNJqYMdsSlj+flEAuI60h6lvTwwrdd699hNfTMxt1APbC/78Z?= =?utf-8?q?IXFBO/DeTMg7VoHtbCXh/+4qrjAP7kI2Whf2kteJ6zR526iVNhMPCJjbOkzrxydKU?= =?utf-8?q?i+f0rsaHouNVcxMs+mD1zW5qLC53XTvJK5B9rhFj1WEc4fuHw49u4/m1hVMKHG5cb?= =?utf-8?q?WmZ3OJSplhvSKKJS6BNTcV6bK6oPNSsBP+btAJg1SlMgINLHG5kO1k/McfARP45Vt?= =?utf-8?q?MJDpirTVskpFT5ASmuWoap9zfobOqemcVgF5VWw/4zk9ba8l3WNOWV5qFnjpRR3Zy?= =?utf-8?q?waclrS16lYvUCrLb97m20sVHsXpjGqCpsMDg78JCCFEahiaPQ8b8fNtYWnI+U8vh4?= =?utf-8?q?SuxO+FY2yoyg+ylAW3Hf5sEND4RN6oQ6ErTSSTEPiOG5oRkoWYNtbWJEAR9VUReAx?= =?utf-8?q?9zNUGI6d2O1s/YjzRDQfdsUyPaJBFS//BTDsFurCzo0XZdjAzPDoR8Gu+weJgy7C/?= =?utf-8?q?pBDGSlQ9w2KTxKxZbmBu/e+KUJGk907+X8fsNTzHNxMS2SIPX2hQnJOkJTB62d36z?= =?utf-8?q?SujB/Y0s3BzaycDJm0/ooVilJLtSQMq29ui4ttF5/U1EQiFrTMjC5p7u1TFl4Ejjn?= =?utf-8?q?dtEeGZfXI/e0FsdtwSiDFm+2OdriRW93DEY0kO4ZcTnImMvQr4Sx9i2bbAjF/jOY9?= =?utf-8?q?TsET5i2aV0ccy2NBqTfiL6ATmyLHZP3u3AyCrjfXSh/n1qhGwlJOu0W2suQgVCbct?= =?utf-8?q?1seNKZDP+tC0zxKdzYbwDm0LtoK1AjqsQmb+t+EXmREkQwDK50p+NNBCvLgM6eb+h?= =?utf-8?q?4f+bmG4pPQbuqWmrSNrOG5gyJDSwrTI6lyVbJRCOH8EZkkjtxKEQKzVxY+vbFnOsN?= =?utf-8?q?BEUmyxfojYnBLjlEu6Ru3Tmu9OkbXW/YxgCJliY0FgjCjohU6F08Z/3lGwBYGe0k0?= =?utf-8?q?77ua42xsX5pO7GGbDvb7nUwSUQWllw/JixQ=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM8PR07MB7602.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(1800799015)(376005)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?q?eFzhaQyVgQRKoGjafdAmVByGyizd?= =?utf-8?q?bR1v7OFBvjw1qsVAHrUiGcmWSnN7CWMxaZDQRqoYwpZBe4J2Eqw5pPalEHu/mabfh?= =?utf-8?q?aA8eKBr8IZoCGDw2TQrs2g5d4wvbPYjFyDVAcF8x+R9VK8uRfMIYizYoCTEgiDYUO?= =?utf-8?q?ZvKmch+btDwL2oN6u2u/QX8JXp60rsaNSOEpcZA/8lXG3NRcEExiuUCQ8TQJPWaMi?= =?utf-8?q?2VK8X9a1do9Q+DRiYTPtX76nNt+jP+sdRx7IRcHGnmHaES6bDTTUrVeMuKevGajFy?= =?utf-8?q?JIRDjMkAkSeZ03nNNd1fTJnH7fCImV+ku/krTucBVrgapVYOBkglvLy6szN6fIOYh?= =?utf-8?q?C1uYzIH74iS1+4IUNWWylUIWykY3wEFCRThwYxS3VZMusgP3OjuyO7cEDEhaauZwC?= =?utf-8?q?fKbugmSB3fr9ReRCNzsMelZg78P25VMZFMr57pH2l2mCA2u46+VTW92ggLwCWBV85?= =?utf-8?q?8v7TdxdjnaVmEyn5dFYLlq/uzjzl3Xsr9NRAefx1PIIeOU5DGZo982DAVyeyugAM/?= =?utf-8?q?a2QSzGUJ/NRe2fYjUpNB0jMpN94UzgV0KcvQYT6UyCcrr9RJt/sdYMnVO+K0v8YFr?= =?utf-8?q?8xa0F3oU3anRJRNWo3tWVFbdYcIUHJsAqit7RFk41qUm+UWAtSZn0qbqhOWqsGBb4?= =?utf-8?q?AAgOTpRIZQRew6/RbrXjfIsN0SFVhK1bl1xltoMdFXece+nr+6r8++Roja1Q/g/ty?= =?utf-8?q?7DQBhV+0Og7vzNzRO5JB5LxDEc2Uw84DJVWzUjxa9yBChYKncd2mbNiQ0EQb2RwPo?= =?utf-8?q?EgJx/FmsDGAfmYgcJSD52o+bYHNJIBIN+nZQZJfWij+FiaZY3j5v/D2Pdu32Yk56g?= =?utf-8?q?PV4VPIA8+YR+d7p7fWU1bQJ+5zg+cPQsfRB+VUpCDbEvURX8x0Xy9JDwTxPEv+PAb?= =?utf-8?q?OBDV5+RVDG8eZr9xYVy2S1pRUrav8HKaeCXZInrVej0RdcSsy/GDgf8It/8ImPZP8?= =?utf-8?q?U+RNbYCXQ7+EPmN8VCKTUsdwngbGmDORnRaTSdoKXrc5RseEXVPCMnqGmSvfYy0FV?= =?utf-8?q?wXiouqnrcRzYRa4RPBesyyolapPHnbkLa4lh10Xl/BIwhJwKQjLEqElZMvudSFUMp?= =?utf-8?q?6qtQNr2tQ90NAG4tgDz1+Gic6r+mk34g9fNgwuTOM+RVFYWuvYetBNy96ipx+DT0i?= =?utf-8?q?xH8y3lcewFupArSo0icbKK2slpNSCfkFoyH3xYEBobd2m/4sjmNcKoAUsl+d0W9TM?= =?utf-8?q?43HRRqvdhJnOz0/Qy0cviidwb3BTw8WC8DHB4DuzY+FRJYerwhJSftkp6xez99c5U?= =?utf-8?q?lYZEorrfWGQOaoUDnj1rzAGWBOKpnSdyR+CW0MRwuhQ9iZc3qv+MzPUsjelD3Z6L2?= =?utf-8?q?+Yh7HPVMX2cs1vWTfPHr4TsbPv0L/pTyztam6BCKvvUSwXnbtNIdApzqE4a+Sose9?= =?utf-8?q?Rcwy7uPQ/rl1IXVoWD4m0Pq0qkltTTb7RlL9kHRdS6HzAsVQGupA50obUqvciRhNC?= =?utf-8?q?P905FbJGQ0oCm1KzteZIu7/rnL9CJNByz/1vSTAzxuMcpAdqeZdO2z6ITwKGMXTMZ?= =?utf-8?q?GlYT9JNOFqQLxVcvgFXGgtO1Z0oZCCfCuL/UaFr4h8HbZgXA30K/kAs=3D?= Content-ID: <4038642DA5248349BEDC0B7947FA5F84@eurprd07.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: eviden.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM8PR07MB7602.eurprd07.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7ca59488-8d39-4054-2f81-08dc6abca2aa X-MS-Exchange-CrossTenant-originalarrivaltime: 02 May 2024 15:29:19.4281 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7d1c7785-2d8a-437d-b842-1ed5d8fbe00a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GjS89IZwGBRrhrh1aldwS0yoKiLnOpOpXO7RtvVWG+n/9qREPQOcd+hrJEmf9WJmo/Ez9L7Sdd4ocytWSmsUtkTVvSj88GfgS1/JJ3TaGBgxJ8OKYDFRDgmYYI/QU4g4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR07MB9661 Received-SPF: pass client-ip=80.78.11.85; envelope-from=clement.mathieu--drif@eviden.com; helo=smarthost4.eviden.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Clément Mathieu--Drif --- hw/i386/intel_iommu.c | 42 ++++++++++++++++++++++++++++++---- hw/i386/intel_iommu_internal.h | 10 ++++++++ 2 files changed, 47 insertions(+), 5 deletions(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index fe97930774..e7c1a5582a 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -4344,11 +4344,43 @@ static void do_invalidate_device_tlb(VTDAddressSpace *vtd_dev_as, static bool vtd_process_device_piotlb_desc(IntelIOMMUState *s, VTDInvDesc *inv_desc) { - /* - * no need to handle it for passthru device, for emulated - * devices with device tlb, it may be required, but for now, - * return is enough - */ + uint16_t sid; + VTDAddressSpace *vtd_dev_as; + bool size; + bool global; + hwaddr addr; + uint32_t pasid; + + if ((inv_desc->hi & VTD_INV_DESC_PASID_DEVICE_IOTLB_RSVD_HI) || + (inv_desc->lo & VTD_INV_DESC_PASID_DEVICE_IOTLB_RSVD_LO)) { + error_report_once("%s: invalid pasid-based dev iotlb inv desc:" + "hi=%"PRIx64 "(reserved nonzero)", + __func__, inv_desc->hi); + return false; + } + + global = VTD_INV_DESC_PASID_DEVICE_IOTLB_GLOBAL(inv_desc->hi); + size = VTD_INV_DESC_PASID_DEVICE_IOTLB_SIZE(inv_desc->hi); + addr = VTD_INV_DESC_PASID_DEVICE_IOTLB_ADDR(inv_desc->hi); + sid = VTD_INV_DESC_PASID_DEVICE_IOTLB_SID(inv_desc->lo); + if (global) { + QLIST_FOREACH(vtd_dev_as, &s->vtd_as_with_notifiers, next) { + if ((vtd_dev_as->pasid != PCI_NO_PASID) && + (PCI_BUILD_BDF(pci_bus_num(vtd_dev_as->bus), + vtd_dev_as->devfn) == sid)) { + do_invalidate_device_tlb(vtd_dev_as, size, addr); + } + } + } else { + pasid = VTD_INV_DESC_PASID_DEVICE_IOTLB_PASID(inv_desc->lo); + vtd_dev_as = vtd_get_as_by_sid_and_pasid(s, sid, pasid); + if (!vtd_dev_as) { + return true; + } + + do_invalidate_device_tlb(vtd_dev_as, size, addr); + } + return true; } diff --git a/hw/i386/intel_iommu_internal.h b/hw/i386/intel_iommu_internal.h index d63ff049a7..3d59e10488 100644 --- a/hw/i386/intel_iommu_internal.h +++ b/hw/i386/intel_iommu_internal.h @@ -424,6 +424,16 @@ typedef union VTDInvDesc VTDInvDesc; #define VTD_INV_DESC_DEVICE_IOTLB_RSVD_HI 0xffeULL #define VTD_INV_DESC_DEVICE_IOTLB_RSVD_LO 0xffff0000ffe0fff8 +/* Mask for PASID Device IOTLB Invalidate Descriptor */ +#define VTD_INV_DESC_PASID_DEVICE_IOTLB_ADDR(val) ((val) & \ + 0xfffffffffffff000ULL) +#define VTD_INV_DESC_PASID_DEVICE_IOTLB_SIZE(val) ((val >> 11) & 0x1) +#define VTD_INV_DESC_PASID_DEVICE_IOTLB_GLOBAL(val) ((val) & 0x1) +#define VTD_INV_DESC_PASID_DEVICE_IOTLB_SID(val) (((val) >> 16) & 0xffffULL) +#define VTD_INV_DESC_PASID_DEVICE_IOTLB_PASID(val) ((val >> 32) & 0xfffffULL) +#define VTD_INV_DESC_PASID_DEVICE_IOTLB_RSVD_HI 0x7feULL +#define VTD_INV_DESC_PASID_DEVICE_IOTLB_RSVD_LO 0xfff000000000f000ULL + /* Rsvd field masks for spte */ #define VTD_SPTE_SNP 0x800ULL