diff mbox series

[16/45] target/hppa: Always make a copy in do_ibranch_priv

Message ID	20240425000023.1002026-17-richard.henderson@linaro.org
State	New
Headers	show Return-Path: <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> From: Richard Henderson <richard.henderson@linaro.org> To: qemu-devel@nongnu.org Subject: [PATCH 16/45] target/hppa: Always make a copy in do_ibranch_priv Date: Wed, 24 Apr 2024 16:59:54 -0700 Message-Id: <20240425000023.1002026-17-richard.henderson@linaro.org> In-Reply-To: <20240425000023.1002026-1-richard.henderson@linaro.org> References: <20240425000023.1002026-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::635; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x635.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action Precedence: list Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org
Series	target/hppa: Misc improvements \| expand [00/45] target/hppa: Misc improvements [01/45] target/hppa: Move cpu_get_tb_cpu_state out of line [02/45] target/hppa: Use hppa_form_gva_psw in hppa_cpu_get_pc [03/45] target/hppa: Move constant destination check into use_goto_tb [04/45] target/hppa: Pass displacement to do_dbranch [05/45] target/hppa: Allow prior nullification in do_ibranch [06/45] target/hppa: Use CF_BP_PAGE instead of cpu_breakpoint_test [07/45] target/hppa: Add install_iaq_entries [08/45] target/hppa: Add install_link [09/45] target/hppa: Delay computation of IAQ_Next [10/45] target/hppa: Skip nullified insns in unconditional dbranch path [11/45] target/hppa: Simplify TB end [12/45] target/hppa: Add IASQ entries to DisasContext [13/45] target/hppa: Add space arguments to install_iaq_entries [14/45] target/hppa: Add space argument to do_ibranch [15/45] target/hppa: Use umax in do_ibranch_priv [16/45] target/hppa: Always make a copy in do_ibranch_priv [17/45] target/hppa: Introduce and use DisasIAQE for branch management [18/45] target/hppa: Use displacements in DisasIAQE [19/45] target/hppa: Rename cond_make_* helpers [20/45] target/hppa: Use TCG_COND_TST* in do_cond [21/45] target/hppa: Use TCG_COND_TST* in do_log_cond [22/45] target/hppa: Use TCG_COND_TST* in do_unit_zero_cond [23/45] target/hppa: Use TCG_COND_TST* in do_unit_addsub [24/45] target/hppa: Use TCG_COND_TST* in trans_bb_imm [25/45] target/hppa: Use registerfields.h for FPSR [26/45] target/hppa: Use TCG_COND_TST* in trans_ftest [27/45] target/hppa: Remove cond_free [28/45] target/hppa: Introduce DisasDelayException [29/45] target/hppa: Use delay_excp for conditional traps [30/45] target/hppa: Use delay_excp for conditional trap on overflow [31/45] linux-user/hppa: Force all code addresses to PRIV_USER [32/45] target/hppa: Store full iaoq_f and page bits of iaoq_d in TB [33/45] target/hppa: Do not mask in copy_iaoq_entry [34/45] target/hppa: Improve hppa_cpu_dump_state [35/45] target/hppa: Split PSW X and B into their own field [36/45] target/hppa: Manage PSW_X and PSW_B in translator [37/45] target/hppa: Implement PSW_B [38/45] target/hppa: Implement PSW_X [39/45] target/hppa: Drop tlb_entry return from hppa_get_physical_address [40/45] target/hppa: Adjust priv for B,GATE at runtime [41/45] target/hppa: Implement CF_PCREL [42/45] target/hppa: Implement PSW_T [43/45] target/hppa: Implement PSW_H, PSW_L [44/45] target/hppa: Log cpu state at interrupt [45/45] target/hppa: Log cpu state on return-from-interrupt

Commit Message

Richard Henderson April 24, 2024, 11:59 p.m. UTC

This simplifies callers, which might otherwise have
to make another copy.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/hppa/translate.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff mbox series

Patch

diff --git a/target/hppa/translate.c b/target/hppa/translate.c
index 7e01c21141..dd5193cb6a 100644
--- a/target/hppa/translate.c
+++ b/target/hppa/translate.c
@@ -1966,18 +1966,17 @@  static bool do_ibranch(DisasContext *ctx, TCGv_i64 dest, TCGv_i64 dspc,
  */
 static TCGv_i64 do_ibranch_priv(DisasContext *ctx, TCGv_i64 offset)
 {
-    TCGv_i64 dest;
+    TCGv_i64 dest = tcg_temp_new_i64();
     switch (ctx->privilege) {
     case 0:
         /* Privilege 0 is maximum and is allowed to decrease.  */
-        return offset;
+        tcg_gen_mov_i64(dest, offset);
+        break;
     case 3:
         /* Privilege 3 is minimum and is never allowed to increase.  */
-        dest = tcg_temp_new_i64();
         tcg_gen_ori_i64(dest, offset, 3);
         break;
     default:
-        dest = tcg_temp_new_i64();
         tcg_gen_andi_i64(dest, offset, -4);
         tcg_gen_ori_i64(dest, dest, ctx->privilege);
         tcg_gen_umax_i64(dest, dest, offset);