| Message ID | 20240307164835.300412-10-gaosong@loongson.cn |
|---|---|
| State | New |
| Headers | show |
| Series | Add boot LoongArch elf kernel with FDT | expand |
On 2024/3/8 上午12:48, Song Gao wrote: > The right fdt memory node like [1], not [2] > > [1] > memory@0 { > device_type = "memory"; > reg = <0x00 0x00 0x00 0x10000000>; > }; > [2] > memory@0 { > device_type = "memory"; > reg = <0x02 0x00 0x02 0x10000000>; > }; > > Reviewed-by: Bibo Mao <maobibo@loongson.cn> > Signed-off-by: Song Gao <gaosong@loongson.cn> > Message-Id: <20240301093839.663947-10-gaosong@loongson.cn> > --- > hw/loongarch/virt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c > index 8981b57b12..10fdfec5dd 100644 > --- a/hw/loongarch/virt.c > +++ b/hw/loongarch/virt.c > @@ -325,7 +325,7 @@ static void fdt_add_memory_node(MachineState *ms, > char *nodename = g_strdup_printf("/memory@%" PRIx64, base); > > qemu_fdt_add_subnode(ms->fdt, nodename); > - qemu_fdt_setprop_cells(ms->fdt, nodename, "reg", 2, base, 2, size); > + qemu_fdt_setprop_cells(ms->fdt, nodename, "reg", 0, base, 0, size); > qemu_fdt_setprop_string(ms->fdt, nodename, "device_type", "memory"); > > if (ms->numa_state && ms->numa_state->num_nodes) { > Reviewed-by: Bibo Mao <maobibo@loongson.cn>
diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c index 8981b57b12..10fdfec5dd 100644 --- a/hw/loongarch/virt.c +++ b/hw/loongarch/virt.c @@ -325,7 +325,7 @@ static void fdt_add_memory_node(MachineState *ms, char *nodename = g_strdup_printf("/memory@%" PRIx64, base); qemu_fdt_add_subnode(ms->fdt, nodename); - qemu_fdt_setprop_cells(ms->fdt, nodename, "reg", 2, base, 2, size); + qemu_fdt_setprop_cells(ms->fdt, nodename, "reg", 0, base, 0, size); qemu_fdt_setprop_string(ms->fdt, nodename, "device_type", "memory"); if (ms->numa_state && ms->numa_state->num_nodes) {
The right fdt memory node like [1], not [2] [1] memory@0 { device_type = "memory"; reg = <0x00 0x00 0x00 0x10000000>; }; [2] memory@0 { device_type = "memory"; reg = <0x02 0x00 0x02 0x10000000>; }; Reviewed-by: Bibo Mao <maobibo@loongson.cn> Signed-off-by: Song Gao <gaosong@loongson.cn> Message-Id: <20240301093839.663947-10-gaosong@loongson.cn> --- hw/loongarch/virt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)