| Message ID | 20240203080228.2766159-5-armbru@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | char: Minor fixes, and a tighter QAPI schema | expand |
On a Saturday in 2024, Markus Armbruster wrote: >It's an alias for "ringbuf" we kept for backward compatibility; see >commit 3a1da42eb35 (qapi: Rename ChardevBackend member "memory" to >"ringbuf"). Deprecation is long overdue. > >Signed-off-by: Markus Armbruster <armbru@redhat.com> >--- > docs/about/deprecated.rst | 8 ++++++++ > qapi/char.json | 8 +++++--- > 2 files changed, 13 insertions(+), 3 deletions(-) > >diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst >index d4492b9460..ae1a520c26 100644 >--- a/docs/about/deprecated.rst >+++ b/docs/about/deprecated.rst >@@ -371,6 +371,14 @@ Specifying the iSCSI password in plain text on the command line using the > used instead, to refer to a ``--object secret...`` instance that provides > a password via a file, or encrypted. > >+Character device options >+'''''''''''''''''''''''' >+ >+Backend ``memory`` (since 9.0) >+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >+ >+``memory`` is a deprecated synonym for ``ringbuf``. >+ For libvirt: Reviewed-by: Ján Tomko <jtomko@redhat.com> (We don't support either of those) Jano
On Sat, Feb 03, 2024 at 09:02:28AM +0100, Markus Armbruster wrote: > It's an alias for "ringbuf" we kept for backward compatibility; see > commit 3a1da42eb35 (qapi: Rename ChardevBackend member "memory" to > "ringbuf"). Deprecation is long overdue. > > Signed-off-by: Markus Armbruster <armbru@redhat.com> > --- > docs/about/deprecated.rst | 8 ++++++++ > qapi/char.json | 8 +++++--- > 2 files changed, 13 insertions(+), 3 deletions(-) Reviewed-by: Eric Blake <eblake@redhat.com>
diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index d4492b9460..ae1a520c26 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -371,6 +371,14 @@ Specifying the iSCSI password in plain text on the command line using the used instead, to refer to a ``--object secret...`` instance that provides a password via a file, or encrypted. +Character device options +'''''''''''''''''''''''' + +Backend ``memory`` (since 9.0) +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ + +``memory`` is a deprecated synonym for ``ringbuf``. + CPU device properties ''''''''''''''''''''' diff --git a/qapi/char.json b/qapi/char.json index 2d74e66746..75a7e057f0 100644 --- a/qapi/char.json +++ b/qapi/char.json @@ -468,6 +468,10 @@ # # @memory: Since 1.5 # +# Features: +# +# @deprecated: Member @memory is deprecated. Use @ringbuf instead. +# # Since: 1.4 ## { 'enum': 'ChardevBackendKind', @@ -492,8 +496,7 @@ { 'name': 'dbus', 'if': 'CONFIG_DBUS_DISPLAY' }, 'vc', 'ringbuf', - # next one is just for compatibility - 'memory' ] } + { 'name': 'memory', 'features': [ 'deprecated' ] } ] } ## # @ChardevFileWrapper: @@ -642,7 +645,6 @@ 'if': 'CONFIG_DBUS_DISPLAY' }, 'vc': 'ChardevVCWrapper', 'ringbuf': 'ChardevRingbufWrapper', - # next one is just for compatibility 'memory': 'ChardevRingbufWrapper' } } ##
It's an alias for "ringbuf" we kept for backward compatibility; see commit 3a1da42eb35 (qapi: Rename ChardevBackend member "memory" to "ringbuf"). Deprecation is long overdue. Signed-off-by: Markus Armbruster <armbru@redhat.com> --- docs/about/deprecated.rst | 8 ++++++++ qapi/char.json | 8 +++++--- 2 files changed, 13 insertions(+), 3 deletions(-)