diff mbox series

tests/avocado: improve flaky ppc/pnv boot_linux_console.py test

Message ID 20240124060134.406331-1-npiggin@gmail.com
State New
Headers show
Series tests/avocado: improve flaky ppc/pnv boot_linux_console.py test | expand

Commit Message

Nicholas Piggin Jan. 24, 2024, 6:01 a.m. UTC
The expected MTD partition detection output does not always appear on
the console, despite the test reaching the boot loader and the string
appearing in dmesg. Possibly due to an init script that quietens the
console output. Using an earlier log message improves reliability.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
 tests/avocado/boot_linux_console.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Cédric Le Goater Jan. 25, 2024, 9:23 a.m. UTC | #1
On 1/24/24 07:01, Nicholas Piggin wrote:
> The expected MTD partition detection output does not always appear on
> the console, despite the test reaching the boot loader and the string
> appearing in dmesg. Possibly due to an init script that quietens the
> console output. Using an earlier log message improves reliability.
> 
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> ---
>   tests/avocado/boot_linux_console.py | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/avocado/boot_linux_console.py b/tests/avocado/boot_linux_console.py
> index 3f0180e1f8..922a9e7b79 100644
> --- a/tests/avocado/boot_linux_console.py
> +++ b/tests/avocado/boot_linux_console.py
> @@ -1368,7 +1368,9 @@ def do_test_ppc64_powernv(self, proc):
>           self.wait_for_console_pattern("CPU: " + proc + " generation processor")
>           self.wait_for_console_pattern("zImage starting: loaded")
>           self.wait_for_console_pattern("Run /init as init process")
> -        self.wait_for_console_pattern("Creating 1 MTD partitions")
> +        self.wait_for_console_pattern("rtc-opal opal-rtc: setting system clock")
> +        # MTD partition detection output is sometimes cut off from console
> +        # output, suspect S14silence-console init script.
>   
>       def test_ppc_powernv8(self):
>           """



Reviewed-by: Cédric Le Goater <clg@kaod.org>

Thanks,

C.
diff mbox series

Patch

diff --git a/tests/avocado/boot_linux_console.py b/tests/avocado/boot_linux_console.py
index 3f0180e1f8..922a9e7b79 100644
--- a/tests/avocado/boot_linux_console.py
+++ b/tests/avocado/boot_linux_console.py
@@ -1368,7 +1368,9 @@  def do_test_ppc64_powernv(self, proc):
         self.wait_for_console_pattern("CPU: " + proc + " generation processor")
         self.wait_for_console_pattern("zImage starting: loaded")
         self.wait_for_console_pattern("Run /init as init process")
-        self.wait_for_console_pattern("Creating 1 MTD partitions")
+        self.wait_for_console_pattern("rtc-opal opal-rtc: setting system clock")
+        # MTD partition detection output is sometimes cut off from console
+        # output, suspect S14silence-console init script.
 
     def test_ppc_powernv8(self):
         """