From patchwork Fri Jan 19 23:22:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 1888700 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=AVG43C1V; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TGwgL5Ndyz1yPJ for ; Sat, 20 Jan 2024 10:24:30 +1100 (AEDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rQyCb-0000Sx-OW; Fri, 19 Jan 2024 18:23:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQyCZ-0000Sl-Ea for qemu-devel@nongnu.org; Fri, 19 Jan 2024 18:23:07 -0500 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rQyCX-0008FH-Pv for qemu-devel@nongnu.org; Fri, 19 Jan 2024 18:23:07 -0500 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-40e9d288f45so13731585e9.2 for ; Fri, 19 Jan 2024 15:23:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1705706584; x=1706311384; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZsZYTBqcxLmUzApr+Hi9hM5A3V+n1o4VvJJUuDY59oo=; b=AVG43C1VzC+CJpA+UzLg5L7YxHzFu7AR+1N6sz0diEPtrVGoeIknGmfkAUPGiOXV8O f94Y4HlCrXvCtXLK/dvcrwfZ/IDGnBxvkgQ0t09GaNsCfZHoigwckOm3kHobMqpTlZf2 wzSGzCo/Eq9INPBGA1C3ci2N/G1pziW3UmzChawUYcx9iSU5FavELU4vds0hmImX+RYL O0nY1NaKTafU0K5xnqJCRPZqpnRMqDjPNOQuLuuzgsTPm7WfzOSeqDzGSAyYIKGkSFcr Objwv04rEG5g/KqSfOqOT83or3EyMU48hbA6VBXF1SgL7+emMpMofoYKUohM+7URxGmJ OVEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705706584; x=1706311384; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZsZYTBqcxLmUzApr+Hi9hM5A3V+n1o4VvJJUuDY59oo=; b=qUGQq7g8aduMT8IHFMD5VGR1xw3EbVmIdD3uhQT3xhWn22DEsxAXWnO1goqrZjL/c+ Xu1HUS0bEdTgpD78JEIQlw6Lpra6Ec1gWaUnNtFXdbQQ+7vKZeaCgGQ3927zOUi832V4 pdto52ftc1fUdggA9SUwtgZovZ5i04LatZFoZWVy+TZXbVSQSN0h46q69gpfncIhTFUK hQ4VzDeOiphRSMu51o1Gewnswy1n4o7TxChrYiydTfGwK6fI1uNbBCrO1riDNayt4/Ae BZNZJnre6LDVRcqGYhW3qnVZeT/d+bg35AOybCXD7/JNqsbfrfUsfA9cV7RVZRlcTto8 FGww== X-Gm-Message-State: AOJu0YxiEoxZGczYv2ucJd9vntTaJGG3fGt/x1lI7UZ8yCI4wr3cKjPG lTZ+CA/xyY075YLvVYcj2X6tsTZsLMrdLuFM+798kDLrFDGgskXHYoIDU3kX3qhPzBxnbkYjPCO 1 X-Google-Smtp-Source: AGHT+IHnOyg7WaXMyVv5J0j8KfIgRRyTakftuc2kcF0YmtOyUp09ScQk3ol6S5mlylcKFJr9X5ZGyg== X-Received: by 2002:a05:600c:3106:b0:40d:88a8:f89 with SMTP id g6-20020a05600c310600b0040d88a80f89mr182327wmo.149.1705706584014; Fri, 19 Jan 2024 15:23:04 -0800 (PST) Received: from localhost.localdomain (91-163-26-170.subs.proxad.net. [91.163.26.170]) by smtp.gmail.com with ESMTPSA id n15-20020a05600c3b8f00b0040d5a5c523csm34589474wms.1.2024.01.19.15.23.03 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 19 Jan 2024 15:23:03 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , David Hildenbrand , Thomas Huth , qemu-s390x@nongnu.org, Ilya Leoshkevich , =?utf-8?q?Phil?= =?utf-8?q?ippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v3 15/38 1/6] target/s390x: Reorder CC_OP_STATIC switch case in disas_jcc (1/5) Date: Sat, 20 Jan 2024 00:22:57 +0100 Message-ID: <20240119232302.50393-1-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240110224408.10444-16-richard.henderson@linaro.org> References: <20240110224408.10444-16-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=philmd@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Code movement to ease review, no logical change. Signed-off-by: Philippe Mathieu-Daudé --- target/s390x/tcg/translate.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c index 2897880d88..e84c6459f0 100644 --- a/target/s390x/tcg/translate.c +++ b/target/s390x/tcg/translate.c @@ -916,6 +916,10 @@ static void disas_jcc(DisasContext *s, DisasCompare *c, uint32_t mask) cond = TCG_COND_NE; c->u.s32.b = tcg_constant_i32(0); break; + case 0x2 | 0x1: /* cc > 1 */ + cond = TCG_COND_GTU; + c->u.s32.b = tcg_constant_i32(1); + break; case 0x4 | 0x1: /* cc == 1 || cc == 3 => (cc & 1) != 0 */ cond = TCG_COND_NE; c->u.s32.a = tcg_temp_new_i32(); @@ -926,10 +930,6 @@ static void disas_jcc(DisasContext *s, DisasCompare *c, uint32_t mask) cond = TCG_COND_EQ; c->u.s32.b = tcg_constant_i32(1); break; - case 0x2 | 0x1: /* cc > 1 */ - cond = TCG_COND_GTU; - c->u.s32.b = tcg_constant_i32(1); - break; case 0x2: /* cc == 2 */ cond = TCG_COND_EQ; c->u.s32.b = tcg_constant_i32(2);