@@ -1293,6 +1293,9 @@ static void migrate_fd_cleanup(MigrationState *s)
QEMUFile *tmp;
trace_migrate_fd_cleanup();
+
+ multifd_save_cleanup();
+
qemu_mutex_unlock_iothread();
if (s->migration_thread_running) {
qemu_thread_join(&s->thread);
@@ -1300,7 +1303,6 @@ static void migrate_fd_cleanup(MigrationState *s)
}
qemu_mutex_lock_iothread();
- multifd_save_cleanup();
qemu_mutex_lock(&s->qemu_file_lock);
tmp = s->to_dst_file;
s->to_dst_file = NULL;
@@ -531,6 +531,15 @@ void multifd_save_cleanup(void)
if (p->thread) {
qemu_thread_join(p->thread);
+ } else {
+ /*
+ * The migration thread might be waiting on these. It is
+ * the responsibility of the channel thread to release
+ * them, unless it has never been created, then do it
+ * here.
+ */
+ qemu_sem_post(&p->sem_sync);
+ qemu_sem_post(&multifd_send_state->channels_ready);
}
}
for (i = 0; i < migrate_multifd_channels(); i++) {
@@ -784,20 +793,15 @@ static void multifd_tls_outgoing_handshake(QIOTask *task,
if (!qio_task_propagate_error(task, &err)) {
trace_multifd_tls_outgoing_handshake_complete(ioc);
- if (multifd_channel_connect(p, ioc, &err)) {
- return;
- }
+ multifd_channel_connect(p, ioc, &error_abort);
+ } else {
+ /*
+ * The multifd client could already be waiting to queue data,
+ * so let it know that we didn't even start.
+ */
+ p->quit = true;
+ trace_multifd_tls_outgoing_handshake_error(ioc, error_get_pretty(err));
}
-
- trace_multifd_tls_outgoing_handshake_error(ioc, error_get_pretty(err));
-
- /*
- * Error happen, mark multifd_send_thread status as 'quit' although it
- * is not created, and then tell who pay attention to me.
- */
- p->quit = true;
- qemu_sem_post(&multifd_send_state->channels_ready);
- qemu_sem_post(&p->sem_sync);
}
static void *multifd_tls_handshake_thread(void *opaque)
@@ -870,9 +874,6 @@ static void multifd_new_send_channel_cleanup(MultiFDSendParams *p,
QIOChannel *ioc, Error *err)
{
migrate_set_error(migrate_get_current(), err);
- /* Error happen, we need to tell who pay attention to me */
- qemu_sem_post(&multifd_send_state->channels_ready);
- qemu_sem_post(&p->sem_sync);
/*
* Although multifd_send_thread is not created, but main migration
* thread need to judge whether it is running, so we need to mark
We cannot operate on the multifd semaphores outside of the multifd channel thread because multifd_save_cleanup() can run in parallel and attempt to destroy the mutexes, which causes an assert. Looking at the places where we use the semaphores aside from the migration thread, there's only the TLS handshake thread and the initial multifd_channel_connect() in the main thread. These are places where creating the multifd channel cannot fail, so releasing the semaphores at these places only serves the purpose of avoiding a deadlock when an error happens before the channel(s) have started, but after the migration thread has already called multifd_send_sync_main(). Instead of attempting to release the semaphores at those places, move the release into multifd_save_cleanup(). This puts the semaphore usage in the same thread that does the cleanup, eliminating the race. Move the call to multifd_save_cleanup() before joining the migration thread so we release the semaphores before and avoid deadlock. Signed-off-by: Fabiano Rosas <farosas@suse.de> --- migration/migration.c | 4 +++- migration/multifd.c | 33 +++++++++++++++++---------------- 2 files changed, 20 insertions(+), 17 deletions(-)