diff mbox series

[1/4] macfb: don't clear interrupts when writing to DAFB_RESET

Message ID 20231026085650.917663-2-mark.cave-ayland@ilande.co.uk
State New
Headers show
Series macfb: A/UX fixes for colour LUT | expand

Commit Message

Mark Cave-Ayland Oct. 26, 2023, 8:56 a.m. UTC 
Traces from A/UX suggest that this register is only used to reset the framebuffer
LUT (colour lookup table) and not any other device state.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
---
 hw/display/macfb.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Laurent Vivier Nov. 5, 2023, 2:42 p.m. UTC | #1 
Le 26/10/2023 à 10:56, Mark Cave-Ayland a écrit :
> Traces from A/UX suggest that this register is only used to reset the framebuffer
> LUT (colour lookup table) and not any other device state.
> 
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
>   hw/display/macfb.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/hw/display/macfb.c b/hw/display/macfb.c
> index 2f8e016566..28db2e9f24 100644
> --- a/hw/display/macfb.c
> +++ b/hw/display/macfb.c
> @@ -585,8 +585,6 @@ static void macfb_ctrl_write(void *opaque,
>           break;
>       case DAFB_RESET:
>           s->palette_current = 0;
> -        s->regs[DAFB_INTR_STAT >> 2] &= ~DAFB_INTR_VBL;
> -        macfb_update_irq(s);
>           break;
>       case DAFB_LUT:
>           s->color_palette[s->palette_current] = val;

Reviewed-by: Laurent Vivier <laurent@vivier.eu>
diff mbox series

Patch

diff --git a/hw/display/macfb.c b/hw/display/macfb.c
index 2f8e016566..28db2e9f24 100644
--- a/hw/display/macfb.c
+++ b/hw/display/macfb.c
@@ -585,8 +585,6 @@  static void macfb_ctrl_write(void *opaque,
         break;
     case DAFB_RESET:
         s->palette_current = 0;
-        s->regs[DAFB_INTR_STAT >> 2] &= ~DAFB_INTR_VBL;
-        macfb_update_irq(s);
         break;
     case DAFB_LUT:
         s->color_palette[s->palette_current] = val;