| Message ID | 20230928132019.2544702-52-armbru@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | migration/rdma: Error handling fixes | expand |
Markus Armbruster <armbru@redhat.com> writes: > Functions that use an Error **errp parameter to return errors should > not also report them to the user, because reporting is the caller's > job. When the caller does, the error is reported twice. When it > doesn't (because it recovered from the error), there is no error to > report, i.e. the report is bogus. > > qemu_rdma_source_init(), qemu_rdma_connect(), > rdma_start_incoming_migration(), and rdma_start_outgoing_migration() > violate this principle: they call error_report() via > qemu_rdma_cleanup(). > > Moreover, qemu_rdma_cleanup() can't fail. It is called on error > paths, and QIOChannel close and finalization. Are the conditions it > reports really errors? I doubt it. > > Downgrade qemu_rdma_cleanup()'s errors to warnings. > > Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Fabiano Rosas <farosas@suse.de>
Markus Armbruster <armbru@redhat.com> wrote: > Functions that use an Error **errp parameter to return errors should > not also report them to the user, because reporting is the caller's > job. When the caller does, the error is reported twice. When it > doesn't (because it recovered from the error), there is no error to > report, i.e. the report is bogus. > > qemu_rdma_source_init(), qemu_rdma_connect(), > rdma_start_incoming_migration(), and rdma_start_outgoing_migration() > violate this principle: they call error_report() via > qemu_rdma_cleanup(). > > Moreover, qemu_rdma_cleanup() can't fail. It is called on error > paths, and QIOChannel close and finalization. Are the conditions it > reports really errors? I doubt it. > > Downgrade qemu_rdma_cleanup()'s errors to warnings. > > Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Juan Quintela <quintela@redhat.com>
On 28/09/2023 21:20, Markus Armbruster wrote: > Functions that use an Error **errp parameter to return errors should > not also report them to the user, because reporting is the caller's > job. When the caller does, the error is reported twice. When it > doesn't (because it recovered from the error), there is no error to > report, i.e. the report is bogus. > > qemu_rdma_source_init(), qemu_rdma_connect(), > rdma_start_incoming_migration(), and rdma_start_outgoing_migration() > violate this principle: they call error_report() via > qemu_rdma_cleanup(). > > Moreover, qemu_rdma_cleanup() can't fail. It is called on error > paths, and QIOChannel close and finalization. Are the conditions it > reports really errors? I doubt it. > > Downgrade qemu_rdma_cleanup()'s errors to warnings. > > Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Li Zhijian <lizhijian@fujitsu.com> > --- > migration/rdma.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/migration/rdma.c b/migration/rdma.c > index 4e4d818460..54b59d12b1 100644 > --- a/migration/rdma.c > +++ b/migration/rdma.c > @@ -2358,9 +2358,9 @@ static void qemu_rdma_cleanup(RDMAContext *rdma) > .type = RDMA_CONTROL_ERROR, > .repeat = 1, > }; > - error_report("Early error. Sending error."); > + warn_report("Early error. Sending error."); > if (qemu_rdma_post_send_control(rdma, NULL, &head, &err) < 0) { > - error_report_err(err); > + warn_report_err(err); > } > } >
diff --git a/migration/rdma.c b/migration/rdma.c index 4e4d818460..54b59d12b1 100644 --- a/migration/rdma.c +++ b/migration/rdma.c @@ -2358,9 +2358,9 @@ static void qemu_rdma_cleanup(RDMAContext *rdma) .type = RDMA_CONTROL_ERROR, .repeat = 1, }; - error_report("Early error. Sending error."); + warn_report("Early error. Sending error."); if (qemu_rdma_post_send_control(rdma, NULL, &head, &err) < 0) { - error_report_err(err); + warn_report_err(err); } }
Functions that use an Error **errp parameter to return errors should not also report them to the user, because reporting is the caller's job. When the caller does, the error is reported twice. When it doesn't (because it recovered from the error), there is no error to report, i.e. the report is bogus. qemu_rdma_source_init(), qemu_rdma_connect(), rdma_start_incoming_migration(), and rdma_start_outgoing_migration() violate this principle: they call error_report() via qemu_rdma_cleanup(). Moreover, qemu_rdma_cleanup() can't fail. It is called on error paths, and QIOChannel close and finalization. Are the conditions it reports really errors? I doubt it. Downgrade qemu_rdma_cleanup()'s errors to warnings. Signed-off-by: Markus Armbruster <armbru@redhat.com> --- migration/rdma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)