| Message ID | 20230828112651.522058-6-kbastian@mail.uni-paderborn.de |
|---|---|
| State | New |
| Headers | show |
| Series | TriCore 1.6.2 insn and bugfixes | expand |
On 8/28/23 04:26, Bastian Koppelmann wrote: > this is not something other ISAs do, so clarify it with a comment. > > Signed-off-by: Bastian Koppelmann<kbastian@mail.uni-paderborn.de> > --- > target/tricore/fpu_helper.c | 5 +++++ > 1 file changed, 5 insertions(+) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/target/tricore/fpu_helper.c b/target/tricore/fpu_helper.c index 3aefeb776e..d0c474c5f3 100644 --- a/target/tricore/fpu_helper.c +++ b/target/tricore/fpu_helper.c @@ -475,6 +475,11 @@ uint32_t helper_ftouz(CPUTriCoreState *env, uint32_t arg) if (float32_is_any_nan(f_arg)) { result = 0; } + /* + * we need to check arg < 0.0 before rounding as TriCore needs to raise + * float_flag_invalid as well. For instance, when we have a negative + * exponent and sign, softfloat would only raise float_flat_inexact. + */ } else if (float32_lt_quiet(f_arg, 0, &env->fp_status)) { flags = float_flag_invalid; result = 0;
this is not something other ISAs do, so clarify it with a comment. Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de> --- target/tricore/fpu_helper.c | 5 +++++ 1 file changed, 5 insertions(+)