diff mbox series

scripts: remove dead file

Message ID 20230603214342.471752-1-pbonzini@redhat.com
State New
Headers show
Series scripts: remove dead file | expand

Commit Message

Paolo Bonzini June 3, 2023, 9:43 p.m. UTC
scripts/test-driver.py was used when "make check" was already using meson
introspection data, but it did not execute "meson test".  It is dead since
commit 3d2f73ef75e ("build: use "meson test" as the test harness", 2021-12-23).

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 scripts/test-driver.py | 35 -----------------------------------
 1 file changed, 35 deletions(-)
 delete mode 100644 scripts/test-driver.py

Comments

Richard Henderson June 3, 2023, 10:04 p.m. UTC | #1
On 6/3/23 14:43, Paolo Bonzini wrote:
> scripts/test-driver.py was used when "make check" was already using meson
> introspection data, but it did not execute "meson test".  It is dead since
> commit 3d2f73ef75e ("build: use "meson test" as the test harness", 2021-12-23).
> 
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
> ---
>   scripts/test-driver.py | 35 -----------------------------------
>   1 file changed, 35 deletions(-)
>   delete mode 100644 scripts/test-driver.py

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~
Philippe Mathieu-Daudé June 5, 2023, 10:04 a.m. UTC | #2
On 3/6/23 23:43, Paolo Bonzini wrote:
> scripts/test-driver.py was used when "make check" was already using meson
> introspection data, but it did not execute "meson test".  It is dead since
> commit 3d2f73ef75e ("build: use "meson test" as the test harness", 2021-12-23).
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   scripts/test-driver.py | 35 -----------------------------------
>   1 file changed, 35 deletions(-)
>   delete mode 100644 scripts/test-driver.py

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff mbox series

Patch

diff --git a/scripts/test-driver.py b/scripts/test-driver.py
deleted file mode 100644
index eef74b29a8f..00000000000
--- a/scripts/test-driver.py
+++ /dev/null
@@ -1,35 +0,0 @@ 
-#! /usr/bin/env python3
-
-# Wrapper for tests that hides the output if they succeed.
-# Used by "make check"
-#
-# Copyright (C) 2020 Red Hat, Inc.
-#
-# Author: Paolo Bonzini <pbonzini@redhat.com>
-
-import subprocess
-import sys
-import os
-import argparse
-
-parser = argparse.ArgumentParser(description='Test driver for QEMU')
-parser.add_argument('-C', metavar='DIR', dest='dir', default='.',
-                    help='change to DIR before doing anything else')
-parser.add_argument('-v', '--verbose', dest='verbose', action='store_true',
-                    help='be more verbose')
-parser.add_argument('test_args', nargs=argparse.REMAINDER)
-
-args = parser.parse_args()
-os.chdir(args.dir)
-
-test_args = args.test_args
-if test_args[0] == '--':
-    test_args = test_args[1:]
-
-if args.verbose:
-    result = subprocess.run(test_args, stdout=None, stderr=None)
-else:
-    result = subprocess.run(test_args, stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
-    if result.returncode:
-        sys.stdout.buffer.write(result.stdout)
-sys.exit(result.returncode)