diff mbox series

hw/ppc/Kconfig: MAC_NEWWORLD should always select USB_OHCI_PCI

Message ID 20230530102041.55527-1-thuth@redhat.com
State New
Headers show
Series hw/ppc/Kconfig: MAC_NEWWORLD should always select USB_OHCI_PCI | expand

Commit Message

Thomas Huth May 30, 2023, 10:20 a.m. UTC
The PowerMacs have an OHCI controller soldered on the motherboard,
so this should always be enabled for the "mac99" machine.
This fixes the problem that QEMU aborts when the user tries to run
the "mac99" machine with a build that has been compiled with the
"--without-default-devices" configure switch.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 hw/ppc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Philippe Mathieu-Daudé May 30, 2023, 10:43 a.m. UTC | #1
On 30/5/23 12:20, Thomas Huth wrote:
> The PowerMacs have an OHCI controller soldered on the motherboard,
> so this should always be enabled for the "mac99" machine.
> This fixes the problem that QEMU aborts when the user tries to run
> the "mac99" machine with a build that has been compiled with the
> "--without-default-devices" configure switch.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   hw/ppc/Kconfig | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Richard Henderson May 30, 2023, 1:36 p.m. UTC | #2
On 5/30/23 03:20, Thomas Huth wrote:
> The PowerMacs have an OHCI controller soldered on the motherboard,
> so this should always be enabled for the "mac99" machine.
> This fixes the problem that QEMU aborts when the user tries to run
> the "mac99" machine with a build that has been compiled with the
> "--without-default-devices" configure switch.
> 
> Signed-off-by: Thomas Huth<thuth@redhat.com>
> ---
>   hw/ppc/Kconfig | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~
Mark Cave-Ayland May 31, 2023, 8:10 a.m. UTC | #3
On 30/05/2023 11:20, Thomas Huth wrote:

> The PowerMacs have an OHCI controller soldered on the motherboard,
> so this should always be enabled for the "mac99" machine.
> This fixes the problem that QEMU aborts when the user tries to run
> the "mac99" machine with a build that has been compiled with the
> "--without-default-devices" configure switch.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   hw/ppc/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig
> index a689d9b219..5dfbf47ef5 100644
> --- a/hw/ppc/Kconfig
> +++ b/hw/ppc/Kconfig
> @@ -115,6 +115,7 @@ config MAC_NEWWORLD
>       select MAC_PMU
>       select UNIN_PCI
>       select FW_CFG_PPC
> +    select USB_OHCI_PCI
>   
>   config E500
>       bool

Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


ATB,

Mark.
diff mbox series

Patch

diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig
index a689d9b219..5dfbf47ef5 100644
--- a/hw/ppc/Kconfig
+++ b/hw/ppc/Kconfig
@@ -115,6 +115,7 @@  config MAC_NEWWORLD
     select MAC_PMU
     select UNIN_PCI
     select FW_CFG_PPC
+    select USB_OHCI_PCI
 
 config E500
     bool