| Message ID | 20230524200212.1354804-1-richard.henderson@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | tcg: Fix register move type in tcg_out_ld_helper_ret | expand |
On 5/24/23 13:02, Richard Henderson wrote: > The first move was incorrectly using TCG_TYPE_I32 while the second > move was correctly using TCG_TYPE_REG. This prevents a 64-bit host > from moving all 128-bits of the return value. > > Fixes: ebebea53ef8 ("tcg: Support TCG_TYPE_I128 in tcg_out_{ld,st}_helper_{args,ret}") > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > tcg/tcg.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tcg/tcg.c b/tcg/tcg.c > index ac30d484f5..2352ca4ade 100644 > --- a/tcg/tcg.c > +++ b/tcg/tcg.c > @@ -5736,8 +5736,8 @@ static void tcg_out_ld_helper_ret(TCGContext *s, const TCGLabelQemuLdst *ldst, > mov[0].dst = ldst->datalo_reg; > mov[0].src = > tcg_target_call_oarg_reg(TCG_CALL_RET_NORMAL, HOST_BIG_ENDIAN); > - mov[0].dst_type = TCG_TYPE_I32; > - mov[0].src_type = TCG_TYPE_I32; > + mov[0].dst_type = TCG_TYPE_REG; > + mov[0].src_type = TCG_TYPE_REG; > mov[0].src_ext = TCG_TARGET_REG_BITS == 32 ? MO_32 : MO_64; > > mov[1].dst = ldst->datahi_reg; Superseded by Message-Id: <20230526002334.1760495-1-richard.henderson@linaro.org> r~
diff --git a/tcg/tcg.c b/tcg/tcg.c index ac30d484f5..2352ca4ade 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -5736,8 +5736,8 @@ static void tcg_out_ld_helper_ret(TCGContext *s, const TCGLabelQemuLdst *ldst, mov[0].dst = ldst->datalo_reg; mov[0].src = tcg_target_call_oarg_reg(TCG_CALL_RET_NORMAL, HOST_BIG_ENDIAN); - mov[0].dst_type = TCG_TYPE_I32; - mov[0].src_type = TCG_TYPE_I32; + mov[0].dst_type = TCG_TYPE_REG; + mov[0].src_type = TCG_TYPE_REG; mov[0].src_ext = TCG_TARGET_REG_BITS == 32 ? MO_32 : MO_64; mov[1].dst = ldst->datahi_reg;
The first move was incorrectly using TCG_TYPE_I32 while the second move was correctly using TCG_TYPE_REG. This prevents a 64-bit host from moving all 128-bits of the return value. Fixes: ebebea53ef8 ("tcg: Support TCG_TYPE_I128 in tcg_out_{ld,st}_helper_{args,ret}") Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- tcg/tcg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)