diff mbox series

[09/12] audio/pw: add more error reporting

Message ID 20230506163735.3481387-10-marcandre.lureau@redhat.com
State New
Headers show
Series audio: pipewire backend improvements | expand

Commit Message

Marc-André Lureau May 6, 2023, 4:37 p.m. UTC 
From: Marc-André Lureau <marcandre.lureau@redhat.com>

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 audio/pwaudio.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Comments

Volker Rümelin May 7, 2023, 3:32 p.m. UTC | #1 
> From: Marc-André Lureau<marcandre.lureau@redhat.com>
>
> Signed-off-by: Marc-André Lureau<marcandre.lureau@redhat.com>
> ---
>   audio/pwaudio.c | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)

Reviewed-by: Volker Rümelin <vr_qemu@t-online.de>

> diff --git a/audio/pwaudio.c b/audio/pwaudio.c
> index 67df53948c..5c706a9fde 100644
> --- a/audio/pwaudio.c
> +++ b/audio/pwaudio.c
> @@ -429,6 +429,10 @@ create_stream(pwaudio *c, PWVoice *v, const char *stream_name,
>       struct pw_properties *props;
>   
>       props = pw_properties_new(NULL, NULL);
> +    if (!props) {
> +        error_report("Failed to create PW properties: %s", g_strerror(errno));
> +        return -1;
> +    }
>   
>       /* 75% of the timer period for faster updates */
>       buf_samples = (uint64_t)v->g->dev->timer_period * v->info.rate
> @@ -441,8 +445,8 @@ create_stream(pwaudio *c, PWVoice *v, const char *stream_name,
>           pw_properties_set(props, PW_KEY_TARGET_OBJECT, name);
>       }
>       v->stream = pw_stream_new(c->core, stream_name, props);
> -
>       if (v->stream == NULL) {
> +        error_report("Failed to create PW stream: %s", g_strerror(errno));
>           return -1;
>       }
>   
> @@ -470,6 +474,7 @@ create_stream(pwaudio *c, PWVoice *v, const char *stream_name,
>                               PW_STREAM_FLAG_MAP_BUFFERS |
>                               PW_STREAM_FLAG_RT_PROCESS, params, n_params);
>       if (res < 0) {
> +        error_report("Failed to connect PW stream: %s", g_strerror(errno));
>           pw_stream_destroy(v->stream);
>           return -1;
>       }
diff mbox series

Patch

diff --git a/audio/pwaudio.c b/audio/pwaudio.c
index 67df53948c..5c706a9fde 100644
--- a/audio/pwaudio.c
+++ b/audio/pwaudio.c
@@ -429,6 +429,10 @@  create_stream(pwaudio *c, PWVoice *v, const char *stream_name,
     struct pw_properties *props;
 
     props = pw_properties_new(NULL, NULL);
+    if (!props) {
+        error_report("Failed to create PW properties: %s", g_strerror(errno));
+        return -1;
+    }
 
     /* 75% of the timer period for faster updates */
     buf_samples = (uint64_t)v->g->dev->timer_period * v->info.rate
@@ -441,8 +445,8 @@  create_stream(pwaudio *c, PWVoice *v, const char *stream_name,
         pw_properties_set(props, PW_KEY_TARGET_OBJECT, name);
     }
     v->stream = pw_stream_new(c->core, stream_name, props);
-
     if (v->stream == NULL) {
+        error_report("Failed to create PW stream: %s", g_strerror(errno));
         return -1;
     }
 
@@ -470,6 +474,7 @@  create_stream(pwaudio *c, PWVoice *v, const char *stream_name,
                             PW_STREAM_FLAG_MAP_BUFFERS |
                             PW_STREAM_FLAG_RT_PROCESS, params, n_params);
     if (res < 0) {
+        error_report("Failed to connect PW stream: %s", g_strerror(errno));
         pw_stream_destroy(v->stream);
         return -1;
     }