Message ID | 20230331150609.114401-6-liweiwei@iscas.ac.cn |
---|---|
State | New |
Headers | show |
Series | target/riscv: Fix pointer mask related support | expand |
On 3/31/23 08:06, Weiwei Li wrote: > CPUs often set CF_PCREL in tcg_cflags before qemu_init_vcpu(), in which > tcg_cflags will be overwrited by tcg_cpu_init_cflags(). > > Signed-off-by: Weiwei Li<liweiwei@iscas.ac.cn> > Signed-off-by: Junqiang Wang<wangjunqiang@iscas.ac.cn> > --- > accel/tcg/tcg-accel-ops.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
On 3/31/23 18:18, Richard Henderson wrote: > On 3/31/23 08:06, Weiwei Li wrote: >> CPUs often set CF_PCREL in tcg_cflags before qemu_init_vcpu(), in which >> tcg_cflags will be overwrited by tcg_cpu_init_cflags(). >> >> Signed-off-by: Weiwei Li<liweiwei@iscas.ac.cn> >> Signed-off-by: Junqiang Wang<wangjunqiang@iscas.ac.cn> >> --- >> accel/tcg/tcg-accel-ops.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Fixes: 4be790263ffc ("accel/tcg: Replace `TARGET_TB_PCREL` with `CF_PCREL`") r~
On 3/31/23 18:33, Richard Henderson wrote: > On 3/31/23 18:18, Richard Henderson wrote: >> On 3/31/23 08:06, Weiwei Li wrote: >>> CPUs often set CF_PCREL in tcg_cflags before qemu_init_vcpu(), in which >>> tcg_cflags will be overwrited by tcg_cpu_init_cflags(). >>> >>> Signed-off-by: Weiwei Li<liweiwei@iscas.ac.cn> >>> Signed-off-by: Junqiang Wang<wangjunqiang@iscas.ac.cn> >>> --- >>> accel/tcg/tcg-accel-ops.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> > > Fixes: 4be790263ffc ("accel/tcg: Replace `TARGET_TB_PCREL` with `CF_PCREL`") Queued to tcg-next. r~
diff --git a/accel/tcg/tcg-accel-ops.c b/accel/tcg/tcg-accel-ops.c index af35e0d092..58c8e64096 100644 --- a/accel/tcg/tcg-accel-ops.c +++ b/accel/tcg/tcg-accel-ops.c @@ -59,7 +59,7 @@ void tcg_cpu_init_cflags(CPUState *cpu, bool parallel) cflags |= parallel ? CF_PARALLEL : 0; cflags |= icount_enabled() ? CF_USE_ICOUNT : 0; - cpu->tcg_cflags = cflags; + cpu->tcg_cflags |= cflags; } void tcg_cpus_destroy(CPUState *cpu)