Message ID | 20230327080858.39703-5-liweiwei@iscas.ac.cn |
---|---|
State | New |
Headers | show |
Series | target/riscv: Simplification for RVH related check and code style fix | expand |
On Mon, Mar 27, 2023 at 6:12 PM Weiwei Li <liweiwei@iscas.ac.cn> wrote: > > In current implementation, riscv_cpu_set_virt_enabled is only called when > RVH is enabled. > > Signed-off-by: Weiwei Li <liweiwei@iscas.ac.cn> > Signed-off-by: Junqiang Wang <wangjunqiang@iscas.ac.cn> > Reviewed-by: Richard Henderson <richard.henderson@linaro.org> > Reviewed-by: LIU Zhiwei <zhiwei_liu@linux.alibaba.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > target/riscv/cpu_helper.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c > index 62fd2c90f1..b286118a6b 100644 > --- a/target/riscv/cpu_helper.c > +++ b/target/riscv/cpu_helper.c > @@ -563,12 +563,9 @@ bool riscv_cpu_virt_enabled(CPURISCVState *env) > return get_field(env->virt, VIRT_ONOFF); > } > > +/* This function can only be called to set virt when RVH is enabled */ > void riscv_cpu_set_virt_enabled(CPURISCVState *env, bool enable) > { > - if (!riscv_has_ext(env, RVH)) { > - return; > - } > - > /* Flush the TLB on all virt mode changes. */ > if (get_field(env->virt, VIRT_ONOFF) != enable) { > tlb_flush(env_cpu(env)); > -- > 2.25.1 > >
diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c index 62fd2c90f1..b286118a6b 100644 --- a/target/riscv/cpu_helper.c +++ b/target/riscv/cpu_helper.c @@ -563,12 +563,9 @@ bool riscv_cpu_virt_enabled(CPURISCVState *env) return get_field(env->virt, VIRT_ONOFF); } +/* This function can only be called to set virt when RVH is enabled */ void riscv_cpu_set_virt_enabled(CPURISCVState *env, bool enable) { - if (!riscv_has_ext(env, RVH)) { - return; - } - /* Flush the TLB on all virt mode changes. */ if (get_field(env->virt, VIRT_ONOFF) != enable) { tlb_flush(env_cpu(env));