diff mbox series

[1/3] hw/core: Tidy up unnecessary casting away of const

Message ID 20220923120025.448759-2-armbru@redhat.com
State New
Headers show
Series Drop useless casts from void * to pointer | expand

Commit Message

Markus Armbruster Sept. 23, 2022, noon UTC 
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 hw/core/sysbus-fdt.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Laurent Vivier Oct. 22, 2022, 8:50 p.m. UTC | #1 
Le 23/09/2022 à 14:00, Markus Armbruster a écrit :
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>   hw/core/sysbus-fdt.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/core/sysbus-fdt.c b/hw/core/sysbus-fdt.c
> index edb0c49b19..eebcd28f9a 100644
> --- a/hw/core/sysbus-fdt.c
> +++ b/hw/core/sysbus-fdt.c
> @@ -299,7 +299,8 @@ static int add_amd_xgbe_fdt_node(SysBusDevice *sbdev, void *opaque)
>       void *guest_fdt = data->fdt, *host_fdt;
>       const void *r;
>       int i, prop_len;
> -    uint32_t *irq_attr, *reg_attr, *host_clock_phandles;
> +    uint32_t *irq_attr, *reg_attr;
> +    const uint32_t *host_clock_phandles;
>       uint64_t mmio_base, irq_number;
>       uint32_t guest_clock_phandles[2];
>   
> @@ -339,7 +340,7 @@ static int add_amd_xgbe_fdt_node(SysBusDevice *sbdev, void *opaque)
>           error_report("%s clocks property should contain 2 handles", __func__);
>           exit(1);
>       }
> -    host_clock_phandles = (uint32_t *)r;
> +    host_clock_phandles = r;
>       guest_clock_phandles[0] = qemu_fdt_alloc_phandle(guest_fdt);
>       guest_clock_phandles[1] = qemu_fdt_alloc_phandle(guest_fdt);
>   

Applied to my trivial-patches branch.

Thanks,
Laurent
diff mbox series

Patch

diff --git a/hw/core/sysbus-fdt.c b/hw/core/sysbus-fdt.c
index edb0c49b19..eebcd28f9a 100644
--- a/hw/core/sysbus-fdt.c
+++ b/hw/core/sysbus-fdt.c
@@ -299,7 +299,8 @@  static int add_amd_xgbe_fdt_node(SysBusDevice *sbdev, void *opaque)
     void *guest_fdt = data->fdt, *host_fdt;
     const void *r;
     int i, prop_len;
-    uint32_t *irq_attr, *reg_attr, *host_clock_phandles;
+    uint32_t *irq_attr, *reg_attr;
+    const uint32_t *host_clock_phandles;
     uint64_t mmio_base, irq_number;
     uint32_t guest_clock_phandles[2];
 
@@ -339,7 +340,7 @@  static int add_amd_xgbe_fdt_node(SysBusDevice *sbdev, void *opaque)
         error_report("%s clocks property should contain 2 handles", __func__);
         exit(1);
     }
-    host_clock_phandles = (uint32_t *)r;
+    host_clock_phandles = r;
     guest_clock_phandles[0] = qemu_fdt_alloc_phandle(guest_fdt);
     guest_clock_phandles[1] = qemu_fdt_alloc_phandle(guest_fdt);