| Message ID | 20220808125706.60511-1-pbonzini@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 08/08/2022 14.57, Paolo Bonzini wrote: > The following changes since commit 3916603e0c1d909e14e09d5ebcbdaa9c9e21adf3: > > Merge tag 'pull-la-20220729' of https://gitlab.com/rth7680/qemu into staging (2022-07-29 17:39:17 -0700) > > are available in the Git repository at: > > https://gitlab.com/bonzini/qemu.git tags/for-upstream > > for you to fetch changes up to f6a5f380627ab2af384bf2f2940d29386dea11ff: > > tests/qtest: add scenario for -readconfig handling (2022-08-08 14:54:56 +0200) > > ---------------------------------------------------------------- > * Fix and tests for -readconfig > * Fixes for changeable block size > > ---------------------------------------------------------------- > Daniel P. Berrangé (1): > tests/qtest: add scenario for -readconfig handling I still had some questions wrt to Daniel's patch, especially there seems to be a bug ("spcie" instead of "spice"), see: https://lists.gnu.org/archive/html/qemu-devel/2022-08/msg01153.html I doubt that this test is working if spice is enabled... (which leads us to the next question: if the CI did not fail for you, are we missing a build with spice enabled there?) Thomas
On 8/8/22 05:57, Paolo Bonzini wrote: > The following changes since commit 3916603e0c1d909e14e09d5ebcbdaa9c9e21adf3: > > Merge tag 'pull-la-20220729' of https://gitlab.com/rth7680/qemu into staging (2022-07-29 17:39:17 -0700) > > are available in the Git repository at: > > https://gitlab.com/bonzini/qemu.git tags/for-upstream > > for you to fetch changes up to f6a5f380627ab2af384bf2f2940d29386dea11ff: > > tests/qtest: add scenario for -readconfig handling (2022-08-08 14:54:56 +0200) > > ---------------------------------------------------------------- > * Fix and tests for -readconfig > * Fixes for changeable block size Applied, thanks. Please update https://wiki.qemu.org/ChangeLog/7.1 as appropriate. r~ > > ---------------------------------------------------------------- > Daniel P. Berrangé (1): > tests/qtest: add scenario for -readconfig handling > > Mark Cave-Ayland (2): > scsi-disk: fix overflow when block size is not a multiple of BDRV_SECTOR_SIZE > scsi-disk: ensure block size is non-zero and changes limited to bits 8-15 > > Paolo Bonzini (2): > vl: fix [memory] section with -readconfig > vl: remove dead code in parse_memory_options() > > hw/scsi/scsi-disk.c | 25 ++++-- > softmmu/vl.c | 32 ++++--- > tests/qtest/meson.build | 1 + > tests/qtest/readconfig-test.c | 195 ++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 229 insertions(+), 24 deletions(-) > create mode 100644 tests/qtest/readconfig-test.c
On 8/8/22 07:23, Thomas Huth wrote: > On 08/08/2022 14.57, Paolo Bonzini wrote: >> The following changes since commit 3916603e0c1d909e14e09d5ebcbdaa9c9e21adf3: >> >> Merge tag 'pull-la-20220729' of https://gitlab.com/rth7680/qemu into staging >> (2022-07-29 17:39:17 -0700) >> >> are available in the Git repository at: >> >> https://gitlab.com/bonzini/qemu.git tags/for-upstream >> >> for you to fetch changes up to f6a5f380627ab2af384bf2f2940d29386dea11ff: >> >> tests/qtest: add scenario for -readconfig handling (2022-08-08 14:54:56 +0200) >> >> ---------------------------------------------------------------- >> * Fix and tests for -readconfig >> * Fixes for changeable block size >> >> ---------------------------------------------------------------- >> Daniel P. Berrangé (1): >> tests/qtest: add scenario for -readconfig handling > > I still had some questions wrt to Daniel's patch, especially there seems to be a bug > ("spcie" instead of "spice"), see: > > https://lists.gnu.org/archive/html/qemu-devel/2022-08/msg01153.html > > I doubt that this test is working if spice is enabled... > (which leads us to the next question: if the CI did not fail for you, are we missing a > build with spice enabled there?) Arg. I didn't notice this until after I'd done the push to master. I see from Daniel's reply that the string with the typo doesn't seem to be used, but please do let's fix this asap. r~
On 8/8/22 16:23, Thomas Huth wrote: > > I still had some questions wrt to Daniel's patch, especially there seems > to be a bug ("spcie" instead of "spice"), see: > > https://lists.gnu.org/archive/html/qemu-devel/2022-08/msg01153.html > > I doubt that this test is working if spice is enabled... > (which leads us to the next question: if the CI did not fail for you, > are we missing a build with spice enabled there?) Fortunately the typo is not an issue; the top item of the visit does not have a key and therefore the name passed to the toplevel visit_type_* call is not used. Paolo
The following changes since commit 3916603e0c1d909e14e09d5ebcbdaa9c9e21adf3: Merge tag 'pull-la-20220729' of https://gitlab.com/rth7680/qemu into staging (2022-07-29 17:39:17 -0700) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for you to fetch changes up to f6a5f380627ab2af384bf2f2940d29386dea11ff: tests/qtest: add scenario for -readconfig handling (2022-08-08 14:54:56 +0200) ---------------------------------------------------------------- * Fix and tests for -readconfig * Fixes for changeable block size ---------------------------------------------------------------- Daniel P. Berrangé (1): tests/qtest: add scenario for -readconfig handling Mark Cave-Ayland (2): scsi-disk: fix overflow when block size is not a multiple of BDRV_SECTOR_SIZE scsi-disk: ensure block size is non-zero and changes limited to bits 8-15 Paolo Bonzini (2): vl: fix [memory] section with -readconfig vl: remove dead code in parse_memory_options() hw/scsi/scsi-disk.c | 25 ++++-- softmmu/vl.c | 32 ++++--- tests/qtest/meson.build | 1 + tests/qtest/readconfig-test.c | 195 ++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 229 insertions(+), 24 deletions(-) create mode 100644 tests/qtest/readconfig-test.c